Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s7XrB-0068yL-A9 for pgsql-bugs@arkaria.postgresql.org; Thu, 16 May 2024 09:57:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1s7XrB-004uoh-3d for pgsql-bugs@arkaria.postgresql.org; Thu, 16 May 2024 09:57:01 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s7XrA-004uoZ-Pm for pgsql-bugs@lists.postgresql.org; Thu, 16 May 2024 09:57:00 +0000 Received: from mail-sy4aus01olkn2167.outbound.protection.outlook.com ([40.92.62.167] helo=AUS01-SY4-obe.outbound.protection.outlook.com) by magus.postgresql.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s7Xr6-000WJu-KS for pgsql-bugs@lists.postgresql.org; Thu, 16 May 2024 09:56:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hc6ttUQJFJs1iSf8GihVFQNp5NO301MDP8GjBGZyhcpNmBxM3Fneiu/HIVefGaJo/fL3dDezpbCeQL6foINtgGtCyimff3qcOc2pJZ9GXYBdB3ee1gV6df4EJoIpAbYYJX49AzsnQOpn2n6bRCRhCf3IeWWJPPgDX9nLNlL5zzNZ159rBhU90EBcLR5pTLlZbkokguMldLjs8DjLOi5SQUTAgG1lKaEaWwPOQRrWy/HfoZyDy5Ac45AVTbDoGZHUm7LhAGmL7pXumxP3a9qWRS5wxJ58obzx0qAYfgdTilmITvzI6OCCmQxpq74oZHMGIZPqAdnK1F6TNt9sZYRQHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FedmBZ4Pagmi4jfb1oYQEj9qCmM/plzJAQLALUVhcqI=; b=exnVbSgm+Bayn2kuVzOS+gv8yz97nSJ/OkGVuQJW9/OR0gcshiMt0g0XtISVUvysBBWNmBgkJxNvGYeYnORKwo8IHvdN+21rml6fujatB42c2LgTH6Qz3DgO3MKZwKpdyvsRiAqJApp03cmG1VlwBEo4noLlE3zjKQvOj2lxJzZba+oAkkTHGQPNj6/Nb62VFdls/xNLuJBEblpnvPxFXbLjISS1uCBJ4w9kg9cT50ssakdXzGC+QuQxWRJpVeAWqB1mEGQhECm1uu19UlxdyOf7m4wpphB9sX2Cow2VDeaE++iHbsvMwR5Zyga5ikRVMiAYDkxWwfHDlh4KBitXdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FedmBZ4Pagmi4jfb1oYQEj9qCmM/plzJAQLALUVhcqI=; b=WXEWw681P6oSBT6ry0e6eo2QTjbiNpqlM5rRl0EC1LwybA6NG/3zwzn0snUQTFX91IO2ifktE7BHEgzBpdx2s/Z0w9giVulbE/7y9vLLjp3NlNFe9fazDZrgQNChFpowkrkMcil9cAuK7+XSjpcVJAlTPt7Sn6vqlriJXEWU6JtK7XzXRYgyWjz1sBV2IQJjCMp1z/0rJ+G1Ea5kBzrhGFJ+uVxNH6D9t9UnqCFPxcJxjGiZSTVyuihimIY1qSzoryyKNxvKyoKovN+TjD/hZ3vyaruRbGrXOQps5nE3OiEuE5QpYddaxXfhUTgxPezQT6ZabAcG2zXryL23G8IKHg== Received: from ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:147::21) by SY5P282MB4796.AUSP282.PROD.OUTLOOK.COM (2603:10c6:10:270::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.45; Thu, 16 May 2024 09:56:51 +0000 Received: from ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM ([fe80::4158:743a:ffd4:1274]) by ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM ([fe80::4158:743a:ffd4:1274%4]) with mapi id 15.20.7587.028; Thu, 16 May 2024 09:56:51 +0000 References: <18467-7bb89084ff03a08d@postgresql.org> User-agent: mu4e 1.4.15; emacs 28.1 From: Japin Li To: =?utf-8?B?w5ZuZGVyIEthbGFjxLE=?= Cc: Etsuro Fujita , pgsql-bugs@lists.postgresql.org Subject: Re: BUG #18467: postgres_fdw (deparser) ignores LimitOption In-reply-to: Date: Thu, 16 May 2024 17:56:46 +0800 Message-ID: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-TMN: [PxstZnfiV0jLRC2482c3aXtBHZGKiDJu1JeC1NXF9Lw=] X-ClientProxiedBy: TYCP301CA0062.JPNP301.PROD.OUTLOOK.COM (2603:1096:405:7d::15) To ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:147::21) X-Microsoft-Original-Message-ID: <87ttiy2i75.fsf@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: ME3P282MB3166:EE_|SY5P282MB4796:EE_ X-MS-Office365-Filtering-Correlation-Id: fa68fe9a-3441-4f06-cf6a-08dc758e821f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 65J4TbVP7jBO1pV0NzCcc2ODlgcPmLBH2GJ6fza1xMlKUe5ngVpA3FIYKTw2OsfLbcJOhsd3VbWQZAUNB/gMh5ISZvbNx38iIxmUo+UH5mV5tE1SwwWUJY2OrRbq+SlRuEFvhDV8jGSq72UTFEH71GMQO0AP/J2qAj9hA2rcPYcTVxJtaNV0XLYErMhEQ4cGjLH+ED0wRTcHElnbvxtQom6m7W1Fx825uUBc+FlNarDyjfOldPfSY/KXayGdSXzvYt3J1JmoH6xbBOPlM6JbYXv+C/yLDZLNoBa7V+hv8dxD2k/wddL/JNc0cAZNuHm7vBnOO+5f68y0ZZ9mLiwYhaQ4bolcd2QRZaVJGvTNHYNy5LO20E0la+ruSn18dv5s5Q9rLJR0Kif0gyBbY3nLFGWK60unVcpBVFVoyEnc9UMbgjBudgRFB0/ViyCpMYM7B9oSVqPmBIlHyX7oyVPtUlw654fkH17NiDU2cS6mo2/vd5dUk6yDb/j4+JAejkAPQonzcds/bL/f7+KTjQn15pZY78nnfT0v92n1lArqtcHCrUpMzE1+WI298NlR6KFfPHkUXVCsNEOFZy/QcbIRfWvdVCRr5WpIy8zfMv99E5bTK+rLRRJD6kiVX6amHvzK31bdavtT9+yO1bfniCkQn4x6dcCeVhHoYdkHGQnklN0= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TWFXUExTeUtLa0wrcmtZbFYva1pCend0cXRjSmZBT3djWlhIZEh4WmtKWTUy?= =?utf-8?B?Rk1qZEJWdmNkK1Z3ZzBHblNzM1IxalBOc1R4QS9wMk8wUnRiTUJocnlEOFZr?= =?utf-8?B?TjdwNElJOGNQT1RYeGEyVkZ6U2lMV1BmVjJiSXJkRkF6ejh0SXNxQU5uaThZ?= =?utf-8?B?c0taNVo0TWhRUWViTUtKbHk4eHRDTC9kUTlKcDQ0aW5UUy9ibC9aQ0xTUUQz?= =?utf-8?B?TURXTk1UekpROGl4bWR1dFNPc3RFa2VLQWhqZllzZXJDNkhZVVp4TU9hWlZD?= =?utf-8?B?Nnh1OU9vVDdob01VSXh3Q1NxNUtiK094QytHU3ZhZHJSMTNLTFVOSlVOUzVI?= =?utf-8?B?VFAxanRIb0FWNE9ESmFTbll6MFpYdUhPbDBNa1I0ZU5EemNZelhHUDhYdVYz?= =?utf-8?B?UWRUYUxpZ0x4cHVCZ0VPcmNrb1c5NFR3OExhcGNDbVJDRUFycjNMa21TR2pw?= =?utf-8?B?K0JBLzREMTBwU2xqSEM4dHlxQnFhZWZoYURiem1OZElsOGtGVkF1Wld4WmQ3?= =?utf-8?B?YTUwK2drTFA1c3dpUzhxY2FhYVh0Z1hKb1FKOU0vaEV5alVscUFNUTlNS1dh?= =?utf-8?B?N3pHOFhDQmViMlFGUTZCSjcxOHJ6M3B4aDBZNnBSS2x5TnlwT3U0NDZ5aTlV?= =?utf-8?B?aXl0ZHlJNU8rM1FvK1JhK2ptZ0dMRnJkUVNCNW1UL0JSeWFkdmQzZEYyWjVk?= =?utf-8?B?eStuUldXTkliZGpwTUtLN3Q1SnhuaTRhdGprRFVtK3k1b0R4YkZXaXkwQ0dv?= =?utf-8?B?NzlHdXNqYjZYMmpEaTBQS1VNUUtFaWs1Nk9iRHQ5M3NxOU9PZ3I4Vmg5Wm9a?= =?utf-8?B?eVJCOENPKzVFeURqazBIaHRxdnRkYUU0RmNMN3YxUWZGbzRJRks2R3U5SGRi?= =?utf-8?B?L1BuRU4xWDJ0bU4rK2g4VFdtQzFsclMxczgzcUlLTFdOUFlmcmsvbEtIa1RZ?= =?utf-8?B?a2kzOW02SEFNOVB5VGEyWDJNb2Zxc0lvYmd4VlhhTHF5QWhESWpPdFI3MEIw?= =?utf-8?B?S0Zzb2FjcVZ4QTN3aEZJMFQrTmUvZjVYZG0wakxXcklDWU84Q09xUHEvdVli?= =?utf-8?B?dTdENTNTeFc4Rm45eUR3OHNOS1VIbDBSOExoa1FKSWlILzA1bGpwOHNNY2FT?= =?utf-8?B?WVBVQ1Q5MkJkS201YVJDcGt2bGJ3QXpReW52TmliV1dhbXh5bElWa055VTNR?= =?utf-8?B?MytmSDB2VXRIL2kyVlE3Um42bGg1VFFHbk50cVFzQ1l1WHRRZ084QjJPaTVS?= =?utf-8?B?Zm5wY2lzSTVaeXprMlFRMGFna1ZVQTlFQWdTTW9acGZyQ3NiekswYkJuWTl2?= =?utf-8?B?NVpZM2xhSmhvYTBMY2dlK2F4NmRKRzJrZFBSVTl5Z3psdnIwRG5iYjd4Zkkx?= =?utf-8?B?NzFsOG5vNVdiN1NPTVhocll0K0ErQ2ZhbWZ5dDVQNHFDbXJqWEwwK1FvUkFr?= =?utf-8?B?NTZ2STNvaVQvRndKRmwvZUk5TG1SRnQ2U1VHTkp1ZVlmTkc3R0hRWEdpZUxa?= =?utf-8?B?U2lPZ09KOTcyNmlldjdIL3RhMVc1SWhjQlY0RUVFcXFhQ1J4azgvM0JoMSsy?= =?utf-8?B?M1JzejNLbHRhL0VTc2w2Lyt5ZGcwc0hjNS9wNG5zSmVwNlhXTHNPbmMxbHhM?= =?utf-8?Q?fD2SZfTepImIl/8Gk4fwunmFGq7AguN3gB12s8bLSX74=3D?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-746f3.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: fa68fe9a-3441-4f06-cf6a-08dc758e821f X-MS-Exchange-CrossTenant-AuthSource: ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2024 09:56:51.0286 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SY5P282MB4796 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu, 16 May 2024 at 17:02, =C3=96nder Kalac=C4=B1 wrote: > Hi Japin, > >> >> >> Here is a poc patch to verify the above. >> >> > The patch looks reasonable to me, it is in line with `get_select_query_de= f() > ` > . > > Though, probably requires a regression test. > Yeah, add the regression test in v2 patch [1]. [1] https://www.postgresql.org/message-id/ME3P282MB31666446BF8A0C0F7A02D24C= B6ED2%40ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM -- Regards, Japin Li