References: <17983-da4569fcb878672e@postgresql.org>
 <MEYP282MB16691E0295CE3501C8EABD89B65CA@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM>
 <3505791.1687278747@sss.pgh.pa.us>
User-agent: mu4e 1.4.15; emacs 28.1
From: Japin Li <japinli@hotmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17983: Assert IsTransactionState() failed when empty
 string statement prepared in aborted transaction
In-reply-to: <3505791.1687278747@sss.pgh.pa.us>
Date: Wed, 21 Jun 2023 09:45:23 +0800
Message-ID: 
 <MEYP282MB16694FA5DA0442708310344DB65DA@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: MEYP282MB1669:EE_|SY4P282MB2490:EE_
X-MS-Office365-Filtering-Correlation-Id: f7d4adbb-2ad4-48de-7f0c-08db71f9318e
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	cOSI9a6Zgl+Uta1LszLAuKZQEuJg4ora74ZPm2QKuGA8WOyq/hNI5QokFRSiMUUNfxC+1bNLZXzRl8sY73bJt/cyBtGVBY+0UuGR77O4Q0Gw0gbMd0iV1gdBDZC5hOjQm1PYhhkwCC8j5/uB5LOS3zWbOrORGka43uCV3Jy2H/joN4BNAi+213y/8ZJDqAcfwkhaFRJhBvroye5VYv+df0R5f05Q6sHqIYoLAI54MIEAsG1PCFLvYRBqrWL/KOaDlbR3EOb0cAt7GrQgF+YOdn24yn3wGGlVH+zGWGYd0/2yAsXja92ZsxoFx/kidbPx+oCZhEJsXJEkmk5fPQCIcqqtRsp9jJy199LhuXmcRyPTfMg3Fc++NdLeyMizRoB9dSOtFbqfc1174u51JmKEFRRpaAMq+3BhIrUjlE6rfLCF0bd8pjlYdjR3rqp+EYxDsJYEVfAgYzMJyim45tCfR8+3a3Ps1eABEL2hy3szGZhn5uuB8WFFJb/u94/k95Yr3cvXFjibgsXYxvfpWZt+to5eh8srS9grbm1yD0DaR36HyL/t37CBV38bzXg2ZRlsr99cPOCps/dlvg/luAtm1HW4n1MfBZS2q2N3H23hgjYpGNfr33z6/lnHOSjsZl9q
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?W7EPNd4MtEwvhWODoPNrZ0iqWCHIjms++ktessrWIAxXxbACwCWELlasbIgO?=
 =?us-ascii?Q?CWuEIk3tb8CIo1jLggMDKZQNXlqfEr+tvpRDxcwfWJ5HJlOqkN0JnCWpKPVV?=
 =?us-ascii?Q?pmFKED6Wg3e+8xYthq6Tc55Ebhq9ajz1UOE0Em96w2R+7jWE1bidaDrB0OTM?=
 =?us-ascii?Q?qi+FyTEhwfMx+PLVtDGU6K4dBLIv/tdtJyNeeBJEyAj8bMlxxWd5ZFmLO9TP?=
 =?us-ascii?Q?ScgQG4TVV32IiV4FB9uwVloi6BcB0BqODgTmRxF1cmnEu72C1GSbY1laJIEn?=
 =?us-ascii?Q?0AivGi2c4i9Aw8y7wuvU7imvnNQ5/UVRL8RC4Q9HSDHrI9sXhltC6x3tUBze?=
 =?us-ascii?Q?YRcLqO+dIzcaYaEkKByjFGDz9JVUurdd3ILaWPjYowWPDKwvQpd/i+QkYYrC?=
 =?us-ascii?Q?XW4tamU9OLb6HEZ4lEdSgRsTarkGuUmdIdFtcGyt5V1AuhyPDCdGLBZfoNpP?=
 =?us-ascii?Q?Aajm4IAtRXryiBNX2bBTw52pr+RN++C9sFRgtB8Jd0s6aVzWrB7e2QaPCxyL?=
 =?us-ascii?Q?q0sJRsfd7o5EkUNyltuf8pbCr6ThNL6FbvGS6e8wo5IqvYoKhbu40M62OdyK?=
 =?us-ascii?Q?NUQOtQlWwx7/Qv9GjBb0Mk7LuN8nuIsGa2yi0Lx8/cRitADVrjt8qDlTZ0On?=
 =?us-ascii?Q?nR8s+8nH3GxmNVX5YLQPNYbn3K0rUWSvB/V0ym9GEQZmPneib/O3uWtUBtif?=
 =?us-ascii?Q?Z5o6SwIeZHL6bTM6pKpLBt734dBsCIpXGYYm8cvJe7zkR9NnE50mHFpQA7Zq?=
 =?us-ascii?Q?1InKVjWCfsBv/u5yzG7V68bDaRIxd5QDvGj+VXSAn5QYHw3g2ocospZIccUf?=
 =?us-ascii?Q?lJBt1fHwMBh2iPQ2E8XHf3qQRt8cYK9HhrpTf4SsmFqgCHWi8fkmwxfISpUQ?=
 =?us-ascii?Q?4BeswL/EUx6nrmC7RcmtELHDXMNuv2R93NElCmheBG4YKjfHJwL9REjINvvR?=
 =?us-ascii?Q?gNnSg1JWiqG7pifWCk+yH4b5jSa9cYBIwj9kqAMdvorFVy7yFqAz4P1DRInm?=
 =?us-ascii?Q?9lbvPbP6LlyNhwhBqdJ5cy8EDoDO4cs+ePG7nZPwjBtA0TxcLHP+3vvcz/dP?=
 =?us-ascii?Q?Pcrs6SAE41H7tevUM75YBd3bpxgA8TPXZv+7hNiQDBUORbpWg2buE1FsswLn?=
 =?us-ascii?Q?zuR/h+eekakj+2p/f8E6IHJB2Wd0xd5g1FbUrZu3Vtn058bUvKQ2H99eC9wG?=
 =?us-ascii?Q?N7DbH1h7+uNYzddOT01xrtGIMadanHHmoB7pbg=3D=3D?=
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-746f3.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: 
 f7d4adbb-2ad4-48de-7f0c-08db71f9318e
X-MS-Exchange-CrossTenant-AuthSource: MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2023 01:45:30.1602
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SY4P282MB2490
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Archived-At: 
 <https://www.postgresql.org/message-id/MEYP282MB16694FA5DA0442708310344DB65DA%40MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM>
Precedence: bulk


On Wed, 21 Jun 2023 at 00:32, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Japin Li <japinli@hotmail.com> writes:
>> Yeah, SearchSysCache1() need in an transaction block, here is a patch
>> fixed it.
>
> I'm not sure if anyone out there is expecting that this case should
> work, but it probably did work at one time.  Rather than throwing
> an error, it'd be better to fix plancache.c so it doesn't fail.
> I looked at the code and found that that's pretty much a one-line
> fix, because there are already code paths that avoid doing anything
> extra for transaction control commands (e.g ROLLBACK, which'd
> otherwise have this same issue).

Agreed, it's much better than throwing an error. LGTM.

>> Another question, why should we need to create a plan cache entry for
>> empty input?
>
> Well, we have to have something to support the wire protocol behavior
> for this case.  No doubt we could hack up postgres.c to handle it
> without a plan cache entry, but it'd be far more invasive to do it
> there.
>

Thanks for your explanation! Got it.

-- 
Regrads,
Japin Li.