Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 20 Feb 2023 16:59:25 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: sawada.mshk@gmail.com, exclusion@gmail.com,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17789: process_pgfdw_appname() fails for autovacuum workers
Message-ID: <Y/MoXUbuZty59gFj@paquier.xyz>
References: <17789-8b31c5a4672b74d9@postgresql.org>
 <20230214.140544.79456937383215325.horikyota.ntt@gmail.com>
 <CAD21AoArqZMZO71jPsO7HwtzKCykpW0Qvt3vSzjR+Qo0Gvx1bg@mail.gmail.com>
 <20230215.161254.1131534874642120926.horikyota.ntt@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="GCOqrqKQbmQk5N1l"
Content-Disposition: inline
In-Reply-To: <20230215.161254.1131534874642120926.horikyota.ntt@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/Y/MoXUbuZty59gFj%40paquier.xyz>
Precedence: bulk


--GCOqrqKQbmQk5N1l
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Feb 15, 2023 at 04:12:54PM +0900, Kyotaro Horiguchi wrote:
> By the way, when we designed that part, we first concluded that the
> user name and database name cannot be NULL before we later concluded
> that MyProcPort cannot be NULL. However, log_status_format() takes
> into account the case where MyProcPort stores NULL as user and
> database names.  Do you think we should still ignore the case of NULL
> user name and database names, even though our assumption about
> MyProcPort was found to be incorrect? In that case,
> log_status_format() replaces, for example, %u with '[unknown]'.

Hmm.  I think that I would play it safe but consistent here for %d and
%u as this code could be triggered in various contexts as far as I
understand:
- When MyProcPort is NULL, insert no data, because there is nothing to
report.
- When MyProcPort is not NULL but the %d or %u field is NULL, use
[unknown], because we just don't know what to show up, still there is
a MyProcPort.

This has the advantage to be able to make the difference in both
cases, which could be important for the end-user depending on the
context where the code is run.
--
Michael

--GCOqrqKQbmQk5N1l
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmPzKF0ACgkQnvQgOdby
QH0cKQ/9Fvhm0IEFIvimtI3VrCqkSER+5RtlvqppiEYUCvkAOcPzhYx4ljcBFme8
aqjrKSZWjm3RrKxjY9ElHvIFomdV8CG8p3GO4J1QpEDzaYClNLji+bP4a1B7ZXgD
V9Sr1gYWREdwY3ecng5tdwLnj9rd6OGMeHIysBD0j36A01EJCbemVeIOz+OTinYE
xxyMoRsvpw2w8+QiA69XuhP2+wc899R1DqkuRc4a1AQKJwRE90j+ccIjVXn6uziC
L+XyvVxADFOgOpd1SmBwtrALmWm+WF5oI+ZlDbPsPUBc544Bm9+0rs8gBqmkM8go
XiQhBGOXcEzES+omkMF/7jkXofP9HR8cs5vWKwIatpaJQo/0q8Y8fCgO8qMwhifU
qZryxNpY4/zk4qa6UXDhsGT5sik4gk3dMfnErcCsQeM8N5EjMp3Yd3R6e+iPYCg4
5CvB2ieGDvTquwy1bPULZdsH4Tcc4CDb+urmDIKvi1qFN6+hRmWxu36QoENVghLB
/XOgT9/W/3Oruq9jBJKr4Vrsic9vpfTk2ljkW7zTcEBULpfxcUQxnkYunKQDDSz1
i1MDTcTyPxGYWFpHNcxpXNGMhp2YrMS25OPPVZ3+KDtOfhDgEPOkTZRtmtNWxe7f
Mi5Pr8Zh2WMFliQbqvihxLpW53L9tQrv5BPUC9owIsU/QFgbonU=
=G/oJ
-----END PGP SIGNATURE-----

--GCOqrqKQbmQk5N1l--