Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 21 Feb 2023 07:49:25 +0900
From: Michael Paquier <michael@paquier.xyz>
To: exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17800: ON CONFLICT DO UPDATE fails to detect incompatible
 fields that leads to a server crash
Message-ID: <Y/P49Yov2m+VzfFf@paquier.xyz>
References: <17800-ff90866b3906c964@postgresql.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Pc3kgDYDL/8AUcPa"
Content-Disposition: inline
In-Reply-To: <17800-ff90866b3906c964@postgresql.org>
Archived-At: 
 <https://www.postgresql.org/message-id/Y/P49Yov2m%2BVzfFf%40paquier.xyz>
Precedence: bulk


--Pc3kgDYDL/8AUcPa
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Feb 18, 2023 at 08:00:00AM +0000, PG Bug reporting form wrote:
> INSERT INTO t VALUES (1), (2) ON CONFLICT(a)
>   DO UPDATE SET (a, b) =3D (SELECT t.a, t.b || '+');
>=20
> But when executing:
> UPDATE t SET (a, b) =3D (SELECT t.a, t.b || '+');
> I get:
> ERROR:  attribute 1 of type tp1 has wrong type
> DETAIL:  Table has type text, but query expects integer.

Reproduced here.

> By comparing two callstacks I can see that in the second case
> ExecInterpExprStillValid() is executed after the latest
> ExecEvalExprSwitchContext().
> The ExecInterpExprStillValid() function contains:
>         /* skip the check during further executions */
>         state->evalfunc =3D (ExprStateEvalFunc) state->evalfunc_private;
>=20
> If just call evalfunc_private() here, the first case ends with the error =
as
> expected.

Yeah, it would sound logic to me to have consistency with the
ExecEvalExprSwitchContext() checks here, so it seems like the executor
has missed the call for a long time.  Would you like to write a patch,
perhaps?  Did you bisect the origin of that?
--
Michael

--Pc3kgDYDL/8AUcPa
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmPz+PUACgkQnvQgOdby
QH0SQQ/+MLvlqK/JsCEltDWE2LE881HrEQI8hy2o0MEaPiAabNRBdzNeyPHnNu6X
mw0EjrSAIZm011EeMQKC45OXkttOzNIxg5ReLij5SELmh89edXRCDSaY7o2ujsxN
bT3e9Y/4XO1nCxs7/RxX+Ik4GDYw8UALjYCwyx1j0njjf1tShlgZswOEM6eU1A8s
rWHIFynGNDQ17tVt/Q22IQKu7RhkhZpJhN6/yTNv+U8tRYmQT7HdxCFrX4fz46i2
Y/2LGahPFoZAQYAIU5WiLxe7xx7g2CDG2YhHg07/MOVMQ8fGCy2254wK8vrWLmg8
/itJLGcUd1belNTTdFv2mo3DBJNjjNarfd9hYxGv5woa5JkBQAXRpkXB9MdNhd9D
+kHoV+VomjoRLs2TJtEPTtXkoh7gNVkGov3O69YBKANaQv35nB7IUWTpQ/R7qJHS
mG+pzmpAiJ7C2TTXnEfzxIp1ZiF+G38VjKW3bpu6VLKkI19RX5mKLOqefbvgagAZ
isAB3bfG4N3G2urgdFr32eVaucBTYxy8nK2j7pNk9xy/bGB3oFOHOVtpbuY+8mEZ
jkPpMYlzAxGsHz0QwArOFNlP/lVGwfZSI8LHSq+SV8yUJq0//s/d2qhr5GZt6IXH
X2bZGt5/Rz/m1U/q4jn1K4kEW7DxIPwxUGF72rGCd7btPFgjg5c=
=0Hfe
-----END PGP SIGNATURE-----

--Pc3kgDYDL/8AUcPa--