Date: Tue, 16 Feb 2021 10:00:17 +0900
From: Michael Paquier <michael@paquier.xyz>
To: ivan.salvato@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16866: pg_basebackup Windows Server 2016
Message-ID: <YCsZIX2A2Ilsvfnl@paquier.xyz>
References: <16866-623545dc62339188@postgresql.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="wXtCwG68CVlsb8fK"
Content-Disposition: inline
In-Reply-To: <16866-623545dc62339188@postgresql.org>
Precedence: bulk


--wXtCwG68CVlsb8fK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Feb 15, 2021 at 03:12:10PM +0000, PG Bug reporting form wrote:
> Problem:
> backup fails when the base.tar.gz achieve di 4 GB with pg_basebackup: error:
> could not stat file
> "W:\POSTGRES\pg_backup\Base-Backup_2021-02-05_103921/base.tar.gz": Unknown
> error.

This comes from the fact that Windows stat() is not able to handle
files larger than 4GB by design, and the fact that pg_basebackup tries
to make durable all the contents of a base backup when it is done
streaming something on the target host.  I bet that the failure you
are seeing is the fsync() part for base.tar.gz.

You can bypass that by using --no-sync as option, which would
basically emulate what Postgres <= 9.6 is doing.  In Postgres 14, the
emulation of stat() has been fixed to handle the case of files larger
than 4GB:
https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=bed90759fcbcd72d4d06969eebab81e47326f9a2

This is arguably a bugfix, so we may consider a backpatch in the
future, but knowing how invasive the fix is we are still in a phase
where we want to have some dust settle on this change and Windows has
its own way to do weird things all the time.  IMO, It may be better to
revisit that a couple of months after 14 is released so as there is
some feedback from the field with this change.
--
Michael

--wXtCwG68CVlsb8fK
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmArGSEACgkQnvQgOdby
QH0mmQ//Te+YlS1up1FpGnFHGH0/WY16MP2m4LeIuyEog1BMikUnMSxoLXCQzAxP
sqXbev9Zi5DIvlnml0DPdkvEEo79iBw/0CJ2jtqcNppMQpfx6iAgODi7CL47qLQ4
qpOhAbFhz2orh8H9TLyhoKhY+YMTCLO1Yes9bRGJ8i92NpWuZ9QmdMKQuruPL5J5
VvQuhAD9o5wqDIg8nvxTHZuILhbBufVmdhmPzqoUkTXqFs8Jdi70OPjBukJjtVdE
mEA+UpUB1LXgIG0hhzmD4Y4o8nfqr9DB4HhhZLbPaJOy7l6p3FcnB3MsegvMtlMV
DaRf1OBifHJC0NMYWtybxR9SKQ7ZtmIHHHTTAUgtYo6Rkq2/wiUZXSQCGNRZCMZv
8tP0EFLGmFd9KXMVsM7YbagSNbKyFAdhCXtng5oMa8hCS5nKeb6VDfjEW9AZOO5H
FRZKVU5gHzCikSVgUTasHAkuVxTAUtCdSAtiHqAfOIhQAbVWTpDa2zWHjFm4T8Iv
x6zpsM89l0+LT9oNUQmxd4Ea6amuK+FEyRL6vDwNYQSx8xTI8+D8jfSBew/HcaDV
juXwj6HgCM5fUuWHmGKRIuQ18iPAAw6tKr049pu1t56etQb0VlIl+AumvCNB784d
qfN/FmyhMFYz8GaswZ5wyCBE//CiCjhjzBI9bax69uBcexQuJUk=
=DFsY
-----END PGP SIGNATURE-----

--wXtCwG68CVlsb8fK--