pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
Two bugs in the RPM specs?
3+ messages / 2 participants
[nested] [flat]

* Two bugs in the RPM specs?
@ 2021-03-01 04:24  Michael Paquier <michael@paquier.xyz>
  0 siblings, 1 reply; 3+ messages in thread

From: Michael Paquier @ 2021-03-01 04:24 UTC (permalink / raw)
  To: Postgres bugs <pgsql-bugs@lists.postgresql.org>; +Cc: devrim@gunduz.org

Hi all,
(CC Devrim)

I was looking at the RPM specs that are published here:
https://git.postgresql.org/gitweb/?p=pgrpms.git;a=summary

And I have noticed two things that look incorrect to me in a couple of
spec files.  For example, take:
rpm/redhat/master/non-common/postgresql-14/main/postgresql-14.spec: 
1) The libs package lists libpgfeutils.a, but shouldn't this static
library be part of the devel package instead?
2) hstore_plperl and jsonb_plperl are part of the contrib package, but
shouldn't they be part of the plperl package?  My point is that this
is inconsistent with the transforms for PL/Python, where jsonb, ltree
and hstore are part of plpython3.

Thoughts?
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: Two bugs in the RPM specs?
@ 2021-03-02 23:18  Devrim Gündüz <devrim@gunduz.org>
  parent: Michael Paquier <michael@paquier.xyz>
  0 siblings, 1 reply; 3+ messages in thread

From: Devrim Gündüz @ 2021-03-02 23:18 UTC (permalink / raw)
  To: Michael Paquier <michael@paquier.xyz>; Postgres bugs <pgsql-bugs@lists.postgresql.org>


Hi Michael,

Thanks for checking the spec files:

On Mon, 2021-03-01 at 13:24 +0900, Michael Paquier wrote:
> I was looking at the RPM specs that are published here:
> https://git.postgresql.org/gitweb/?p=pgrpms.git;a=summary
> 
> And I have noticed two things that look incorrect to me in a couple
> of
> spec files.  For example, take:
> rpm/redhat/master/non-common/postgresql-14/main/postgresql-14.spec: 
> 1) The libs package lists libpgfeutils.a, but shouldn't this static
> library be part of the devel package instead?

Actually we should not package that file anyway (per guidelines).
Removed, thanks.

> 2) hstore_plperl and jsonb_plperl are part of the contrib package,
> but
> shouldn't they be part of the plperl package?  My point is that this
> is inconsistent with the transforms for PL/Python, where jsonb, ltree
> and hstore are part of plpython3.

This is also a packaging error. Moved all jsonb* stuff into -contrib
package, where it belongs. 

These will appear on PG 14+. I can backpatch the 1st one, but
definitely not the second one.

Thanks again.

Regards,
-- 
Devrim Gündüz
Open Source Solution Architect, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR

Attachments:

  signature.asc (application/pgp-signature, 832B) download

^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: Two bugs in the RPM specs?
@ 2021-03-03 00:47  Michael Paquier <michael@paquier.xyz>
  parent: Devrim Gündüz <devrim@gunduz.org>
  0 siblings, 0 replies; 3+ messages in thread

From: Michael Paquier @ 2021-03-03 00:47 UTC (permalink / raw)
  To: Devrim Gündüz <devrim@gunduz.org>; +Cc: Postgres bugs <pgsql-bugs@lists.postgresql.org>

On Tue, Mar 02, 2021 at 11:18:05PM +0000, Devrim Gündüz wrote:
> This is also a packaging error. Moved all jsonb* stuff into -contrib
> package, where it belongs. 

Just by curiosity, why this choice for jsonb?  Those transform
libraries have a dependency on plperl and plpython.  So, while for
ltree the location does not matter as both the contrib and the
corresponding PL packages need to be installed, why not putting the 
jsonb transforms into the PL packages?  One way or another is not a
big deal, of course, but a user could do a jsonb/pl{perl,python}
transform without the need to install the contrib package :)

> These will appear on PG 14+. I can backpatch the 1st one, but
> definitely not the second one.

Thanks!
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

^ permalink  raw  reply  [nested|flat] 3+ messages in thread


end of thread, other threads:[~2021-03-03 00:47 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-03-01 04:24 Two bugs in the RPM specs? Michael Paquier <michael@paquier.xyz>
2021-03-02 23:18 ` Devrim Gündüz <devrim@gunduz.org>
2021-03-03 00:47   ` Michael Paquier <michael@paquier.xyz>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox