Date: Wed, 17 Mar 2021 07:22:00 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Jelte Fennema <postgres@jeltef.nl>,
	duspensky@ya.ru, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16160: Minor memory leak in case of starting postgres
 server with SSL encryption
Message-ID: <YFEviJdl8bDTeutE@paquier.xyz>
References: <16160-18367e56e9a28264@postgresql.org>
 <20191213063915.GE1942@paquier.xyz>
 <20191214092456.GB70616@paquier.xyz>
 <CAGECzQTucR20CLwb6mw_JLdVST8GqYNqYr1OmAnNS2Byg8r+dg@mail.gmail.com>
 <3255514.1615912277@sss.pgh.pa.us>
 <CAGECzQQv-iQ=-EyouczH_s8M6oyT-ga6TwpY+RN9JZH-17bX7w@mail.gmail.com>
 <3345317.1615916184@sss.pgh.pa.us>
 <20210316181226.hj6jicxtqveokjyv@alap3.anarazel.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="By9SM4jxOqRDBYYi"
Content-Disposition: inline
In-Reply-To: <20210316181226.hj6jicxtqveokjyv@alap3.anarazel.de>
Archived-At: 
 <https://www.postgresql.org/message-id/YFEviJdl8bDTeutE%40paquier.xyz>
Precedence: bulk


--By9SM4jxOqRDBYYi
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Mar 16, 2021 at 11:12:26AM -0700, Andres Freund wrote:
> I wonder if it'd be worth starting to explicitly annotate all the places
> that do allocations and are fine with leaking them. E.g. by introducing
> malloc_permanently() or such. Right now it's hard to use valgrind et al
> to detect leaks because of all the false positives due to such "ok to
> leak" allocations.

Yeah, I have been annoyed by those false positives in the past.  It is
possible to know at quick glance what's wrong once you get used to it,
but anybody running valgrind would be right to be surprised, so having
a different code path for that sounds like a good idea.
--
Michael

--By9SM4jxOqRDBYYi
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmBRL4gACgkQnvQgOdby
QH2KUg/8CSOdJEp+XzZZjaARaQAE2djUF76a2tXZ01feX3553sQaXWskiIcVVVNX
OB0+Au9gP/a5Pn8iv6GEIjzyHPOQEyjhdubiHanlnp7sOBN55w4Y8FpPPc193FtD
nhXIzTwFyXce32mcEadQSktT6Fu0f917pfzc22RFwdokKj5akrPh7jmtMjEAP0e3
6sH3QFXPaoh8OZWh99pG5htn8ItQ5r7iOYEjBpM5aOFXQxTERsEswqp/DIce/BOb
+WzqUGCp78x2EytaUBhqiKt/pVj/7hrPOoDcSmWRDA275vtWkpC3Vh+/ZndogsZB
C1DJkwacAySEg6fPHD7SsfXYdsIp0dtA7OFZwFSFkztg9WETAi7on+z8bghCNqKm
Ys49sDIG5o3DM6G8XSBkCh3IacHmlCkyzbeGyPavTl9txhSUWJQmwJHMtj9yO7pt
dxP0nkaAvcCw7T/23l1xuzaEAleC11TOdiJecw0exNtR9B9o5vzbmfpOyWwEumpI
u/jtzBRROyEC4sXD4uod63X3urv+hgGxqKCauzOhTCVzTF1HDhqd89EI0Rbld8GS
CRANT3PeM3Pwt41V9mTLq6ZuI/6AeJs4D5YkSupFlvcz9Pw8cA9nO5psAz5hBjbp
vJlEaCPIcizY4TR7NpoV7Sy8TyRixb/eVY6CFHH4A/C2wTwq54s=
=021U
-----END PGP SIGNATURE-----

--By9SM4jxOqRDBYYi--