Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lNPjG-000449-Ft for pgsql-bugs@arkaria.postgresql.org; Sat, 20 Mar 2021 00:44:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lNPWY-0002cv-RS for pgsql-bugs@arkaria.postgresql.org; Sat, 20 Mar 2021 00:31:26 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lNPWY-0002cf-4y for pgsql-bugs@lists.postgresql.org; Sat, 20 Mar 2021 00:31:26 +0000 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lNPWV-0001Z0-MC for pgsql-bugs@lists.postgresql.org; Sat, 20 Mar 2021 00:31:25 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id A1B52B7A; Fri, 19 Mar 2021 20:31:13 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 19 Mar 2021 20:31:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=z/ekmLjPsExwBXmjObCtgPVqj5T XcdpvktP3V32QeUc=; b=qZLwU9tmtRdPt2ZM6QahOz0IMcpC7OoXbDrMZgcVtuk HD9eCavRYoFq0mAbGscPWzwIS1vzdHzYRlsGFiRRtwR8bg8F38413Q57a35Tz4Jp vTLZKo+QAxPPr+bY3rjRwwMbMX4p2qZunHiFHqlYllddrtgqJPntQOJeCT3zeZBg M8Yowcl5wiGziCSraKin5PNS7UxXW4Sp435jk9iOoENIz7E8YWcq7lslpaXyhPNO jWuQohsTrgF1I+11B59OSXJlcfs7XDwLb2cAEQT758+b4zjPESN/lNgifHh45H0L AJOpNDwekwl/cJi53gKsBPW0aEiFKJr50DNlpihwMXw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=z/ekmL jPsExwBXmjObCtgPVqj5TXcdpvktP3V32QeUc=; b=JvMxvBY4hxdBVEKMEqlwUX mNJpkw3OK6ldmrsOQnETiFUg2F6uu7a+b3Eh8yaYl23fS1JKTb3g/TJh3j6wsufs 8sXJcXtfuy9mpqHDYZNd0rfF/Ou3Tutm7iNWW4VenbnJ911I7LSSLCvTitShnGGL sd5iMA3PlXxc3yK3d3dSPLVniKafQ5WIaT967SmOifs4Hs8VI2H9Fx+J286OU7rj FK7UMvFfzeh08KI16ezDl4C2fUApptlgaIgKhwHAmUtjFdMhV2FTf/VwK9fLzMqI ioBpoKybh6qPRJy3MJlBw+Eo4LmIpBTsa3f2ne2mnfjfl6hmoqffQPGDwbsZxZUg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudefledghedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpedvgeduuefhtdeuleettdevjeeh heeiveeuieegleetgeeljeelieeuieehgeevhfenucfkphepudduuddruddtvddrudektd drudekheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhm pehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Received: from paquier.xyz (ee0822lan1.rev.em-net.ne.jp [111.102.180.185]) by mail.messagingengine.com (Postfix) with ESMTPA id 4AB9B108005C; Fri, 19 Mar 2021 20:31:11 -0400 (EDT) Date: Sat, 20 Mar 2021 09:31:07 +0900 From: Michael Paquier To: Andres Freund Cc: Magnus Hagander , Tom Lane , =?utf-8?B?0K/RgNC+0YHQu9Cw0LIg0J/QsNGI0LjQvdGB0LrQuNC5?= , Postgres bugs Subject: Re: BUG #16927: Postgres can`t access WAL files Message-ID: References: <4065519.1616166832@sss.pgh.pa.us> <20210319235645.pznzqhulpjluyco2@alap3.anarazel.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="G4Zx1fBCmngVQQmO" Content-Disposition: inline In-Reply-To: <20210319235645.pznzqhulpjluyco2@alap3.anarazel.de> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --G4Zx1fBCmngVQQmO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Mar 19, 2021 at 04:56:45PM -0700, Andres Freund wrote: > - I think there needs to be a reference to the problem, otherwise we'll > just redo this a couple years down the line > - I'd not add the XXX, because the whole idea of durable_rename_excl > seems wrong to me, and it might motivate people to come up with > patches... Fine by me to remove that :) What about replacing the XXX comment by a small note, say: "On Windows, using a hard link followed by an unlink() causes concurrency issues with code paths interacting with those files, a rename does not cause that." If you have a better idea, which I am sure you do, please feel free to send suggestions. -- Michael --G4Zx1fBCmngVQQmO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmBVQksACgkQnvQgOdby QH2VQw//fWG54JlOc2+wk2B3XcMVppgvVg2VWienufG6+/iZ9G7ydwGwv6eWxLKM nmR74+CVnyqgtcYxLrbi307ZSc8aoEhOOKXGFPGbqAqQCbb9xI9yigYFkHbXt1ir vXSAV46jcX3KSWblE65SVTTiGtA3868OGbG8ivDumazCIpknN8gKTT1URthdvOL0 xvvclIJfCiQJgvwtH6Oe0az2cJmtcG7kjqm2llo+kW/yYObiZ+8w3/OgtZs1MGAP Mttje/ezE+cA5G5SxJ07Nmk/FNVfppWkPbWyv9KVq5JFp4bg3dF5Zey+9r1nnj76 2nyf0f7q9S+KS3p8Tn9fZAnAAl1DQu+er8tQw3L9bzZRmk05v3aY+RPHifos34IQ UmCnNsrJr2bhuBPFh1GdRO2l1PZGpwx6ieWx2W55UW3sCeBnlJ9tn1v7pOoUEkHi h4W9hpIYnWi1MzdmEev7g2BZORegXaaHnz+CAYGKP1p+/FZlsks9bqL0WcYK1BzX FkpjxO3FVC9UW9Vy25tNYtO1ZL1cQm0ez8l+qqu9Jf2JHYfQwlMiSEcpF+bxlorT 4j+H8JzImLY/ZOpoLDbRWkxLwrTRMmlpPSnqR48DVot0VoUBw65WxpR/KsFqBzYN 1HJcCqV95pbrBGR+bqxF/gsXGmI15G5ImeHyeIAv++ZuqOtO65g= =S9V2 -----END PGP SIGNATURE----- --G4Zx1fBCmngVQQmO--