Date: Wed, 21 Apr 2021 19:44:58 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: leiyanliang@highgo.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16972: parameter parallel_leader_participation's category
 problem
Message-ID: <YIACKgzEThp6J81I@paquier.xyz>
References: <16972-42d4b0c15aa1d5f5@postgresql.org>
 <CALj2ACW_FkQqHb4zvq3WXvKZ2fWkiBKQs6KMr6LMeSi=AY8BvA@mail.gmail.com>
 <YH+R+HqLHDyrH1ng@paquier.xyz>
 <CALj2ACUr--FC3ac7LiZABtX6FaeLqfwbyi+2m629wSPYiZZX5Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="39DypHJnJ/eOVG5l"
Content-Disposition: inline
In-Reply-To: 
 <CALj2ACUr--FC3ac7LiZABtX6FaeLqfwbyi+2m629wSPYiZZX5Q@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/YIACKgzEThp6J81I%40paquier.xyz>
Precedence: bulk


--39DypHJnJ/eOVG5l
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Apr 21, 2021 at 09:15:23AM +0530, Bharath Rupireddy wrote:
> If we arrange only the "Asynchronous Behaviour" subsection in
> alphabetical order, I think the order may not be maintained in case of
> new GUCs that may get added there. Because all the other subsections
> are unordered and there's no note of maintaining the order as such.
> And, it looks like the relevant GUCs are grouped for better
> readability. For instance, all "parallelism", "io_concurrency", "jit_"
> related GUCs are together. Developers tend to add the new GUCs in
> relevant areas.

That's up to the committers adding them to be careful, but I of course
agree that the context is important.  IMV, we can do a slightly better
organization in "Asynchronous Behaviour".  First, backend_flush_after
is independent, and could just be first.

parallel_leader_participation can also be moved after
max_parallel_workers without impacting the readability nor impacting
the set of parallel-ish parameters grouped together.
--
Michael

--39DypHJnJ/eOVG5l
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmCAAioACgkQnvQgOdby
QH3WdQ/+KbjaapJ5FGYT14l31HoclxyZ50txACzsWS0GpFOAihl4JskR2+5Isrrr
uudni1OpuO1Y0Hdg9piPWZMeHQEh7HhU3vCjcmdObM6HvfEmc+rrFVjECYRVbZoM
QG1YjkVdb8BpuL3v0owbN80qMel5Xti/UTLjx9jlD0vJZwkbjbNWOsGjW4wHpfQc
onLwz7OrJAc6diUkGg/nV1yJBxuleVZoR9wqipt3sVIQDIoqScOrIUMJ2rVhOP3S
safnqhoKyuJFNGj/Q10Ubkkt+wHFiEnA7+Ks/PNxp8d4+oUpFxOoJfL3jUhyBFYZ
iNTtlcZtaveRP6Xe+8YKrgqXV97rCSmOIpvsnncYUN0YYW304UMvgqBttjCiRAIO
W4EJVXOY1XX/Q/wgbsW8xeOXh+1h0lQUsKL3P+foO1BP/oxGWdOqbsIITvBHXKnT
MRAhS9ut+kPjWpFVIZC4ZyvcY/x8X8fzrSna61+jq/IHnTOgxntR708fmKRLLYLV
Hm1GFN53J7J2tMGb26Zab0+1YAru8jOum8JWlbL2oUrG+C+YbwpoutB2bLq5MHol
93+94EHp4qiDKBt7iW4Ei9i7yLjeTKAv1lQ6bPAglaymvphTDkufFHtljUMwAy24
QBycFMzbxwDa8/nUyBiU6YRYcUUV8ujewtbRo0StoDGEYQYMYJY=
=XDon
-----END PGP SIGNATURE-----

--39DypHJnJ/eOVG5l--