Date: Sat, 12 Jun 2021 09:21:47 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Amit Langote <amitlangote09@gmail.com>, sbernikov@gmail.com,
	PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #17055: Logical replication worker crashes when applying
 update of row that dose not exist in target partiti
Message-ID: <YMP+Gx2S8meYYHW4@paquier.xyz>
References: <17055-9ba800ec8522668b@postgresql.org>
 <1828113.1623370641@sss.pgh.pa.us>
 <CA+HiwqG05LNWKv=fJDtF93LFmA99KCSZtnAJUAsjBOLFOPy-fA@mail.gmail.com>
 <YMMCFPuQwO6sEcJ+@paquier.xyz>
 <CA+HiwqF0xi2KmPYKPPCtcgQ2vnjQrfm5cdY50VRC+S_s1M4KvQ@mail.gmail.com>
 <1881335.1623423667@sss.pgh.pa.us>
 <2058966.1623442520@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="OBTBOkqWo7XHvPEn"
Content-Disposition: inline
In-Reply-To: <2058966.1623442520@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/YMP%2BGx2S8meYYHW4%40paquier.xyz>
Precedence: bulk


--OBTBOkqWo7XHvPEn
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jun 11, 2021 at 04:15:20PM -0400, Tom Lane wrote:
> Done now.  It was a highly worthwhile exercise, too, because I stumbled
> over two *other* bugs in this code while I was at it.
>=20
> BTW, I intentionally reworded the DEBUG messages to make sure we could
> tell the partitioned case apart from the non-partitioned one.

I have two comments about the TAP portion of ab55d74.

+$node_subscriber->append_conf('postgresql.conf', "log_min_messages =3D deb=
ug1");
+$node_subscriber->reload;
Wouldn't it be better to make sure that the change is effective before
moving on to the end of the test?

+my $logfile =3D slurp_file($node_subscriber->logfile());
+ok( $logfile =3D~
+     qr/logical replication did not find row to be updated in replication =
target relation "tab_full_pk"/,
+   'update target row is missing');
I think that it would be better here to grab the log location before
running the queries that will be matched with the logs, then pass down
the location to slurp_file().
--
Michael

--OBTBOkqWo7XHvPEn
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmDD/hsACgkQnvQgOdby
QH0zcQ//b06gj65jufAn7jRF486/AFx0SeHpt0VCqve1Bi8/Zu1xQB2qHsYmRej4
rb6o5IJxheapAvjoow4fv/u2QqyXoqy9hU3RAVXYjTrKCNnwar5vUB0dBz5l/tZx
lMmkwKy7tcGuDkU99b94/rwrWOfQlKfwZnsWgGcBTSb9Wan2FQYiJl1oZXDcM0n7
epabYnFoJTzzW3QhlKAeyiLbV8GFYnTF038ND8C2pKB+/gU7I0c1sYXA7eygGQMg
5PirBOvFOfm0c98mlUSxPxasz1skdxQFOrq32KlrQ2PwtwBLXC3iMznNC4cshO9I
S7sqZRHizK8wHYCZKxb9Eqpb48YO31hTwMlruTTXNQMnpVSMv4CLSSWBGj3KhS8T
4x0R5HweW0Nq/Vp1FGjoQAPrE07VREgYRAP0QgBBxeedv2rFO2Ilx/QAoNM5gFbm
uo34BdKcXt6likGdNR5Mhh573yEU//Deybm1MwO2Kb9bb+4c37AwR6OMedZcs8eZ
eirGhQ0I6QPPWEAib1f/U40U7BrHr/iB6Ug0uG75Y0DUSSm8Uz2FFgEM4/p8IKhJ
j5NTdNYd2dWfWDlC1oKfLEz5Vtnx9gPLl7+C4w/HFaNfvqgQV+XQLNDWhx6fI8vA
EVOnLXQeeeoJjmdfvuyhqcQLYZS49mIChlQ81/q+xf6MCzMOnjc=
=u/oY
-----END PGP SIGNATURE-----

--OBTBOkqWo7XHvPEn--