Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m1P2B-0004lY-VC for pgsql-bugs@arkaria.postgresql.org; Thu, 08 Jul 2021 08:05:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1m1P2A-0006C5-Tk for pgsql-bugs@arkaria.postgresql.org; Thu, 08 Jul 2021 08:05:22 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m1P2A-0006Bx-Mx for pgsql-bugs@lists.postgresql.org; Thu, 08 Jul 2021 08:05:22 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m1P25-0003zV-6L for pgsql-bugs@lists.postgresql.org; Thu, 08 Jul 2021 08:05:22 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id C368F5C0110; Thu, 8 Jul 2021 04:05:14 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 08 Jul 2021 04:05:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=I/ELg+I0B0sSdfk//UKP9T4c2nI cUYgDNOLyVUrrO4c=; b=Kzgn+xCRRVKL2TlpUSHQt6PZq/0uZhwRaDcIoiTqyRF 8SR2a7bfJntVnBLKnYog/ZO6KCVRyuKhvEyGuIHf28LxUGSuxCjVKM0fMbDJzoFb B5KwbAARMJBkehS47ktSX/E5ioDLZ00dqXv9yDLmKWSEnbJLxs6d4KwpAjuyeNBv 1PTbxK1maJYsi+B3pQmA9nGW1BBjhepTVNCwXxALGWkOSQLKY/7aDq8orhGwvw2F iEcOBuXHc8JVdLrjLEheZppqIG6u7gFn/okn9ZB0Ncwq6qSVJJLxXXkyV9Z4D5e+ k8lm/4ZjQcs193+blVol8KuodC7MCNAZ3WanwXGxBdQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=I/ELg+ I0B0sSdfk//UKP9T4c2nIcUYgDNOLyVUrrO4c=; b=Kw3pe4rL9bCbBlYyYE6pok UVHw4rJDNIBOBot7pDgZIqPiSypvzEcMpvvVNHavBCYhmkbDnVU8YhSJfUA1B6Ry 5qOOiyO53oDHQm8RJ7vhIlOOjQ/PoiZlj7XaPH/pCFv5qIv3STd6m43bVPCUHnzL FK0ewh8VOzF1qEWh6Ous7++kkii7tuAmjXtRBqiNuI1zXZxuWmZlEAkaDeRL0NqJ +OhYoRCAVyG0kec1zBfY6CUcjOQR0ISBWCM9HtAve4HVI+J+VXz8RpNC94PeuJcc /BpKDpUvea07unQiMLRPfKJDnbGOPnatOPVVdBfkLv3IYFEc63urNo8Jn6WtPTig == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrtdefgdduudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpedvgeduuefhtdeuleettdevjeeh heeiveeuieegleetgeeljeelieeuieehgeevhfenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 8 Jul 2021 04:05:12 -0400 (EDT) Date: Thu, 8 Jul 2021 17:04:54 +0900 From: Michael Paquier To: Daniel Gustafsson Cc: Tom Lane , Adrian Ho , pgsql-bugs@lists.postgresql.org Subject: Re: BUG #17083: [PATCH] PostgreSQL fails to build with OpenLDAP 2.5.x Message-ID: References: <17083-a19190d9591946a7@postgresql.org> <1666182.1625579201@sss.pgh.pa.us> <1677203.1625582865@sss.pgh.pa.us> <1860066.1625677051@sss.pgh.pa.us> <68D22062-EC78-47C5-BC46-EF2F77193E19@yesql.se> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4P8D+sRlNvYlH5NM" Content-Disposition: inline In-Reply-To: <68D22062-EC78-47C5-BC46-EF2F77193E19@yesql.se> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --4P8D+sRlNvYlH5NM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jul 08, 2021 at 09:53:11AM +0200, Daniel Gustafsson wrote: > Couldn't we add a version check to find if we have < 2.5 or >= 2.5, and adjust > libs accordingly? Alternatively we could perhaps check for > LDAP_API_FEATURE_X_OPENLDAP_REENTRANT which IIUC when set defines -lldap to be > reentrant. Would you fetch the version number directly from the library? I'd like to think that it could be more simple to rely on an object defined in the library instead as that's what we do for OpenSSL. Now OpenLDAP has not a history with forks as complicated as OpenSSL, making a version number something more reliable? -- Michael --4P8D+sRlNvYlH5NM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmDmsaYACgkQnvQgOdby QH0M+A/+KSttJER4Vb7L5juLLBRop3T7IGRZwIdtUZVkUW6qj/cTjvqrHCHSGT1O /SyPOwfT3xEW6eDceMiyOaK9jvly4J15Bqj71i588WBWEOeMBE3ojPBJcBfF7eEa V2yGRUgJIfiuvUBaCdCWlMw7Sz0E2cIXSN+lpamXzOBqDmWQ59dWSce34HSAEJ7s N0lH68scIJ4D7T/exjLetdzgHb9a0XU+iNTfedxKim/TCAIzCFgMimbg4y7ng59z e/YkOHpZVuIGDZogIJVZoZc21QWJ4KnnionzFXY6GYvGnBF0YvojzgalfulNNgEo 9tgMDR41n00BS8VBupKLGmOq6nuCwhtrhSN/bggizyVSR8JZYj3SzZOpkQWcH1+1 Z7XIHGrAYx7Ss0oG6HCNY6AFxpB/w5DD7ewNbU7aK5uA6UZjxyHWuhy0tkYCmrXx WVexBtf0rsaCffFz+Lvzjc3WFtuXwN+Fr6bXdPJrSNBm3XP8kFqIF3zmlW4v/GYn BrXVvLmOPgJpsGcmTv4+m+BEMhOJ3ZOxhlbvn1VQXqQ1trB+8bLOkyvSWE5asRp8 d4C7Mc86vwPBYQ03K4zhpaHxSZMaEIMyVP9oLwm9OES0bISORymYPcRFKI6tu7Bg vjoFu2/x3eIiZB43UE4oT3aw7olm+G69DgTCaS56mUeVAyrFyQI= =M2uQ -----END PGP SIGNATURE----- --4P8D+sRlNvYlH5NM--