Date: Thu, 11 Nov 2021 11:52:27 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: a.kozhemyakin@postgrespro.ru, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17280: global-buffer-overflow on select from pg_stat_slru
Message-ID: <YYyFawH87Sv3VZGi@paquier.xyz>
References: <17280-37da556e86032070@postgresql.org>
 <20211111.103923.2138998724021170559.horikyota.ntt@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="rl8kW6/5mVYI+il7"
Content-Disposition: inline
In-Reply-To: <20211111.103923.2138998724021170559.horikyota.ntt@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/YYyFawH87Sv3VZGi%40paquier.xyz>
Precedence: bulk


--rl8kW6/5mVYI+il7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Nov 11, 2021 at 10:39:23AM +0900, Kyotaro Horiguchi wrote:
> The loop is designed not to directly rely on SRLU_NUM_ELEMENTS so if
> we honor that design, we would take the first or the third way. The
> first way is smallest but I prefer the third way as it is
> straightforward as such kind of loops.  The attached is that for the
> master.
>=20
> The code was introduced at 13 and the attached applies to the versions
> back to 13.

Or it would be easier for the reader to assign stat after checking for
the result of pgstat_slru_name(), no?  I am not much a fan of this
code style that uses a counter, FWIW, but at the same time
SLRU_NUM_ELEMENTS is local to pgstat.c, so..
--
Michael

--rl8kW6/5mVYI+il7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmGMhWoACgkQnvQgOdby
QH3JCxAAn7VE8p1jcdXfAlN10UcIySn6dcF9MSlb6MbsCp6D2SLevfafZ+OnXDUx
A6XGaDGwFZdqd9jv4ixyvJQJhY7rWVGkztuWwgpBbX0rZqDPaLC0bOHERaSgNzPW
SpVbup2dlOh1q+p0tDolwi3JlFUjNarbsGQCWoSFzU5norTdKHtf95OyUBYrAviq
UDz5339siuWWHoKhvR+Q0LyVz9iFlYafqs73sjIwJfVlVHAUf44JSU17gN/x1CHI
B7kY5tyU9Eqj7OGi+EUY+RCWjGEzNwTTg0WFNUfZSJyWk2fbl55zoOUw7+Uy6ENX
QXgwAq/M/RhCA5oxrIqYiw1DFXLCfQYQ+lb9jPGI0TEjPcU8sqmKzWZ95GpCHXb1
ENoc07jXbk1iIwWhB2I4J3Nch+O7qB1N/eWcjIzkqs+zdrkPllGETrCAA+kgI/qq
Aj2X9xLpal23fI4DI7vw+jX6c2W7amL8Lw6UgrOGDVhQYHMDYgcjrNloOi3FCs0u
MXv5bsegwml1QFeFJBM10KSmcMz7ST+tbFzJ2UI9RDo3RSNghp2pDZTeYS95b89t
GyXBD2Mjh9hETD93VKSXVMIxzHvNdy4c48hnc95VEHkU6pI0B8MkVoT762nrztMv
g7gVsZ8gRCQxYzounCw4ug9fCQ6fCoaJinJl1FBnG9VRmFp8yKU=
=apTt
-----END PGP SIGNATURE-----

--rl8kW6/5mVYI+il7--