Date: Thu, 11 Nov 2021 17:08:34 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: a.kozhemyakin@postgrespro.ru, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17280: global-buffer-overflow on select from pg_stat_slru
Message-ID: <YYzPgnGBCi75zOWy@paquier.xyz>
References: <17280-37da556e86032070@postgresql.org>
 <20211111.103923.2138998724021170559.horikyota.ntt@gmail.com>
 <YYyFawH87Sv3VZGi@paquier.xyz>
 <20211111.121909.1128935906296628969.horikyota.ntt@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="C3gyjxWXq0iJ9JOC"
Content-Disposition: inline
In-Reply-To: <20211111.121909.1128935906296628969.horikyota.ntt@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/YYzPgnGBCi75zOWy%40paquier.xyz>
Precedence: bulk


--C3gyjxWXq0iJ9JOC
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Nov 11, 2021 at 12:19:09PM +0900, Kyotaro Horiguchi wrote:
> I'm not sure which is easier to read, but it might be a bit hard since
> the conditino term in not mention counter itself. I don't object to
> that way.  And, yes SLRU_NUM_ELEMENTS cannot be used here:p
>=20
> The attached is the first way in the choices.

That looks fine.

Also, what do you think about adding a test in sysviews.sql? This
could be as simple as that:
SELECT count(*) > 0 AS ok FROM pg_stat_slru;

I am not sure if the buildfarm animals running valgrind would have
caught this issue, but having something would be better than nothing
for this case.
--
Michael

--C3gyjxWXq0iJ9JOC
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmGMz4IACgkQnvQgOdby
QH0sJQ//UxpjMIyUcRjtG863q1xnatynJJ+oSks/TjajnK1G3x+cV1PGDDQlZ8Z1
10oH0grvlWgKPsws8wiZfiXUDB6m771Fxpin8YmSUfNhSiwKHiKELWaWB4sJ1rE9
G0bOs2XMCGmbVC4LM7n+gieJyD/qwYCgTLrO6RTfOfcB+Brmh5TXHxolvs+O7gK/
GorezX6lp9j/aPXagpeRU6wDkgkuupmuraOEcjVNvm3jSxz6GkzMHq71sr/ow/0T
RlNGIOQVXLLINkGR+KwFahzPOGk/xE0zcHNhXOHoAma+732DMxfIML+JQqEco1jG
2imdRPDNu+qE8ho7O3Zkzn/zzW9Ck8fkaNYTJwUlVXXG4dZch27UpQERlGUqCt0q
01tCUyW+XmiQVwj1iCFkm3bOKjxQZfFGcdvrgJ/6aHat2H+W00+86yfigR9dpEhk
AmBDeoWM+SzAIxU3sUVmSuRpxVRo29sxNeA9jXkgs6GmJ3e5AlltBrA8jjK2hcX+
v4DxOqFAV/iESfITtj+41ni2xfQfg+OytfQ6ZOGMYOq9Bcw3XSjFWPlikMCap31C
Vl3L+Noos1/CMDA5ClXXsCoaaa+Y9MOsPEZDWGnSB8kNA12zvT9jNdQ33lUSQE1N
NUrz931doAtduuaYJ0p5x9pDinj1EVSTl4D6Q9lY5sKGig3r2Ng=
=U+8Z
-----END PGP SIGNATURE-----

--C3gyjxWXq0iJ9JOC--