Date: Thu, 11 Nov 2021 18:09:49 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Noah Misch <noah@leadboat.com>
Cc: Andres Freund <andres@anarazel.de>,
	Alexey Ermakov <alexey.ermakov@dataegret.com>,
	Robert Haas <robertmhaas@gmail.com>,
	Maxim Boguk <maxim.boguk@gmail.com>,
	PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>,
	Peter Geoghegan <pg@bowt.ie>
Subject: Re: BUG #17268: Possible corruption in toast index after reindex
 index concurrently
Message-ID: <YYzd3dsYi/LiwWuc@paquier.xyz>
References: <20211108183646.r3y6pldylxngxwl4@alap3.anarazel.de>
 <20211108185317.fz42txmnkqdkpix6@alap3.anarazel.de>
 <20211108203641.whpia3pzjofellf4@alap3.anarazel.de>
 <20211109035624.GA940092@rfd.leadboat.com>
 <B706E617-2172-4460-845A-B76E5DB2E0A2@anarazel.de>
 <YYoA24hSkx6EYWpx@paquier.xyz>
 <20211109050848.oe3u6mhtomkaoxrx@alap3.anarazel.de>
 <20211109054625.GB940092@rfd.leadboat.com>
 <20211109063119.ukcvdk7uvz7ks3pa@alap3.anarazel.de>
 <20211109064217.GC940092@rfd.leadboat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="X0cj1khhPiSlTbg5"
Content-Disposition: inline
In-Reply-To: <20211109064217.GC940092@rfd.leadboat.com>
Archived-At: 
 <https://www.postgresql.org/message-id/YYzd3dsYi/LiwWuc%40paquier.xyz>
Precedence: bulk


--X0cj1khhPiSlTbg5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Nov 08, 2021 at 10:42:17PM -0800, Noah Misch wrote:
> On Mon, Nov 08, 2021 at 10:31:19PM -0800, Andres Freund wrote:
>> On 2021-11-08 21:46:25 -0800, Noah Misch wrote:
>>> Doing both sounds harmless.  Regarding REINDEX CONCURRENTLY on a system
>>> catalog, I bet that can still reach bugs even if we do both, considerin=
g this:
>>=20
>> Normal catalog aren't REINDEX CONCURRENTLY. It's just toast tables that =
are
>> kind of system-y, but also kind of not, that can be reindexed concurrent=
ly.
>=20
> Oh, okay.

To be clear on this point, users cannot reindex concurrently catalog
indexes and toast indexes associated to catalog tables, just toast
indexes of normal tables.  I don't know if any of you have been
working on a patch, but I was cooking something.  It would be worth
checking if an isolation test could be written.
--
Michael

--X0cj1khhPiSlTbg5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmGM3d0ACgkQnvQgOdby
QH1/qw/+OCMztP5vK/ePaEmiAnS0y3qvsMIfvTb7vnzb13gDACw3lErr8r043aHL
lJ7r/ThMflgpml3WHwfR1hOnkLgy63/+SKmj9A4N47/KlDHVDtcIF5okKPBDFOSJ
1jIGegCX8mARP7mpMRl6bK8PSdeYDELRIAqE30ZNCCdkPtaRyxjGyUym/xRFRb1E
GvtuTkv+11BTCtyOpSLYIo29LqEruspIg4yLn+owUYmCv+ctUzl1c09GHA/8HVaV
2ZziduBseL4KQ9idsQegojPqYOqlwTcSVyi5TASissAIWNstNK00xf+AoboAJJ7e
Rc8UGzjDSCz2uxxL5GWyQfNt8HCR2ED4tf86yy6TzDlVYTayaYlnJ0U6aCNxO5JZ
KUKU297tDxxmwQzMEkPmkxOfeMo3Rg2csutgUPDEhr2mjI1QW/WrkixG2oAytxRN
+aaxmWo+30sE2pSEipvkvl6HXZV84LezGBm50AN5/S/zQDPKZE6o16nTS2emQffD
Nk2obq0dZ3PZHGxiV1o0ewa5QUcsgKHEM7GzIlyOgonjaFOMjhdF7GgA2jgXc6F1
Yzq47QeIzKuanb5zATMAos5LWOTqtYYohBgY5CAw1bj5vRgNiRA2Qy14hMrYnkIl
9z/E69BwSODnR8dnPeg3wLj5R0TKrRhTuOcnad8gvYUnAByVnX8=
=CBGQ
-----END PGP SIGNATURE-----

--X0cj1khhPiSlTbg5--