Date: Sun, 28 Nov 2021 13:15:36 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Juan =?iso-8859-1?Q?Jos=E9_Santamar=EDa?= Flecha
 <juanjo.santamaria@gmail.com>
Cc: Dmitry Koval <d.koval@postgrespro.ru>,
	PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #17288: PSQL bug with COPY command (Windows)
Message-ID: <YaMCaDC7koHSrmzv@paquier.xyz>
References: <9caa0612-19e5-f860-4b97-908a1c721233@postgrespro.ru>
 <CAC+AXB1FTZueNdvT1F4fpr4z9gxpcKkgWa-Awor9XC9PAKLVSA@mail.gmail.com>
 <YZiGIxk5F3TT/OJc@paquier.xyz>
 <ff540eb5-3493-cf02-6c22-20ef6e15fee9@postgrespro.ru>
 <CAC+AXB2GfM3NGjx7vc+=UvbD_bzQheiPqk2BQiFRn7G0oVUDhA@mail.gmail.com>
 <c97531c7-a439-78b5-33e6-6aab5a900949@postgrespro.ru>
 <YZ3Cm7PKGesAitYN@paquier.xyz>
 <b108ffee-53b7-f11d-4110-1c2a72fa63b2@postgrespro.ru>
 <YZ8BvVysOLJcTP16@paquier.xyz>
 <CAC+AXB346f7MWjW3HDpN8ATBKrUzcQEZDRzzpryziN-+Y3gNNQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="/Uxo8NJxHCR5f6HF"
Content-Disposition: inline
In-Reply-To: 
 <CAC+AXB346f7MWjW3HDpN8ATBKrUzcQEZDRzzpryziN-+Y3gNNQ@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/YaMCaDC7koHSrmzv%40paquier.xyz>
Precedence: bulk


--/Uxo8NJxHCR5f6HF
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Nov 26, 2021 at 01:37:49PM +0100, Juan Jos=E9 Santamar=EDa Flecha w=
rote:
> through a tap test using console input. Looking at the patch I'm not sure
> it is worth all the extra code, but I'm submitting it for future reference
> at least.

+       eval {
+               $result =3D IPC::Run::run [ 'psql', '-p', $port, '-c',
"\\copy public.test from stdin", 'postgres' ],
+                       IPC::Run::timeout( 1, name =3D> "stall timeout" );
Using directly psql commands in the tests is not a good idea as it
makes the client-side execution more sensitive to the environment.
src/test/perl/PostgreSQL/Test/Cluster.pm does the same work, in the
wanted way, so it would be better to rely on it (see 384f1ab for one
recent issue).  A test with a minimal timeout also takes time, making
for slower tests on faster machines.

Hmm.  Do you think that a test based on Cluster::psql and stdout would
actually be able to do the work or would the redirection done in the
INIT block of Utils.pm prevent that?  Contrary to the code path of
pg_recvlogical, Cluster::psql would use directly IPC::Run, and not
redirect stdout to the test log file.

I would stick a test in one of the existing test suites, to not create
an extra cluster and reduce its run time.
--
Michael

--/Uxo8NJxHCR5f6HF
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmGjAmgACgkQnvQgOdby
QH3OzA/9EXsS0IZAszR5N4Qjv0JGBcSJMfJEavEzigPQrbmHS7LODo/lHEiy4pyr
ZRRd7jnGnY+1id9lRWr01WPfGRLq50xJszZToQRjHCERu8nJaeHd0QXstdvQdKgU
VjkDENCOmIfkk1QmXQXh7d1XdqhrFLd7+sUWWfMQYGB4drOJMm6FQuJAv3Am1sHQ
OrUiDkEMig3K2F9BSgn1gTW+XtDZjO0L3VaymRU33C+JQHX69qaBgkLAMT+eK8Uc
69HJlsu+tf4lZKUSR4l6zOm3vdKkt44Q1JxW6/PspslQHv2WZQ6J9DxXroMnRNdk
jGmI/qKIQJf8Cps+8jTiZXTwVg3su0PghJsbhRAMEjoii7VjhZURX1SPLGcXxQX9
xKNPxF3vAM0iNUkvIAiyX2iTWg1CTI5qc1iSxaySxZWCXDcX4+vcbMqm6JEI7b0D
4ulnon5l/tsKMjroLQg83QD1VL8vxVc2PpfavODbHpWozsInDE67NnmXqZalyI8K
l2s9ivd1dbByyYIPf/Zb2PWm+rumFcTtp3HMKLAKUAhYdUDOlCR28X3YFfKYYXsQ
e5uPMBk9kNLE30r8cvDeTRUwLRhFPyTxktEJScERLINO4BDjbTZy4vg+wwzH7zmD
vg2bzhH2Gpy+HQc2WtZnAkdpTbnQwXsISPWElfP/ybHuVJPL/gE=
=D9lP
-----END PGP SIGNATURE-----

--/Uxo8NJxHCR5f6HF--