Date: Mon, 29 Nov 2021 15:51:39 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Dmitry Koval <d.koval@postgrespro.ru>,
	Juan =?iso-8859-1?Q?Jos=E9_Santamar=EDa?= Flecha
 <juanjo.santamaria@gmail.com>,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17288: PSQL bug with COPY command (Windows)
Message-ID: <YaR4e1Pj6wAt+fPT@paquier.xyz>
References: <9caa0612-19e5-f860-4b97-908a1c721233@postgrespro.ru>
 <CAC+AXB1FTZueNdvT1F4fpr4z9gxpcKkgWa-Awor9XC9PAKLVSA@mail.gmail.com>
 <YZiGIxk5F3TT/OJc@paquier.xyz>
 <ff540eb5-3493-cf02-6c22-20ef6e15fee9@postgrespro.ru>
 <CAC+AXB2GfM3NGjx7vc+=UvbD_bzQheiPqk2BQiFRn7G0oVUDhA@mail.gmail.com>
 <c97531c7-a439-78b5-33e6-6aab5a900949@postgrespro.ru>
 <YZ3Cm7PKGesAitYN@paquier.xyz>
 <b108ffee-53b7-f11d-4110-1c2a72fa63b2@postgrespro.ru>
 <YZ8BvVysOLJcTP16@paquier.xyz>
 <20211129050122.GK17618@telsasoft.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="5iOpFmj4qamd0NC7"
Content-Disposition: inline
In-Reply-To: <20211129050122.GK17618@telsasoft.com>
Archived-At: 
 <https://www.postgresql.org/message-id/YaR4e1Pj6wAt%2BfPT%40paquier.xyz>
Precedence: bulk


--5iOpFmj4qamd0NC7
Content-Type: multipart/mixed; boundary="239V1l8xfBB9HhFi"
Content-Disposition: inline


--239V1l8xfBB9HhFi
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Nov 28, 2021 at 11:01:22PM -0600, Justin Pryzby wrote:
> Do you know this causes a new warning ?

No, I did not know that.

> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Djacana&dt=3D202=
1-11-29%2004%3A00%3A29
>=20
> Nov 28 23:06:41 c:/mingw/msys/1.0/home/pgrunner/bf/root/HEAD/pgsql.build/=
=2E./pgsql/src/port/win32stat.c:309:3: warning: implicit declaration of fun=
ction 'GetFinalPathNameByHandleA'; did you mean 'GetFullPathNameA'? [-Wimpl=
icit-function-declaration]
> ...

Hmm.  Looking at MinGW, mingw-w64-headers/include/fileapi.h includes
GetFinalPathNameByHandleA() as long as _WIN32_WINNT >=3D 0x0600, so this
stuff is not going to work when we are under an older _WIN32_WINNT as
it seems to be the case here.  I have missed that.

We know that GetFileInformationByHandle() would be able to work in
the scope of win32stat.c as it is supported down to Windows XP so we
would be covered, so switching to that instead of
GetFinalPathNameByHandleA() would take care of the problem.  Better to
call that only for a standard stream, only for the emulation of
fstat(), in the spirit of the original fix.
--
Michael

--239V1l8xfBB9HhFi
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="mingw-fstat-fix.patch"
Content-Transfer-Encoding: quoted-printable

diff --git a/src/port/win32stat.c b/src/port/win32stat.c
index 3956fac060..426e01f0ef 100644
--- a/src/port/win32stat.c
+++ b/src/port/win32stat.c
@@ -289,7 +289,7 @@ int
 _pgfstat64(int fileno, struct stat *buf)
 {
 	HANDLE		hFile =3D (HANDLE) _get_osfhandle(fileno);
-	char		path[MAX_PATH];
+	BY_HANDLE_FILE_INFORMATION fiData;
=20
 	if (hFile =3D=3D INVALID_HANDLE_VALUE || buf =3D=3D NULL)
 	{
@@ -306,7 +306,7 @@ _pgfstat64(int fileno, struct stat *buf)
 	if ((fileno =3D=3D _fileno(stdin) ||
 		 fileno =3D=3D _fileno(stdout) ||
 		 fileno =3D=3D _fileno(stderr)) &&
-		GetFinalPathNameByHandleA(hFile, path, MAX_PATH, VOLUME_NAME_NT) =3D=3D =
0)
+		!GetFileInformationByHandle(hFile, &fiData))
 	{
 		memset(buf, 0, sizeof(*buf));
 		buf->st_mode =3D _S_IFCHR;

--239V1l8xfBB9HhFi--

--5iOpFmj4qamd0NC7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmGkeHsACgkQnvQgOdby
QH2fLw//b6P5pLK5L1emRQZoGwmDw8Yc/K3MLpBUdmu5htYdsWJjL6jDTYCW+mRQ
uvA4ziqzjxebY6Y8AFbSM38xh5e7+XDI3lqdCQPCqEiweQpE5rCv50Ir4+idZmEK
ZmxnAfbcnbQaXnSLmK/GKDJ40SzLiugiEecoHXaLksP1zV5JLSIcWO9qKZbwH9oz
x9+mgwHEFZQ1oUnI2NT84sWqTtUi1WPUG4sD4SHPkcf0j644pIvsdvlMi5GjbWov
sYVJZpJPuhnzU51X249w4CMLfsAjOy6qryGdeZtHUmtUmb0ePb2/HBxMJhsvozj3
GzDNuUQKR6Em1g+9B4m5hmiHbz6mbA0Hs3rYuMVKBp4LleDKQqlyYep88ryOJxEx
auda0NFl3TwSOS5DpWNox/r2Ce8PIZiQu86fkA7J3p6uceBiQIFskulNZZn8AUuT
lS5doCv6le+EQA7yFrCqDjbHp9KuXdGcLOAmuv6E9rd1ytBj28/qmdVprX0gijOF
elHy3yShelxZjVnwDEHY6G2k+CvM1oins2bw2PD1YLs6Idkr1Mmpzq4ncxsQtx5e
8VQ0S5RNa4hen9iVqB3dYxuwtx94g41ehfYWN+hHgxpwEKrMwZjdA6EbJYbTG5VV
rtRnM7d+vYGfOo7sFwAiYIp71xkq8Unq7GNAp3qYLrAcZZReVbo=
=TJQ4
-----END PGP SIGNATURE-----

--5iOpFmj4qamd0NC7--