Date: Wed, 15 Dec 2021 10:33:40 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: "James Pang (chaolpan)" <chaolpan@cisco.com>,
	"pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #17326: Postgres crashed when pg_reload_conf()  with ssl
 certificate parameters
Message-ID: <YblF9NopbGHQ65/G@paquier.xyz>
References: <17326-d40bbb1386b6c9c3@postgresql.org>
 <PH0PR11MB51915EF4E577B83F664F9AD8D66F9@PH0PR11MB5191.namprd11.prod.outlook.com>
 <20211208134601.gauysdttc65aoeze@localhost>
 <PH0PR11MB5191DFBF6685E3EF9632EAF0D6709@PH0PR11MB5191.namprd11.prod.outlook.com>
 <PH0PR11MB5191F4B6C7B80F2DC2BC5F89D6719@PH0PR11MB5191.namprd11.prod.outlook.com>
 <20211210142231.fvldmwwy4fr477h2@localhost>
 <PH0PR11MB51910828B552926204514891D6749@PH0PR11MB5191.namprd11.prod.outlook.com>
 <YbcqQXfYRhzCgud2@paquier.xyz>
 <20211214154604.cfmv4kpo2inkt2pp@localhost>
 <20211214173654.i54n54e7v73dvflj@localhost>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="dGGFG+VaPcNxpLDE"
Content-Disposition: inline
In-Reply-To: <20211214173654.i54n54e7v73dvflj@localhost>
Archived-At: 
 <https://www.postgresql.org/message-id/YblF9NopbGHQ65/G%40paquier.xyz>
Precedence: bulk


--dGGFG+VaPcNxpLDE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Dec 14, 2021 at 06:36:54PM +0100, Dmitry Dolgov wrote:
> something weird happens after set_extra_field, and after this point ssl
> context memory seems to be corrupted. Right before that an assign_hook
> from set_user is invoked to do something around "deprecated" options,
> that's why it looks suspicious. As soon as no "deprecated" options left
> in the config the issue disappears.

Hmm, okay.  Thanks.  I have no idea if this extension is doing
something it should not, but I'd like to keep in mind that there could
be something that could be improved in core depending on what this
module is trying to achieve.  At least that's a possibility.
--
Michael

--dGGFG+VaPcNxpLDE
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmG5RfMACgkQnvQgOdby
QH0V+A//eC7Slz/KARoSMFqesWsnghCTZg90ldNIuDJRkUG+QtGOhzilZzVW9WKp
0TriSKBsz4lWUWH6BkvyNnb0YHMYubdm3yZOs4Lx6tVD3wpvyjDn3E4zwqZkFwpF
MeZGg6xrvOkqhmPF97nyEo+I24OtGPv4H0WsdXRs9J81HmlYm6awmLLtWL8lL7Fh
2FEbJ880nSgBgQ5v5itvXbJgy61uzMCQ15RURqCIewiXNRamQ/dqOiPnsspjgLLZ
/NZZynMytKC3YrUQtQso/mqD63Dl4hJAh3i959V8bqOw8tmGbz+fDoMRk2lDbw+T
JT3Zo3R5h9EByVfArjlIoYnhigSQLPLOI5EIQySRSMwdP4tfr8ocmPo8Rk/RtPkO
JwDToBcG+r99rrLMHA0cu84VIheLBkTmGsP4LB4+n1y8cm4ZK3+BSq+74dP4Hq/3
h6M3KeTjyjpbvK03vG7P8OfmkVkGx7u1z1kYUbCYxpoJ2cY0/kQuNY/PtB1k15b1
r2Vnkxl0QHWAR3ud7lTo5cFuMOCrfZOIjz71Tm1FWF0KpvsAbkUJ1QJno5NWGkPt
R6cs66YG8DhyoZv7SbhUiKWuVmK/ozBlgbLulSTv1Oj4tipz8/yJxmLgSrpDjVnY
3rZHpiNnvSURErC3Ysi0Q1bszx6aYqUF/5mbVZEvP0li5bjJC/o=
=RT+T
-----END PGP SIGNATURE-----

--dGGFG+VaPcNxpLDE--