Date: Thu, 26 May 2022 10:40:03 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Peter Geoghegan <pg@bowt.ie>, Robert Haas <robertmhaas@gmail.com>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Andres Freund <andres@anarazel.de>,
	Andrey Borodin <x4mmm@yandex-team.ru>,
	=?utf-8?B?0J/QtdGC0YrRgCDQodC70LDQstC+0LI=?= <pet.slavov@gmail.com>,
	PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #17485: Records missing from Primary Key index when doing
 REINDEX INDEX CONCURRENTLY
Message-ID: <Yo+RQ2wSZIP/ljtt@momjian.us>
References: 
 <CA+TgmoYP7BnHXTEoJRUnOuie2J05Qo8ti5mnE2u-1c4Hk+8zJw@mail.gmail.com>
 <202205251643.2py5jjpaw7wy@alvherre.pgsql>
 <CA+TgmobNBHAObYS1yeX6C+Ph3ccborF86t9XFERdvtmmu-5DMg@mail.gmail.com>
 <CAH2-Wz=cDCzrfwm8YYF4vd8oMNJtVRh+_BbCqhCrKzX1NgXzQw@mail.gmail.com>
 <Yo7xTUr3eNgxuBq4@momjian.us>
 <Yo72aOILTPjBldWU@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Yo72aOILTPjBldWU@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/Yo%2BRQ2wSZIP/ljtt%40momjian.us>
Precedence: bulk

On Thu, May 26, 2022 at 12:39:20PM +0900, Michael Paquier wrote:
> On Wed, May 25, 2022 at 11:17:33PM -0400, Bruce Momjian wrote:
> > *  Caused by CREATE/REINDEX CONCURRENTLY
> 
> Yes.
> 
> > *  No way to detect which indexes were created concurrently
> > *  amcheck will be required to find corrupt indexes (options?)
> 
> amcheck would help for btree, not the other AMs.  I am not sure but
> there could be other symptoms that may not be detected by amcheck?
> 
> > *  Heap is fine, only index is corrupt
> 
> Yes.
> 
> > *  Bug since PG 14
> 
> 14.0, yes.
> 
> > *  Not known why reports are only appearing now
> > *  Feature will likely need to be removed rather than fixed
> 
> Trends go in this direction.  It does not seem like there is a
> complete conclusion on this point, either.

Uh, if people don't know if they have used CREATE/REINDEX CONCURRENTLY
in PG 14.0+, they are going to need to run amcheck on all btree indexes
and reindex all non-btree indexes?  That is going to be a painful
message to deliver, and hear.  :-(

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Indecision is a decision.  Inaction is an action.  Mark Batterson