Date: Thu, 26 May 2022 10:48:27 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Christophe Pettus <xof@thebuild.com>
Cc: Michael Paquier <michael@paquier.xyz>, Peter Geoghegan <pg@bowt.ie>,
	Robert Haas <robertmhaas@gmail.com>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Andres Freund <andres@anarazel.de>,
	Andrey Borodin <x4mmm@yandex-team.ru>,
	=?utf-8?B?0J/QtdGC0YrRgCDQodC70LDQstC+0LI=?= <pet.slavov@gmail.com>,
	PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #17485: Records missing from Primary Key index when doing
 REINDEX INDEX CONCURRENTLY
Message-ID: <Yo+TOynsPE1Od8jI@momjian.us>
References: 
 <CA+TgmoYP7BnHXTEoJRUnOuie2J05Qo8ti5mnE2u-1c4Hk+8zJw@mail.gmail.com>
 <202205251643.2py5jjpaw7wy@alvherre.pgsql>
 <CA+TgmobNBHAObYS1yeX6C+Ph3ccborF86t9XFERdvtmmu-5DMg@mail.gmail.com>
 <CAH2-Wz=cDCzrfwm8YYF4vd8oMNJtVRh+_BbCqhCrKzX1NgXzQw@mail.gmail.com>
 <Yo7xTUr3eNgxuBq4@momjian.us>
 <Yo72aOILTPjBldWU@paquier.xyz>
 <Yo+RQ2wSZIP/ljtt@momjian.us>
 <BB3FB2D1-9796-442B-AF11-08DFD0BF0F57@thebuild.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <BB3FB2D1-9796-442B-AF11-08DFD0BF0F57@thebuild.com>
Archived-At: 
 <https://www.postgresql.org/message-id/Yo%2BTOynsPE1Od8jI%40momjian.us>
Precedence: bulk

On Thu, May 26, 2022 at 07:41:28AM -0700, Christophe Pettus wrote:
> 
> 
> > On May 26, 2022, at 07:40, Bruce Momjian <bruce@momjian.us> wrote:
> > 
> > Uh, if people don't know if they have used CREATE/REINDEX CONCURRENTLY
> > in PG 14.0+, they are going to need to run amcheck on all btree indexes
> > and reindex all non-btree indexes?  That is going to be a painful
> > message to deliver, and hear.  :-(
> 
> Unless we are 100% sure that amcheck will never return a false negative in this situation, we may have to recommend reindexing everything.  Ouch.

I assume we are then looking at reindexdb, which has a parallel option. 
I assume we can also recommend --concurrently on a patched PG 14.4,
which might not be terrible since it would not cause downtime.  I guess
the command would be:

	$ reindexdb --all --concurrently --jobs ##

Without reindexdb's features, this would be much more painful.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Indecision is a decision.  Inaction is an action.  Mark Batterson