Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 25 May 2022 09:45:31 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Julien Rouhaud <rjuju123@gmail.com>, Mats Kindahl <mats@timescale.com>,
	pgsql-bugs@lists.postgresql.org
Subject: Re: Use of signal-unsafe functions from signal handlers
Message-ID: <Yo18KyPNP0G03n10@paquier.xyz>
References: 
 <CA+14425wJh3m2XA4c8-stRKGQYLwKqFiScqZm7BBt1JxU2iU-g@mail.gmail.com>
 <20220524101418.7pp65powa362vzln@jrouhaud>
 <CA+14426Zpdi6=jr9Z+C_tzS36pVa_+BbCHSeriqd=sLw4X6_iw@mail.gmail.com>
 <20220524123739.6glyxyx4owqpqjnr@jrouhaud>
 <1531973.1653401755@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="g9TqLzR1nFmIdtqq"
Content-Disposition: inline
In-Reply-To: <1531973.1653401755@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/Yo18KyPNP0G03n10%40paquier.xyz>
Precedence: bulk


--g9TqLzR1nFmIdtqq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, May 24, 2022 at 10:15:55AM -0400, Tom Lane wrote:
> ereport() itself is just the tip of the iceberg; even if it's safe
> (which I concur it isn't), there's also the atexit/on_proc_exit
> functions that are likely to be called during shutdown.  So yeah,
> this coding is not too safe.  I'm not sure that getting rid of it
> would be a net win though, as we'd replace it-might-crash hazards
> with it-might-never-exit hazards, from bgworkers that neglect to
> respond to ShutdownRequestPending.

Hmm.  Shouldn't we worry about FloatExceptionHandler() that gets used
on SIGFPE?
--
Michael

--g9TqLzR1nFmIdtqq
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmKNfCoACgkQnvQgOdby
QH1DPhAAkAcuNfEiXMMJqSASYLw7iw+FJLljJTMC2/mKc4+TZHpGB1UZF7FjcvIh
3We4tXUBCpVd8fS6ReJmCMC1xIeQx+Owr1OlMhrh3yFzARX+l3yp0xcZOMGHIQl/
Yx4T+/HJFXOS6jZ3o1L5g5AvQAr372aUSogSKMrU6OqPnTl8Qyi+us56uU2ESbOM
MUHSt30ZWJzBiioA8gNriXMkxg5t2LQiVSQEOyksTU7sl9lFLzCbtX5uGxOK7TGz
AfVKZguCeN5PShtRPYCTwIlKkAl8iNcjv00g8Pr7bMmsQH8Cw4pvoFAr8IcUItuM
eoRHR9jKnF3Qp2xwaUsXC8zkjDqP89awbAqDGSy2K1W2naeYgo1xkMzCYZNUXDI4
Q/xUD3OSvoIp8CGXRXnppMb5waOpDpQ8VWVoaKMF0f090X2/lEv7gl/NMbnKV7HG
vklr6SmKZlv2TNcUHkL8dPdNhksEDmM5DKxvC/5LZ/7jKkkHAnatTp0HD8kDXUKh
iiTDawGV2yMxX8CsG8DRzTX/nrqwZTws5VwfVyZDVh1juaJbepyf7g9wpO9lEgsu
fIwCDjf/mZq0MA5IHp+1lJUb22C7e0W9hbkNsVcnJcbyQfYsoJYUu0iAC3y5fFIy
QojAPkqgRk25mdGp17yB0fw5yXsd5eGAtIWtHA/kBPmlmB0pM5I=
=7dzJ
-----END PGP SIGNATURE-----

--g9TqLzR1nFmIdtqq--