Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 19 May 2022 17:56:09 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
	LEMAIRE Leslie =?iso-8859-1?Q?=28Charg=E9e_de_mission?=
	=?iso-8859-1?Q?=29?= - SG/SNUM/UNI/DRC
 <leslie.lemaire@developpement-durable.gouv.fr>,
	pgsql-bugs@lists.postgresql.org
Subject: Re: Implicitly created operator family not listed by
 pg_event_trigger_ddl_commands
Message-ID: <YoYGKWWwrB+8AlV/@paquier.xyz>
References: <f74d69e151b22171e8829551b1159e77@developpement-durable.gouv.fr>
 <202205041017.uc3dxylntais@alvherre.pgsql>
 <CAD21AoBGqNBe=ydCxSoZnZQw9RA72DbQnTuFOhVDWkvF1wvHXw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="pv7WMxosdDnprsAC"
Content-Disposition: inline
In-Reply-To: 
 <CAD21AoBGqNBe=ydCxSoZnZQw9RA72DbQnTuFOhVDWkvF1wvHXw@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/YoYGKWWwrB%2B8AlV/%40paquier.xyz>
Precedence: bulk


--pv7WMxosdDnprsAC
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, May 06, 2022 at 02:26:42PM +0900, Masahiko Sawada wrote:
> DefineOpClass() calls CreateOpFamily() to create the operator family
> but in CreateOpFamily() we don't report the new object to event
> triggers. The event by CREATE OPERATOR FAMILY is normally reported by
> ProcessUtilitySlow(). I've confirmed this happens on all supported
> branches. I've attached a patch to fix it.

Hmm.  It looks like it makes sense to back-patch that.  That's indeed
a bit surprising to not have an event trigger inform about both.

+-- CRAETE OPERATOR CLASS without FAMILY clause should report
+-- both CRAETE OPERATOR FAMILY and CRAETE OPERATOR CLASS
Got the same typo here, repeated three times.

-           tmpAddr = CreateOpFamily(stmt->amname, opcname,
+           tmpAddr = CreateOpFamily(&opfstmt, stmt->amname, opcname,
                                     namespaceoid, amoid);
CreateOpFamily() does not need its second argument now that you pass
down a CreateOpFamilyStmt as first argument, no?
--
Michael

--pv7WMxosdDnprsAC
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmKGBikACgkQnvQgOdby
QH02ww//bKDP9M4PecHisZzI0vel3LuSqFxs5CWVDktGf1HT5CFAqqlb3uWEt6Qm
zbJ1MFHSSLE4fpTtntEox/zyhnW0De7oiP7sDYsfQQZDrxPKvfjQLkzJknCwwM7D
R4NgivxZUHIPgBzHgBUWfbc2fvnPqyfWIpFBjh+7v4guz6LXjxuIq+2fl7hFL3+M
2F+nO6TYXLO+JYE+sGCxvPkQrG1PLg8FrQLtSfG9u/L1v6DgCQwKlKPxv2JT3hyO
yB6xdATNCSfO6/OnX9hoispD8MuaDySo2gIvMhBABYSSzn4s8hpJlZ+TxqTZkhvn
JXImbmjzD1QvtLEJI+wQiGf5Ci2b5gdljav9yMvTpY8uWN81gqewFy+ywoQzpEAV
eknIy8Ue8sz0Ms/UFA3j4wXeOtoN18P/Gef4+XDp+mHqyHz0+RZ99MpX8OV8qyA0
AMatCVVQy7yi5slvUW8XUbZzKR+Rvxl30eRXvXp8fhDUCNNRKz3YjMw0emc8AoBN
OmeaF/ZIvKPrFe8h/t/qpTWIQuSZj1p/olzYq3U1MuHnKTDpy0inpoYjGteOOpIy
DomO2hoVUF9Haumvv+PjSgdW5rxWpf45qzviTAloPyv7LWIJSo8X8m7KqgjZzkpj
LqN5+xgo6ZE6NANjhmgUe82jRPabewVtZ7RuGP3u39CpanLsIIc=
=AScW
-----END PGP SIGNATURE-----

--pv7WMxosdDnprsAC--