Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 6 Jun 2022 11:15:44 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: christoph.berg@credativ.de, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17504: psql --single-transaction -vON_ERROR_STOP=1 still
 commits after client-side error
Message-ID: <Yp1jUAVnyYfn80vu@paquier.xyz>
References: <YpTgRGknCLBopP8C@msg.df7cb.de>
 <20220531.113927.640026319524742851.horikyota.ntt@gmail.com>
 <YphNHbOkg22H7d52@paquier.xyz>
 <20220603.175603.682874096867945240.horikyota.ntt@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="0foBS80S/QYIPew3"
Content-Disposition: inline
In-Reply-To: <20220603.175603.682874096867945240.horikyota.ntt@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/Yp1jUAVnyYfn80vu%40paquier.xyz>
Precedence: bulk


--0foBS80S/QYIPew3
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jun 03, 2022 at 05:56:03PM +0900, Kyotaro Horiguchi wrote:
> At Thu, 2 Jun 2022 14:39:41 +0900, Michael Paquier <michael@paquier.xyz> =
wrote in=20
>> 001_basic.pl, but we also need to be careful when sending down queries
>> with psql expected to fail because of SIGPIPE (c757a3d, 6d41dd0).  The
>=20
> This does not need to send a byte after the client-side failure. The
> connection is rather living after failure in this case.

Sure, but I don't think that we can reliably test the case where one
of the switches triggers a backend-side error, which is what my point
is about.  I have added a note about that, with a couple of extra
tests with -f, with both success and failure scenarios.  And we'd
better add -X to all the commands as well.  These are added only on
HEAD as the test file is rather new.

>> It causes psql to issue a BEGIN command before the first such option
>> and a COMMIT command after the last one, thereby wrapping all the
>> commands into a single transaction.
>> If any of the commands fails, a ROLLBACK command is sent instead.
>> This ensures that either all the commands complete successfully, or
>> no changes are applied.

Looks fine to me, so applied down to 10.
--
Michael

--0foBS80S/QYIPew3
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmKdY08ACgkQnvQgOdby
QH2t+w//dtrJPgyhwde36JKZaK/0hQvOYyqPLaorWwTTZIo3QiJz8Lp/ba2CFbuV
eogv8iE6PpDGQ/i/3tDtAhDO6t/h9/Oyb0VqbJvgqnniD4NpJhnidNnLbPLXuBns
MiMa1HV5/Zv9LArp+jOL4ZCxGWsAqVcNJ10a2Gkda3L0Ha+ZZN9lCfC5GxmLmqTs
3oa3RXK3eo5kKeg4Tg+01apzd6NGhnmQESxNDLNj1zPLijCJRMWu2tSMTOhKtqt3
xYeLvgyBg8Kn7jFn+dhVxmtw+IENAmmw9oU819/EtyFSgWD8dnncx58hz+TLC/l/
UmJfTQhnOTbYVzb5n3L/56nfg/NRrD7f0I8i21cTL+V7NMUENAD8t+r/yg3Fe4Fv
6eYIyUQk0eMv5tCvLsOrQ/BfX0HFExt/W+WR5ozwaUMEEVgjBL6o+Og4LNFlxbsc
EYHScZQ/ojhFGkIDFzWTfDgqriIBFnR96Y22N99um1StcFXHg4eMVeVHUYgF9Kj9
Rh5lW3smP1fNQ3VemAG6cV9Ar8OIdRrbFTtPzRbOUPXFS/1cHvYhkygCWor/sAI6
cD0Ec+UGmRUONX4uvP3bvhQsOPgMgr22gMjy+pjl8bIckjawnwO3YpZjK3j9+3wM
PfpihA5cj55FLJnoAR8KNny/nA/oUNFG4ig+wL9v6bFv491r1Ks=
=Cyfk
-----END PGP SIGNATURE-----

--0foBS80S/QYIPew3--