Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 7 Jun 2022 11:53:08 +0900
From: Michael Paquier <michael@paquier.xyz>
To: "David G. Johnston" <david.g.johnston@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	Christoph Berg <christoph.berg@credativ.de>,
	PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #17504: psql --single-transaction -vON_ERROR_STOP=1 still
 commits after client-side error
Message-ID: <Yp69lO4sAtP3xUZJ@paquier.xyz>
References: <YphNHbOkg22H7d52@paquier.xyz>
 <20220603.175603.682874096867945240.horikyota.ntt@gmail.com>
 <Yp1jUAVnyYfn80vu@paquier.xyz>
 <20220606.151124.656806001979080471.horikyota.ntt@gmail.com>
 <CA+TgmoZnSjX_rFK_EeuCS6TNZkQBwS=2q=BdZSwU4B0BVVwjVw@mail.gmail.com>
 <CAKFQuwaQvHekKZo6y4ajmRfEjwkPvt_8YDWqVJnfL4py4txFqg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="VFMcbZLKqt1FoTuT"
Content-Disposition: inline
In-Reply-To: 
 <CAKFQuwaQvHekKZo6y4ajmRfEjwkPvt_8YDWqVJnfL4py4txFqg@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/Yp69lO4sAtP3xUZJ%40paquier.xyz>
Precedence: bulk


--VFMcbZLKqt1FoTuT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Jun 06, 2022 at 01:05:46PM -0700, David G. Johnston wrote:
> We've done worse when dealing with obvious bugs contrary to the
> documentation and that prevent unsafe behavior.  People relying on the
> defined behavior to safely fail when encountering unexpected failure
> producing situations that hopefully never happen get the priority over
> poorly written code that somehow relies on errors not respecting the single
> transaction promise.

Yeah, I think that the past behavior was a bit crazy.  On a
client-side error, psql reports a failure with an error code but would
commit any changes that happened before the command that failed with
the underlying commit created by --single-transaction, while
discarding any future commands.
--
Michael

--VFMcbZLKqt1FoTuT
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmKevZQACgkQnvQgOdby
QH02PhAAmlDli31hGRI1pTtzZ47v4CcmrqQB+WHcNJbMN/gkWEoSKr8zaho1cwbu
gtOYq7mvDw7XR/UP5cDv+VEora/yHjnDU+Cirbvymf+VRv/JbfrEW1m3eSK8shGs
w96Ad6whsZsAAscN563Ufc7a8z+BgK5IzyggWO1/jJrHYJJvw7MZWGSSOLqphfhs
F2XJRhPu4jvGwDxm/QDmKapLaSiFs1G3pdcjZf1teoTV3Ylt9nmXIVY+MCoNQkS+
QqKYe2bbmdNNR6XMuGZlZs9OXjOzYDSSDEUvFL2u+ivGvwBEheyTPgLMcJWFgQe+
QSwxswzRoVbru9CgCYKmenyKdne9xkcOtzuy3gjJSFZEUFhvnXttUmExXH65aoL2
aOolp2jodBVWEUOx+GynqlkEawN/xUa8uTKM2UZ//ZmtoY2OQdu9hNzv99qg55MD
nAetQSS74BXmweOrR9pefiV/KpBmNctvJu9A5wXL082psL9KOLu7lIhAzFXMfYwO
P3F8WAuJPoICBO61/a1hPsINGFCAgeHUq3woEtOrM0kFG06VibE/kqkARm4SZF98
54zoZkIoIfymI6zJ4h3lUyfCiMWex3vZR4v9O0yLcpgfMx7wOL74owstC4p+8voz
MIZ1hiiXRFagTNEZNlSi4HcdVrKI4M7TW8S/UyYvI4apkFQq/aw=
=leDv
-----END PGP SIGNATURE-----

--VFMcbZLKqt1FoTuT--