Date: Wed, 15 Jun 2022 11:13:56 +0200
From: Christoph Berg <christoph.berg@credativ.de>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>, robertmhaas@gmail.com,
	pgsql-bugs@lists.postgresql.org
Subject: psql --on-error-stop (Re: BUG #17504: psql --single-transaction
 -vON_ERROR_STOP=1 still) commits after client-side error
Message-ID: <Yqmi1IcXs5WofNvD@msg.credativ.de>
References: <2649417.1654875709@sss.pgh.pa.us>
 <2656555.1654877531@sss.pgh.pa.us>
 <Yqbc8bAdwnP02na4@paquier.xyz>
 <20220613.160701.975499861789120736.horikyota.ntt@gmail.com>
 <3791929.1655131936@sss.pgh.pa.us>
 <Yqfk6QSTJjUQodaD@paquier.xyz>
 <Yql3sc3cvYvLlEHu@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <Yql3sc3cvYvLlEHu@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/Yqmi1IcXs5WofNvD%40msg.credativ.de>
Precedence: bulk

Re: Michael Paquier
> Well, done.  One thing that I find a bit surprising in all that is the 
> lack of consistency in the handling of the return code of psql when
> the last switch fails when not using ON_ERROR_STOP.

TBH ON_ERROR_STOP itself feels very brittle to me. Besides the fact
that `psql -vON_ERROR_STOP=1` looks very ugly, it's only one typo away
from breaking silently. `psql -vSTOP_ON_ERROR=1` (or -vON_EROR_STOP=1)
looks good as well, but doesn't work.

There should be a proper command line switch for it like
`psql --on-error-stop` since typoing that errors. (The short options
-eEsSq are already taken, so I'd propose psql -Q.)

Christoph
-- 
Senior Consultant, Tel.: +49 2166 9901 187
credativ GmbH, HRB Mönchengladbach 12080, USt-ID-Nummer: DE204566209
Trompeterallee 108, 41189 Mönchengladbach
Geschäftsführung: Dr. Michael Meskes, Geoff Richardson, Peter Lilley
Unser Umgang mit personenbezogenen Daten unterliegt folgenden
Bestimmungen: https://www.credativ.de/datenschutz