Date: Mon, 4 Jul 2022 16:38:26 +0200
From: Christoph Berg <christoph.berg@credativ.de>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>, robertmhaas@gmail.com,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17504: psql --single-transaction -vON_ERROR_STOP=1 still
 commits after client-side error
Message-ID: <YsL7YmghTdpRsKFZ@msg.df7cb.de>
Mail-Followup-To: Christoph Berg <christoph.berg@credativ.de>,
	Michael Paquier <michael@paquier.xyz>, Tom Lane <tgl@sss.pgh.pa.us>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>, robertmhaas@gmail.com,
	pgsql-bugs@lists.postgresql.org
References: <2649417.1654875709@sss.pgh.pa.us>
 <2656555.1654877531@sss.pgh.pa.us>
 <Yqbc8bAdwnP02na4@paquier.xyz>
 <20220613.160701.975499861789120736.horikyota.ntt@gmail.com>
 <3791929.1655131936@sss.pgh.pa.us>
 <Yqfk6QSTJjUQodaD@paquier.xyz>
 <Yql3sc3cvYvLlEHu@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Yql3sc3cvYvLlEHu@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/YsL7YmghTdpRsKFZ%40msg.df7cb.de>
Precedence: bulk

Re: Michael Paquier
> On Tue, Jun 14, 2022 at 10:31:21AM +0900, Michael Paquier wrote:
> > Okay, let's do so then on HEAD.  I'll wait a bit more, in case others
> > have an opinion to offer on the matter.
> 
> Well, done.  One thing that I find a bit surprising in all that is the 
> lack of consistency in the handling of the return code of psql when
> the last switch fails when not using ON_ERROR_STOP.  For example, psql
> fails if the last switch is a slash command from -c, but succeeds if
> the last switch is a slash command in a file from -f that exists.
> This comes down to the way failures are passed down from MainLoop() so
> I am not sure if this is worth worrying about and nobody has
> complained about that AFAIK, but I have added some extra tests to at
> least document everything I could think about to track changes, in
> case somebody plays with this code in the future.

Is there anything left to do to fix up the --single_transaction +
ON_ERROR_STOP case here? From reading the code, it now does what it
should do. What is left to do for backpatching it?

Christoph