Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 5 Jul 2022 09:12:03 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Christoph Berg <christoph.berg@credativ.de>,
	Tom Lane <tgl@sss.pgh.pa.us>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>, robertmhaas@gmail.com,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17504: psql --single-transaction -vON_ERROR_STOP=1 still
 commits after client-side error
Message-ID: <YsOB02HCzc+S/cgL@paquier.xyz>
References: <2649417.1654875709@sss.pgh.pa.us>
 <2656555.1654877531@sss.pgh.pa.us>
 <Yqbc8bAdwnP02na4@paquier.xyz>
 <20220613.160701.975499861789120736.horikyota.ntt@gmail.com>
 <3791929.1655131936@sss.pgh.pa.us>
 <Yqfk6QSTJjUQodaD@paquier.xyz>
 <Yql3sc3cvYvLlEHu@paquier.xyz>
 <YsL7YmghTdpRsKFZ@msg.df7cb.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="FpzF8D+LHsn2rkPZ"
Content-Disposition: inline
In-Reply-To: <YsL7YmghTdpRsKFZ@msg.df7cb.de>
Archived-At: 
 <https://www.postgresql.org/message-id/YsOB02HCzc%2BS/cgL%40paquier.xyz>
Precedence: bulk


--FpzF8D+LHsn2rkPZ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Jul 04, 2022 at 04:38:26PM +0200, Christoph Berg wrote:
> Is there anything left to do to fix up the --single_transaction +
> ON_ERROR_STOP case here? From reading the code, it now does what it
> should do. What is left to do for backpatching it?

As per upthread, Tom and Robert do not seem to agree on this point.
And it is true that this creates a behavior change.  At this stage, it
could be a good idea to gather more votes.
--
Michael

--FpzF8D+LHsn2rkPZ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmLDgdMACgkQnvQgOdby
QH1U+Q//WcCrmzjNz1d6hC8lbFmOAJ8cd+d331rZGT4kxmSC7SFUi+U/RNDOdOh/
ulCGb7yhv4nUfastO1XxilP01AQQuNYxzPkj8xoqZolUVBkIepaQ6PozqKpmHqOX
N5V+CGUlQuiMCWKUTuGmabOks0S2h7FcwnI9mr06mqpr+//kLsA3laUvCi5BbQVE
4KD6hwirdJR7fQ8ERKJCEpR0MMmw4dVmMwdYKSCiPgubxp8cJD1nUaavroLYNzZi
Z7jIzXiuh0RQH6P+TMJiMfhQPe/4ltzk/h1Ws6mKF7SPmRctlX1y+r89HPoTBgBv
/dTJlajyoNi6UN0DuQXh3p3Yn1PcHsWhezPPx/fHDWlzGVIE26DwlOOkX/VnqGvy
ro7iD7nv59wDrC7LeEUw4MU7rgqOSeHBGdUIsxp/TRuEsM+y4Wdiiu0zdE4Ssj0n
rF7LqkG1PG7+8Z42puvkv9RtYnzKDBKc++SWf/oSjgwBNPTrImr3xTVivtEM8NiD
spKzEke/1KYUVVdFEnaQqX7przp5R9f3250kzVAzMnK/H4SHUjeIhJ00zaU3oZ+R
jRoBOk9CXhKJI/WjxRME1ln4jJ3G1pB/j6+qL2fS5Y2WYSJhWW8Aw2t72mAcvkJh
fHLBvIqpJumF7roD8CsR/BgzSNjsow3ZZ/cSlOQ2+RXawesaqVY=
=1s2C
-----END PGP SIGNATURE-----

--FpzF8D+LHsn2rkPZ--