Date: Fri, 22 Nov 2024 14:17:07 -0600
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
	Bruce Momjian <bruce@momjian.us>, adam@labkey.com,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18711: Attempting a connection with a database name longer
 than 63 characters now fails
Message-ID: <Z0Dmw1ryKH8bEkyo@nathan>
References: <Zz9IHPBf-z8MsLdw@momjian.us>
 <Zz9OTyWAvATeeHev@nathan>
 <Zz9jfOkVmlYcYHSy@momjian.us>
 <Zz9pOi3pGF-DnJTp@nathan>
 <Zz92cka2VlBDsat3@momjian.us>
 <Zz94l3LHsML0V9eu@nathan>
 <Z0A2o+dS0MqDE2Fs@ip-10-97-1-34.eu-west-3.compute.internal>
 <659706.1732303427@sss.pgh.pa.us>
 <Z0DjJbJV4ZWkLuQd@nathan>
 <665338.1732306066@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <665338.1732306066@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/Z0Dmw1ryKH8bEkyo%40nathan>
Precedence: bulk

On Fri, Nov 22, 2024 at 03:07:46PM -0500, Tom Lane wrote:
> Nathan Bossart <nathandbossart@gmail.com> writes:
>> I think we'll also want to do something about MyProcPort->database_name
> 
> Huh, isn't that getting filled from InitPostgres's out_dbname?

I think ProcessStartupPacket() sets it.  That's called by
BackendInitialize(), which is called before PostgresMain() (which is what
ultimately calls InitPostgres()).  The truncation used to happen within
ProcessStartupPacket(), and it updated MyProcPort directly.

-- 
nathan