Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 8 Jan 2025 12:22:41 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>,
	Heikki Linnakangas <hlinnaka@iki.fi>,
	Alexander Lakhin <exclusion@gmail.com>,
	Tom Lane <tgl@sss.pgh.pa.us>,
	Laurenz Albe <laurenz.albe@cybertec.at>, rootcause000@gmail.com,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18146: Rows reappearing in Tables after Auto-Vacuum Failure
 in PostgreSQL on Windows
Message-ID: <Z33vgfVgvOnbFLN9@paquier.xyz>
References: <ZyCTXqPG_uGvLJtZ@paquier.xyz>
 <CA+TgmobP2AEjS5qzfEVGugfQw1H+7DF283udewzTDPO3-2G-Kg@mail.gmail.com>
 <CA+hUKGJSOEZWx9zRFFfOfDj9zbVmMbWKRq+ZzMCXftHcO1UYQQ@mail.gmail.com>
 <CA+TgmoZj9dJhHQokHioXB8dyDZz5gjzyg7SbUrG=At-uShq7yA@mail.gmail.com>
 <Z2TcN-ypscC4Jomj@paquier.xyz>
 <CA+hUKG+Thae6x6+jmQiuALQBT2Ae1ChjMh1=kMvJ8y_SBJZrvA@mail.gmail.com>
 <CA+hUKGJ4jqhJVTnwiMFbmVonSMn+E9MW3YDZ+JEz9ov_h19RNA@mail.gmail.com>
 <Z2pLwQGNaKq2_JTk@paquier.xyz>
 <CA+hUKGJcBhcUteJ5AcOibq2T24JPxyJFP7GsQ2SaYP-5sA7hNQ@mail.gmail.com>
 <Z329yX7VREL86mnm@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="S65rbqUkoaK3Qqok"
Content-Disposition: inline
In-Reply-To: <Z329yX7VREL86mnm@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/Z33vgfVgvOnbFLN9%40paquier.xyz>
Precedence: bulk


--S65rbqUkoaK3Qqok
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jan 08, 2025 at 08:50:33AM +0900, Michael Paquier wrote:
> Sounds good to me.  Thanks for the commit!

Actually not that good, and wrasse is reporting a failure:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dwrasse&dt=3D2025-=
01-07%2022%3A26%3A00
"/export/home/nm/farm/studio64v12_6/REL_15_STABLE/pgsql.build/../pgsql/src/=
backend/storage/smgr/smgr.c",
line 634: void function cannot return value

It seems to me that you meant to do the following in the back
branches:
--- a/src/backend/storage/smgr/smgr.c
+++ b/src/backend/storage/smgr/smgr.c
@@ -706,7 +706,7 @@ smgrtruncate(SMgrRelation reln, ForkNumber *forknum, in=
t nforks,
 	for (int i =3D 0; i < nforks; ++i)
 		old_nblocks[i] =3D smgrnblocks(reln, forknum[i]);
=20
-	return smgrtruncate2(reln, forknum, nforks, old_nblocks, nblocks);
+	smgrtruncate2(reln, forknum, nforks, old_nblocks, nblocks);
 }
--
Michael

--S65rbqUkoaK3Qqok
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmd974EACgkQnvQgOdby
QH3yjhAAmH0CY8i9smWtM0+Nt16STlzZOe8io8ZDSW9JbHOM41EJRK/C5Nfk6ac4
n2YVj+P3rluZ5mcYIh2U2SZ96a5OZOG5UXaIwpiRzJLyNiXhLHAx1wNacRkWRpIs
D+5HtGvEQb/T7XxbpklIRn8bFq6DlgwbqMrWwMW48Sy4RDI1uZ2BYozvackGPfZM
Z+Zt0xarsT2/IMMMkmN5frf+UanbZQj44K9y3fX4A7/XWQOS/hfq2zjpSj6Gd2g0
asKfpwwE3c6L4RZ5KroBd9rauDco2j2skrdYxctcJhLaO1KDXXLLCepi8/NaPsH3
hRKSfXSFwLhQPZGCQIqYDzokiZqMJkr40eYCJWdKNGxp2im8Pnjlo9iiLdtYW2Y1
EJbFpM8r0fCYVxGvSuUlef4sUydssX9OLPC+2wYUHS1n2BTfI/HTTct/cP0AN5rf
bQIp/cYCpF73cKh7cpMH2XJRwTsXxyh6/UVlmnuUAVCJv6Y3p+Q0we7XFaxE6Kdz
svcC6Seg6dWM3+XGAkciwgRpQBJEkIuQGrSWJ8x+2XqfyYI4nvcBKmTOD/StReI1
9bj1HFK8szxxe8nAelF+v08rnwybQBrGtAmFqfVujefiKZ83ELv51Akbq/DeFQXv
FmZ6tEofCxix5sgQ4+BhbV0jbFegArJF+HA8kjI1NzVEP5c5aaE=
=aWkG
-----END PGP SIGNATURE-----

--S65rbqUkoaK3Qqok--