Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tsRMJ-0024Bw-Q3 for pgsql-bugs@arkaria.postgresql.org; Wed, 12 Mar 2025 19:03:15 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tsRMG-00BI0A-7q for pgsql-bugs@arkaria.postgresql.org; Wed, 12 Mar 2025 19:03:12 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tsRMF-00BI02-St for pgsql-bugs@lists.postgresql.org; Wed, 12 Mar 2025 19:03:11 +0000 Received: from mail-oo1-xc2d.google.com ([2607:f8b0:4864:20::c2d]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1tsRMC-002VCN-0M for pgsql-bugs@lists.postgresql.org; Wed, 12 Mar 2025 19:03:11 +0000 Received: by mail-oo1-xc2d.google.com with SMTP id 006d021491bc7-601a891ab8fso137358eaf.1 for ; Wed, 12 Mar 2025 12:03:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741806187; x=1742410987; darn=lists.postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wQUrwQ9qQAXajWL4CGQ7PMVWPBxgpk5gipKVSpkyyDQ=; b=gClXezoy07asVzBp7jJ5LZ85IhSwWD02AQz8icEGiUWObt8BD0XpkD7vWbsuW9KkEN 27oktsCrMSA0VKjmQJ4T3a9OwbkzYfAqxT2Qb7LLscnVnz7i37th3MGFMx1uka2Q9kS+ H5TzceyCPwWwVBB9E2N/utUEXvaRaQKC3JHCsaFsuIhVj00phksinxt4E3TGdybQ8Org xcrG+CsSHR5DCWgZ87FZQtXgR9TFNN8oV8nxREXDzHlumjpWQ53fYRAB+3Ynv7uWDWgr Tf9NKuTdTN4Zho7RiTAkHcSQ0aYOG1eOZTd66PoeJhAT6eTtLGzKd6KAn8a1lwvkADH6 kR3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741806187; x=1742410987; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wQUrwQ9qQAXajWL4CGQ7PMVWPBxgpk5gipKVSpkyyDQ=; b=sUmZXApQrv+4lr4FNwEqo2EXPXib2XUi6oRyQc9ioSYYsArc4fV0IJ3Uwm2jz2A9Ga VPZclXw8upskhtEfJ67rzK1xyf8bNxseyC8J4J+Q3CyIF8oFxWglF/SQH9lIzkYfrT+m dwBlJrOC5dxBW3oPtHi2h4CW+WuBCMJOvS/sWx9aNrf7CeTDLp9G98dooM0ISa07ythJ 31+kcxWgjAMDYr8vxUTsrp+zJO9tcptp5DGtyFFhrYFUj/QL0jqdyDYzr5UFQqtru8x2 /OAB7K4QqCdq2CVuQNn/0qntHUnedjSDCfzyEeODLUip3mIStLDnwgLJery3+e7mKLQ0 K2Yw== X-Forwarded-Encrypted: i=1; AJvYcCUgfzAB+6ETlqAdFFiXt0cuU4v7ZXDgCBRs9BzldL30O3LVosmH5rYeKszZZIPt0jeRrTbhN2ZZl5tj@lists.postgresql.org X-Gm-Message-State: AOJu0YyabXVJfbZXAreLg3PDDbviWhXiiLVCb+2t8eD0NWa1BvJCxVVB 3r0q8/Ppq9fefJe3NLBXRs09QQWqhLCV7Jl8pqWcfm4OTjVJOV99 X-Gm-Gg: ASbGncsqCHfOCzj5CwZIO1f5vmG33xQlCFVMk8oksrr+KO36IqI8M1k9+hA7VHGP33S q1wKJL+NKrDiNgTBqROvQL9Qdd6KQ3bSQjj2ihJxu+RqN70T3pWS8XANelvNiNSSISMOFlHHejL bpZMhVDCZqvpsFJOE3BV4rcqmU5Kzh/xXq+5MnrkE5Gd/S7uuBRR+6vX+S+k6RqpQvCz6Ox7Loc qOYk9t7SIDfJm8W77BJNENRZ9fAGXrT5ExMxWoNVGQrMvIUGGYRoq/8FCH1TBR7V/GQPhDPPnQ9 0Q1+ZIcqdbo/ZTxEqywiCS2T/NfX+j94fxtVUfE/1A1ctpy/pGcF9eLk0uRaHU0HywobM0m1RdA YZ7zEOziJjjpaZjxngYE0sSPMqaJqBKcip8o= X-Google-Smtp-Source: AGHT+IH5ijKwcx+82uscSggMzk9jDpycvVQYDPk7wcem18QL+6TPHH5L7nTjCpUY8qWTT0RjqUvRHA== X-Received: by 2002:a05:6820:2d09:b0:5fe:9b5a:531 with SMTP id 006d021491bc7-601d862796fmr593890eaf.0.1741806187446; Wed, 12 Mar 2025 12:03:07 -0700 (PDT) Received: from nathan (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-601a57fe78csm1615013eaf.10.2025.03.12.12.03.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Mar 2025 12:03:06 -0700 (PDT) Date: Wed, 12 Mar 2025 14:03:04 -0500 From: Nathan Bossart To: Masahiko Sawada Cc: Bertrand Drouvot , Tom Lane , tharakan@gmail.com, pgsql-bugs@lists.postgresql.org Subject: Re: BUG #18828: Crash when pg_get_logical_snapshot_meta() passed empty string Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, Mar 11, 2025 at 03:34:18PM -0700, Masahiko Sawada wrote: > Pushed. I'm seeing warnings for the CI build on Windows [0] that appear to be related to this commit: c:\cirrus\contrib\pg_logicalinspect\pg_logicalinspect.c(88) : warning C4715: 'parse_snapshot_filename': not all control paths return a value I suspect we just need to do something like commit fe4ecd0 and return InvalidXLogRecPtr after the ERROR. [0] https://api.cirrus-ci.com/v1/task/4876492255002624/logs/build.log -- nathan