Date: Wed, 12 Mar 2025 17:00:46 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
	Tom Lane <tgl@sss.pgh.pa.us>, tharakan@gmail.com,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18828: Crash when pg_get_logical_snapshot_meta() passed
 empty string
Message-ID: <Z9IEDusmmoK8Nt0P@nathan>
References: <Z8fywBInu4Q4k13q@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAD21AoBVnenMbN4qccEmCOE9H=_Z1PUaPMBf0HPjK4E9W7z3gw@mail.gmail.com>
 <Z8lYuIFdrtF7Wb9K@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAD21AoCSTvvegzU8_JCuxy0k7ff61pCbJY+6aRneY0in5WbwPQ@mail.gmail.com>
 <Z8qZ8PeWec6XdhxZ@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAD21AoBQ2hr4DSJeLy9xg-87A3QpV_Ga9x_pRY3mupZTjMqOEw@mail.gmail.com>
 <Z8v5m4nOSGhCK6dS@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAD21AoBLQUZn-jgh7ssOe5KMxGobdmnC0B_zk4yEEqq3PCT+qQ@mail.gmail.com>
 <Z9HaaODoGk1-4_SL@nathan>
 <CAD21AoC8s0e0umq6dbbQwYMVoUs2xd8L8LUY5Vjj5c7a_-9usQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAD21AoC8s0e0umq6dbbQwYMVoUs2xd8L8LUY5Vjj5c7a_-9usQ@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/Z9IEDusmmoK8Nt0P%40nathan>
Precedence: bulk

On Wed, Mar 12, 2025 at 02:33:36PM -0700, Masahiko Sawada wrote:
> Thank you for the report! David also reported the same issue[1]. I've
> just pushed the fix.

Oh, sorry, I should've checked that list first.

> BTW how did you catch the warning? I checked before the push if the
> change had passed the CI tests (completed with green status). But when
> checking the build log now, I can see the warning in the build logs.

I noticed a ⚠ next to the results on http://cfbot.cputube.org/.

-- 
nathan