Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ppHxu-0002HP-Cb for pgsql-bugs@arkaria.postgresql.org; Thu, 20 Apr 2023 00:15:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ppHxt-0004vW-6E for pgsql-bugs@arkaria.postgresql.org; Thu, 20 Apr 2023 00:15:57 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ppHxs-0004vN-F8 for pgsql-bugs@lists.postgresql.org; Thu, 20 Apr 2023 00:15:56 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ppHxp-000mXs-4R for pgsql-bugs@lists.postgresql.org; Thu, 20 Apr 2023 00:15:55 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 935CB5C01F6; Wed, 19 Apr 2023 20:15:50 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 19 Apr 2023 20:15:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1681949750; x=1682036150; bh=F9 xiwD7HQ3XQWkbo5+NFRrryaLngg6S1RVSpYynR+BA=; b=xA2pneFzUx5VbjWbgk D5xAJoWlt+e0KWpeMQulCRGaWhBZL4zBcMuzzhPWNDHVsolxfK+/RyI3fm0/7D2h cTElbfFYux3SaEAQnzKml7EzMAjHeJ2bn7y+MhvneHKIGKUkGA3LsXR+AKoxWyhL IJMjVnRgh4oWHNS70YuByWew+KjTXO7rFdn5jsLSsPv9eHj9GJhIm4EjYSG9p+Oo 2XX9FYWVY+8/59+z2mKNyzYTvKCu2BnQW9lmoJsKpTi2KRztfiDHoERyCYuaMoOL 1QtISvty5Ua7pSOiv7Gw7G4lKHfA51UR/WDK0YMtt7ToRLrsWznTRvkg4qochvx2 fXsw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1681949750; x=1682036150; bh=F9xiwD7HQ3XQW kbo5+NFRrryaLngg6S1RVSpYynR+BA=; b=KeQZFue4e+iK0yI/XU5TRO4lcy0CN ATsc/iIk764zvl9BKSaig49TrDQvIuyGcfyd8ASkFzrJ82fPBWDKz+BlRRh40n7w ZGoRGvGx/7yPr62H7XgWaHndKRoEcbYzYjMW+zTGDsxr1KqVuFLbSXGbZ/jMu9I/ /tfftEqpoKDYKb89dXOPgDVc45sJHXogTp5W6Wr0rgVE37eIp6G9uVXDfpa3oCzg gvm4BmO1vcds2IXhylv7hTFwfxfno0VW2mMWIbGcXM/Td8y3YIRpsLOLF/LfWh3p dFHV1W8jy1fZmo4crkEvMPd/401VFRtQZ7mRcpwDrmtSZpCHt0qzz2iiQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfedtuddgfedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeg geegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 19 Apr 2023 20:15:47 -0400 (EDT) Date: Thu, 20 Apr 2023 09:15:41 +0900 From: Michael Paquier To: Tom Lane Cc: Tobias Bussmann , Mark Guertin , pgsql-bugs@lists.postgresql.org Subject: Re: pg_basebackup: errors on macOS on directories with ".DS_Store" files Message-ID: References: <794684A8-D3FF-4109-815F-C9EB66AF65EA@gmx.net> <3000521.1681928151@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="p7ePVmHMQGihMHZo" Content-Disposition: inline In-Reply-To: <3000521.1681928151@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --p7ePVmHMQGihMHZo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Apr 19, 2023 at 02:15:51PM -0400, Tom Lane wrote: > Yeah. I wonder if we ought to do something more general, and > ignore all files whose names start with ".". Indeed. I don't see any point is adding hidden files for the checksum, rewind and base backup lists, so we could just make it a hardcoded rule. That's currently what we do for configuration files when using include_dir for postgresql.conf (as well as hba and ident files in 16~). -- Michael --p7ePVmHMQGihMHZo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmRAhC0ACgkQnvQgOdby QH1TNQ//TshreT4XH2fClUNf6cA2NnB+UxK49z4dvmNw61fDFYIZ/9lJasPIhYsI Dt5hzKZ1fdBO0ki9ts3Gsgr3DsxLNqB9xAr3PbtwZkustKDP8H6hkLfuRf2iHvW2 HlNPeMq1fJKW+oCnK9QpPdIvO5Rok0uhxTOSS1DUaIVZ1ihjsK62hUV2r2aLUwNm XVngfmFmOaBrrC/dd0LG2RluZAMFyXKjkiMiEl3KNLjb8YDmMfLvca3FQ3un/KHY 52OivYL4xVWrdyR0wGefRmHydUUD2haC1iD+vmHO0quZam4gonqJXYCnSo+mu0WS ixVqfb42Juo9t3Di9goz6d1ruV4bqFdcRzuCBc8aJDuCSKLcP0lrD+j2Vf8urlW0 rBxddJ0l5qQT0lPjXOTf2HqTgL9RrH0zVg7OE9L6V/s7paha46juUyw85koHts8o Yq2DzgNpt7Z9E6VFUoSbMNAmi95mrC3/Rakm5L74G/9ZSHYVwVBhBEs9ysbyk778 eDhCBzqtNTBgZfMakOtyaocIzIlMpok+huPSnOnMWN8624UbbNeJHlFJCyS8pPWG X/Vy1I23qnZdwS68OC0o9NLJCU3+wYA9o7LW4BQhIPKaDuYdhKC+lBkJSrfjbi39 PdYPm7rMnkkFjPi4QMtPbhNQA52wmPudVdpZ/cgmBTYyu6/TzVQ= =goYs -----END PGP SIGNATURE----- --p7ePVmHMQGihMHZo--