Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 21 Apr 2023 07:33:09 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Tobias Bussmann <t.bussmann@gmx.net>, Tom Lane <tgl@sss.pgh.pa.us>,
	Mark Guertin <markguertin@gmail.com>,
	pgsql-bugs@lists.postgresql.org
Subject: Re: pg_basebackup: errors on macOS on directories with ".DS_Store"
 files
Message-ID: <ZEG9pTrrb5fdqRpS@paquier.xyz>
References: <E258CE50-AB0E-455D-8AAD-BB4FE8F882FB@gmail.com>
 <794684A8-D3FF-4109-815F-C9EB66AF65EA@gmx.net>
 <3000521.1681928151@sss.pgh.pa.us>
 <ZECELdGIt2xGSWte@paquier.xyz>
 <5781DAEE-66E2-41F5-BE03-E82C729F1340@yesql.se>
 <CDA8E1B5-C146-4954-867A-AF5A4B9E9C43@gmx.net>
 <D816AB75-034A-4FF8-AF14-7AEAE61176C4@yesql.se>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="i4XK/57hqf43pV31"
Content-Disposition: inline
In-Reply-To: <D816AB75-034A-4FF8-AF14-7AEAE61176C4@yesql.se>
Archived-At: 
 <https://www.postgresql.org/message-id/ZEG9pTrrb5fdqRpS%40paquier.xyz>
Precedence: bulk


--i4XK/57hqf43pV31
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Apr 20, 2023 at 01:15:40PM +0200, Daniel Gustafsson wrote:
> Maybe.  I'm a bit hesitant to add too many smarts to pg_rewind.  It's a tool
> for when something has gone wrong with a cluster (albeit probably not at the
> filesystem level), and at that point I feel it's better to put the user fully
> in charge. Perhaps I'm overly cautious, curious to hear from others.

Hmm.  pg_rewind is mostly a differential block-level backup tool, so
applying the same rules everywhere across the board would be sensible
here.  See that exclude_list_item is able to handle prefixes, and we
may want to extend the same logic for the directory list, as well..

By the way, the patch ought to add some tests?  For pg_basebackup,
this would be around "These files should not be copied" in
010_pg_basebackup.pl.  pg_checksums has also its own checks in
002_actions.pl.
--
Michael

--i4XK/57hqf43pV31
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmRBvaUACgkQnvQgOdby
QH141A//UmdG6O4f9g3tYn38FBAthYbavAEat2aMRZxfhAJqfCebYHjlXkbgwG+L
wkup5/mnoUW+vUXCMNPOHxwh0YgnuoKYSZDKbX0CaECA/R4zSk6s765tS74iFy2k
RAsFQhuPzsK9BFodPqWC9NJwgllsZ0wzDnN0Xxv+qtbAcUJHJO94OPp/77e4PSXa
v8brAtynaDabNOYbv5lj1+ylK+tU1buE+Nl2E0JmRfy1chxO11aPWe5D6BLPytwj
xAPYX9QNb70uRz11DTYuDLJmbW7FrgmoTlR+/2MoxAOG6wgVIfW81K5RXufQnrN2
BmWND8NN0Ug9mNWEDdFesW37OvNUZURvMVr6oEdY0tqmaAWsvW9AZEPEqsy3sAIN
j6qq81CFJ82KgSAswD0rgHGJuHAG91qf+WHCaRtudt3P/qaf5rF+MOIbv918ld8P
gRXRlSLOm83uyxPXlc0X3rVmmg82CZybN4mjElvMjHRzpWb+ZYu/msYrPrf3QXp0
F8qGKJU/+fpgWjs5bNwRLy6rhua5FLChVFGUqzxJsf+8oKppOYP+8Qj8QfUSPxui
uvwOya0CPJMK+l5RD1uw5iZo6PxGgkwgOwCW7lhl99Lbimcuwgr/9JVM2L4LhgrO
ZWWBgk05caE5KMn+Izzb8/ecMduJ+L8JZDUjqtlm/wWsucZwZgQ=
=4ozn
-----END PGP SIGNATURE-----

--i4XK/57hqf43pV31--