Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 28 Apr 2023 14:32:52 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, t.bussmann@gmx.net,
	tgl@sss.pgh.pa.us, markguertin@gmail.com,
	pgsql-bugs@lists.postgresql.org
Subject: Re: pg_basebackup: errors on macOS on directories with ".DS_Store"
 files
Message-ID: <ZEtahOGT60kql/rS@paquier.xyz>
References: <CDA8E1B5-C146-4954-867A-AF5A4B9E9C43@gmx.net>
 <D816AB75-034A-4FF8-AF14-7AEAE61176C4@yesql.se>
 <ZEG9pTrrb5fdqRpS@paquier.xyz>
 <20230421.120220.1132981318960692233.horikyota.ntt@gmail.com>
 <7B26A7F6-375B-451A-8B6B-FD1CCA23FFEE@yesql.se>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="FkFMARcQYNMBu8Vl"
Content-Disposition: inline
In-Reply-To: <7B26A7F6-375B-451A-8B6B-FD1CCA23FFEE@yesql.se>
Archived-At: 
 <https://www.postgresql.org/message-id/ZEtahOGT60kql/rS%40paquier.xyz>
Precedence: bulk


--FkFMARcQYNMBu8Vl
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Apr 27, 2023 at 04:22:08PM +0200, Daniel Gustafsson wrote:
> I'm not sure I follow.  While "." and ".." and hidden files share a leading '.'
> character they are vastly different and combining them in the same check would
> trade lines of code for readability.  I'm not sure that's a net win.  If you
> mean that the checks should be reordered such that hidden files are checked for
> before "pgsql_tmp", then that seems equally arbitrary no?  There is no reason
> to believe that hidden files would be more frequently found than "pgsql_tmp
> files.  I don't have strong opinions on the order, I'm just not sure either is
> better than the other.

FWIW, I don't have an issue with the order of the checks as presented
in v2.

> The commit message for 6ad8ac60262 doesn't explain why pgsql_tmp was left out
> of the excludeFiles table, but my guess is that it's either an optimization or
> a deliberate choice to not DEBUG1 log skipping temporary files.  I didn't go
> digging in the archives to find the corresponding thread but there might be
> clues to be had there.

FWIW, here is the thread:
https://www.postgresql.org/message-id/CAB7nPqSNFm2Lz6jASj1RGvAdod1W8ZmHfvML3M7gDnBQ3x6QMw@mail.gmail.com

I think that you're right, the idea is to avoid the random noise
caused by these temp files and their names.  This elog has been useful
for debugging in the past for the fixed entries, at least for me.

While on it, it strikes me that we should have a check on
PG_TEMP_FILES_DIR in basebackup.c's sendDir()?  Okay, that's the same
as PG_TEMP_FILE_PREFIX, but pg_checksums and pg_rewind check for
*both* patterns so that feels inconsistent to me.  This should not be
in excludeDirContents, because we don't want an empty folder in this
case.
--
Michael

--FkFMARcQYNMBu8Vl
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmRLWoMACgkQnvQgOdby
QH3JnQ/8D/WxDOncBl3kmEyfPWDvqcjAdMffdhOhqLgUUv6QCNWyc1LMsaOWoQbu
IxWPa1x/qbuGLaoXgPe4drU/XAyg3Izq1qImUPras8k/Gs8HmAxzTuQdwSfGvQt2
oXHCsQIcSKTK5kGU0wX9yWZx8690ERIPtwBgMczq6CwUP0F0IRjj3VkVaIIZfuf0
daf/RkA84x/XgL66v1eMF5fr0HyxYjywrlrvR6i2dZeHDuU8qjdxWVy4x2AkJ/jo
9ENlalAuX90qkX90Z0VnzQAv0852tVrsd0elAnP6ZGVMMRwcJG+I210c8smycD1B
AeDGc+rXEUXD6HO4PIhwdONQCczQsna1kZh5JXUbdQtU3Pyk7KutOLqLa9VNzaEs
HgFJL3KzAlZYijSg1m1G07uQ9sgt4nziYreaV+doDxQC9hKllpSMhWr6+USa0q8A
1W5p+Ggm63xjYeuGJyefDF7NI8CwBIL7c5/JMj0+C7cWENAcw/FS10OyyxdJTSob
CSUCqUoH7yBkZR/ITMFDsEQxIN60ZSF4kzosuIqjc5KFvbeaifKY41DWVTHZXhL4
caz4lmmjN2eN2p6+a3xVT4/e0nw5DRYevMi5F4lfVbduCoCKmlC5GEHXVO62HHLR
etF3SnbQ4GEODe+/CuQuocvVc27sIVtUZaGR7MxHOnY+fTE7pXI=
=PRXt
-----END PGP SIGNATURE-----

--FkFMARcQYNMBu8Vl--