Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1psHuB-0004kB-J1 for pgsql-bugs@arkaria.postgresql.org; Fri, 28 Apr 2023 06:48:32 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1psHuA-00045q-7q for pgsql-bugs@arkaria.postgresql.org; Fri, 28 Apr 2023 06:48:30 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1psHu8-00043s-Mv for pgsql-bugs@lists.postgresql.org; Fri, 28 Apr 2023 06:48:29 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1psHu5-002JVI-En for pgsql-bugs@lists.postgresql.org; Fri, 28 Apr 2023 06:48:27 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 37D385C0103; Fri, 28 Apr 2023 02:48:24 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 28 Apr 2023 02:48:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1682664504; x=1682750904; bh=5c NT9w0KRZMXsngO37U0fvav7RUaZZRzeuAOeXgNPbw=; b=PSxePg3iNKrDa+YJRe UCv03E5wrJDG1OSGYd8qoxURQ8pZYVb8REfwj1mwTYk2F79vAxcRpYFwJrN9AnpH n4CRP/4X6AMx8sXL3VQCn0iXz/KYqgmsovURvmWR57C6J72C1obkvyj8NgHJ+vc9 +Ost7OcH5nl9z6a6N/0c8sZZVE6ow3esMFkY/HRfXsyZyw08uMs+RrV2xNWvOAsw wfoKAVCh2p/IFfbOOv93FC3AVXSht5MVHFX/sjkVXrYp/XaM6Os7bGMYGB8/Zg+T LXwUjy6ccvDo7TMJNpvej3UOPzRT99iRxaRV7QtUcQUbbzye80s0B/hpViZrnfdo Slbg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1682664504; x=1682750904; bh=5cNT9w0KRZMXs ngO37U0fvav7RUaZZRzeuAOeXgNPbw=; b=fABoDo0FtMd340t4fMW7sHeRh/y2M fAAC5ZvE/atZUAxG2aPWrShE38bV3KhKOm6tAoGW0AluxahT3syQ7HOcji3yVWld B6PWFKOzMg1C65f+EnTHeeSg003ZmxidH7xee1zvChTGOVkIHVFWqVYzaYM2+/8a 5bKxnnBBVeyw23uA0tfdBqYDKVcxrX1owuc98O0T9mtWZaF7t3z5B4gXTa8LLRsB yD+9jIXe7n7kKwqBF2/3cNAzC7wpRITASslkEG/RrUfeOav31HNGiuE44kimiiLj XhQs2ZRrhfUtnZ/8rSqRqKjFC+BBefScuIWF6SLzgWSSoPrWEgVoS+1mw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfedujedguddugecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecufghrlhcuvffnffculdejtddmnecujfgurhepff fhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofhitghhrggvlhcurfgr qhhuihgvrhcuoehmihgthhgrvghlsehprghquhhivghrrdighiiiqeenucggtffrrghtth gvrhhnpeetleeifedufffhhfdtteelgeeggeffhfekueevteeigfduudevudetgfegiedv jeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmih gthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 28 Apr 2023 02:48:21 -0400 (EDT) Date: Fri, 28 Apr 2023 15:48:16 +0900 From: Michael Paquier To: Kyotaro Horiguchi Cc: exclusion@gmail.com, pgsql-bugs@lists.postgresql.org Subject: Re: BUG #17804: Assertion failed in pg_stat after fetching from pg_stat_database and switching cache->snapshot Message-ID: References: <20230428.104100.1566874883906441360.horikyota.ntt@gmail.com> <0d45c9c1-17a1-932f-3925-86484f150c94@gmail.com> <20230428.150404.2168290194163999912.horikyota.ntt@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="qqkxVo9ViBVT1nc1" Content-Disposition: inline In-Reply-To: <20230428.150404.2168290194163999912.horikyota.ntt@gmail.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --qqkxVo9ViBVT1nc1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Apr 28, 2023 at 03:04:04PM +0900, Kyotaro Horiguchi wrote: > Just I wanted not to do that much in the guc callback including memory > context operations. If it is compeltly safe, I don't object just > clearing snapshots in the callback. I vaguely recalled some memory context deletions done in one of the assign callbacks, like the one for the plan resets, but it doesn't seem to be the case, looking closely.. Hm. -- Michael --qqkxVo9ViBVT1nc1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmRLbC8ACgkQnvQgOdby QH1Rpg//bCsSwjMH1egEmqy9jrCqJDoAIG/ZhIRy+7Kn3f8iaX9uj4oBubiAQRvR nsVCQkDRGxG3Svj23vhl5VKR5+BaOmGV+JODdq2D4CdiVeB0Uuvyjts8iQtS1mFJ c4Vb5R/SYfUxbWs9lD259Lyb9+I6e/DjzBZKs+4P2Pt0MFhqy49c54VEvi1s+3W2 gRPtb/1vqgrAavCDtWrXqgxjgaawUKC3vV1XjyNJOj1zBsGwA+IvlfxXaUaHnE8e P7D6Sqi4TlFVvQW9Q7RCc0r5aDGvYfuSGnMG0cOM0NXLTVd1CJvN5YI1nlYvHSo6 0Whb7oTddmVstQkzJR0k30JMrkvH4wGs5UYlKVWGRF83itoG7PkVyKvfqoTci0mU uKSHPjLpA7cQHRpAzsvHNHBCdNkJ9mzm5BYIj5Ea08FWcj9c2MM2zsLbLgQb1VCs p88S5I7L8X2ToA4PyMoEhLPt/mkMZAdfjxK8VMhRzKwukfbQfd2ryhmuPKnb4Ptq o7ge1L2Go9BHi9JhSUg823xYMtHLDfDMJWRUCfngVhyCgXUHBeDIZDTCCFZaGNBB tmQb/yz/E1iB8bXqZ/R+FdF4fEF83PEADt4J1Msu/qjWfm+oYeLx2P3iZk9GD6Tu QSR1lNeO2vdyW61buELjbyv2xsXfuNK21vWCOoSwVsGfV5XwCOo= =cfRj -----END PGP SIGNATURE----- --qqkxVo9ViBVT1nc1--