Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q25fe-0007fA-40 for pgsql-bugs@arkaria.postgresql.org; Thu, 25 May 2023 07:46:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1q25fc-00076a-JK for pgsql-bugs@arkaria.postgresql.org; Thu, 25 May 2023 07:46:00 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q25fc-00076R-Ap for pgsql-bugs@lists.postgresql.org; Thu, 25 May 2023 07:46:00 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q25fY-0021xP-Ux for pgsql-bugs@lists.postgresql.org; Thu, 25 May 2023 07:45:59 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id AB1F15C039C; Thu, 25 May 2023 03:45:56 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 25 May 2023 03:45:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1685000756; x=1685087156; bh=2u d0T60jrBVNtMC+QvKg0M6g7+aYkkXrD0yFEnp57AE=; b=jBD7GvjGcX1aneuPBt WzyYQchV+NFy+KNTIsi7HjDsTh3g1SDnNqojPIlzswR+XqlcmvB8bmjM/wC4E8tM O+XalRZvO5Q8fn5PISBXKntNovcpZndwy4S4yBV79iORBM8k3VwGelA70M1OFaiT XX1milgbL7ennbbPMwZNlMP3c+ieQNA07+gS1VFYmPQeVJXv+BJgEYmKSLBdF0g/ A1Z0I1CFg+9Er2S/4c7Qewm0agypoCqooKFzzsyk8RhfAP9h3pVsuciID6rcdUdk 6zfOF3UK+FBJ/JufBS2/Xck82ZqNWjZ9wBP36acIdGVx0QxNFUemweU1GO9C/rdX VgiQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1685000756; x=1685087156; bh=2ud0T60jrBVNt MC+QvKg0M6g7+aYkkXrD0yFEnp57AE=; b=hMle2v1XmtLYK75Q/WYWll/Ntvece a3wG8iWtPbftT7nzZak5fT8NzdSybEddNHXUX/lHgidZNZ5xvTaH8I4TuXiyWErW kRI/x8LHbj/O8b/MMZfVDjiedoYLvRKvZLPhAMLkktCh4oro8e1EsP5ejzX7ggEg WOAJ28xgSZu8xj+gOkmYKpJ5dCsCiF83dXkK6Ome6X2y5wV07NaA/82wXRXX8DTo ZhU+j0oaoE5TmKuPIxYVJmG+K3Q209T2CTYtkjKGgRkUJmyw5m6N1msW+qJ8LK12 WWyTjIwiGkbYf+rPjPhIi/NYARWTsb+kLqXCbYcZaEopfjMASsg+4a0JA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeejiedguddvvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecufghrlhcuvffnffculdejtddmnecujfgurhepff fhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofhitghhrggvlhcurfgr qhhuihgvrhcuoehmihgthhgrvghlsehprghquhhivghrrdighiiiqeenucggtffrrghtth gvrhhnpeetleeifedufffhhfdtteelgeeggeffhfekueevteeigfduudevudetgfegiedv jeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmih gthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 25 May 2023 03:45:53 -0400 (EDT) Date: Thu, 25 May 2023 16:45:50 +0900 From: Michael Paquier To: Kyotaro Horiguchi Cc: henri.chapelle@dbandmore.com, pgsql-bugs@lists.postgresql.org Subject: Re: BUG #17942: vacuumdb doesn't populate extended statistics on partitioned tables Message-ID: References: <17942-50aa28accc2e412c@postgresql.org> <20230525.130759.1771148055252912581.horikyota.ntt@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="YXEA8bJOQxJibDrO" Content-Disposition: inline In-Reply-To: <20230525.130759.1771148055252912581.horikyota.ntt@gmail.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --YXEA8bJOQxJibDrO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, May 25, 2023 at 01:07:59PM +0900, Kyotaro Horiguchi wrote: > ANALYZE processes inhertance parents. By a quick search, I found > that commit 3c3bb99330 modified get_rel_oids (which has now been > relocated to get_all_vacuum_rels) to include > RELKIND_PARTITIONED_TABLE. However, it seems like it overlooked > updating the same in vacuumdb.c. This dates back to 10. You cannot do that, because this would make a single run of vacuumdb process more than once each partition. Am I missing something? -- Michael --YXEA8bJOQxJibDrO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmRvEi4ACgkQnvQgOdby QH0IiRAAgA11MHWf7Ji6D3zEaLn/HvZv4ekg3hHoRy22T7IajYzCQrkMIWnGA6IK wBEvOqRJRb3DyxNxkRGiusvrjp9V0dfpaPxFt8h1CKB17jIXv4PhH3bvkTYYZRWu /gK9g29XkPKzn1mQsgNtrECsWD18sGBJJzF60H4x6oTCf4AJ0ZRMD+xRFxWiWgeE fhgkXOa5JhhvjaK4qfI4tbRklg3Snk/xv+wp0AGKHX7uZa0qpj2kdJSIgnFW6daY AmXgDYJggXSzGCo2yFw/RvVtpGIu6rr+aP3llSory9Vi/DT2YrUDwlMBVyqWiLbd waeAJtfiMBxks5WRgfOMZGadJnPGxVFcfU9BwRF7e9Fka8FdW6RsWigd/zkM7fWW KIYTuw8OYB329LGk5IjYoklbe4VpTYfVQgmv7xb52mR9HSkN6dYG6YBwi2YygajX ZDKpHNNsVHtbq0c4ygea3g5g7CIDhGxSQSOIe4Ow8ra9LK4aqJq7FJhdScMctVLt PbMIpPc+nqNz62tpcvd6VrgDop7UtSVrPQs3CMfBXZgs3JPkWFtPAjv8rWP93qHH qO0N2VLUiHyqVbRayRyTuP3PPqDbnxWM1u5AUM15EYZKeBAgzGTcikyh0cK8SOt0 OMv7n6BE6jhBaxaCkdMfCYX/EUtjban4pVRhYt780SWzKjQXb7M= =XSBw -----END PGP SIGNATURE----- --YXEA8bJOQxJibDrO--