Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 19 May 2023 14:41:22 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Alexander Lakhin <exclusion@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org, Andrey Borodin <amborodin86@gmail.com>
Subject: Re: BUG #17884: gist_page_items() crashes for a non-leaf page of an
 index with non-key columns
Message-ID: <ZGcMAtZiHe2EUllk@paquier.xyz>
References: <17884-cb8c326522977acb@postgresql.org>
 <92873f8d-a9b1-0ee8-5753-ee4a1664fb0e@gmail.com>
 <ZGF/qgICp6JvNDhV@paquier.xyz>
 <8a991814-97c0-81d6-1e24-60c26308f005@gmail.com>
 <ZGRk3LVBpt9/dFlt@paquier.xyz>
 <e4c9897a-6864-4c47-f7ea-08385f2a7db5@gmail.com>
 <ZGWEZCN0PpfFona0@paquier.xyz>
 <ZGWjHcBJoOPIbzYY@paquier.xyz>
 <457826a7-95a6-96ae-dabc-6e07d8020a7b@gmail.com>
 <ZGXQyOYez0lWgBwL@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="fCiIHDKlKyiZUXsw"
Content-Disposition: inline
In-Reply-To: <ZGXQyOYez0lWgBwL@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/ZGcMAtZiHe2EUllk%40paquier.xyz>
Precedence: bulk


--fCiIHDKlKyiZUXsw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, May 18, 2023 at 04:16:24PM +0900, Michael Paquier wrote:
> The format output could be tweaked forever, so if there are arguments
> for more improvements, we could always discuss that later as adapted
> and the tests will be here to provide coverage.  I am planning to
> apply and backpatch that down to v14 tomorrow.

Well, I have woken up on this one and using parentheses was still
confusing when I attached composite types into the INCLUDE clause, so
I have looked again at record_out() and hstore, and noted that the
part where we apply the double quotes to the values is actually ~15
lines.  With that, it is easily possible to apply it to all the
values, giving a representation close to how rows display for a nice
result.

So, at the end, I have used that, reduced a bit the scope of the
tests, and applied the result down to 14.  Note the trick with
regexp_replace() to avoid some issues I noticed with alignment when
using -m32 for the non-leaf page when using INCLUDE.  The
documentation needed also a refresh to show the new output generated.
--
Michael

--fCiIHDKlKyiZUXsw
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmRnDAIACgkQnvQgOdby
QH1QvQ/+Ka5TxXmUFf27dEJiOvaoTxxNhmIiFLhO3o3VmHRc6htWGy7YUvnv4YON
ttBAVp6s37CPGkezNAOS6rZDN77QKGKcgfHXfPX0DDywGobNeDRUlKggu5rz0inC
BYpJXjQ+dgOtqaPZdqlPtx0NgyV1Vxdf/CeUJqcJch6xnINJrSMcfPuSUF7jiQAQ
eomxNGvGy1FwfavunGSl42UybHYOPfGC0sroc41Kn3Bm9/fq9eOdmzXCnjL1rkGf
rOkQCxNZpaoKbwZTKZqKiq+WBhp3d36Vr+WRFMejBcdKO6O2Qub9LWQ3CW4F5E8x
ZUM8KevAzov7WncO1s+OPocwY72ypZjxwPwqiI2Bz4oGL0NAN7BkxposZX9fNCUZ
L9ISL05fS4odkUKoXBc2lEud4pHsisUy6RFSPvR624OIdfL3ycjgeBPQn6Aix4zZ
+BmlHj/reUjglA2KMy5ga00uDbgPmzljRdRx7NUmIzkP37iXsbANpXV99HNILyIY
EH5/ZRkqI+kY0YpDty6rvpb+lj96nd2J8n5vA4EZkSzWywXJXKkmzbscjHVbbu50
rdS4Z3mBfKkwCGTuR4TfmhOJMukxuNR3TNcbzhAG38KCWpH8mTp6YFikKl3gD+sO
U0wAMFf34MqM7pVcwaVwGFpSfRQEFiC7d8THeyrdsR98ssufl4g=
=Auib
-----END PGP SIGNATURE-----

--fCiIHDKlKyiZUXsw--