Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 16 Jun 2023 14:29:41 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Jeff Davis <pgsql@j-davis.com>
Cc: pgsql-bugs@postgresql.org
Subject: Re: pg_dump assertion failure with "-n pg_catalog"
Message-ID: <ZIvzRTPWILVZ2Z5b@paquier.xyz>
References: <ce071503fee88334aa70f360e6e4ea14d48305ee.camel@j-davis.com>
 <ZIbAuHfnWY05VxVt@paquier.xyz>
 <e7c1adfe66542eca348de7485990abfabdbc1086.camel@j-davis.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="CB6hgwPA0bNxCk82"
Content-Disposition: inline
In-Reply-To: <e7c1adfe66542eca348de7485990abfabdbc1086.camel@j-davis.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ZIvzRTPWILVZ2Z5b%40paquier.xyz>
Precedence: bulk


--CB6hgwPA0bNxCk82
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Jun 15, 2023 at 03:47:59PM -0700, Jeff Davis wrote:
> The new patch does add about 40 net lines, though.

I have looked at dumps generated from servers down to 9.2, and these
seemed OK.

> Given that it fixes an obscure issue, I'm not even sure if it should be
> backported -- perhaps it could just go in 17 as more of a cleanup than
> a bugfix?

Not sure to agree about this point.  The first version where this
happens is v15, meaning that two branches are impacted currently.  So
the cost of backpatch is minimal.

> Even aside from the issue fixed by this patch, there are other warnings
> emitted when dumping pg_catalog related to types with typtype='p' and
> typisdefined=t.

Right, there are 14 of them, except _record.  This is actually much,
much older than the collation bits.
--
Michael

--CB6hgwPA0bNxCk82
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmSL80UACgkQnvQgOdby
QH0o6w/+PVDqXf+luqXAmd2U9T9bfaUcsYIl2lnsnwrJsBdsiKqrrVqyn0cU5ZmY
3T2KxluFp0w8TjAPf6lhpA9PG38ArH9/DoPFS+LsDRDmhe6EFEnESaDLHROxjqRP
5AZ9OfVi5x9N5Ov03zVy8AyQnY9ru5v7WfucvXLAY+QSJPgZbU/ibITFIpd9bEPW
YYz6guHreh8j260lq+qUfP4TcNuTfF+i9BZej9/+2HxLmz+bgHYhG9R21aCPwY7i
AG+/afGxCDK/Yg1TNnevV8nOPNMm0jep6FbXjF6HyG9XEf+iaR9BXa5PdjgDUyjy
Ab0G2w3tlutN5476v9Ky3Kvtwh2VJOExDzAEdjITEbeDBauc2L71bwNvBrxA4aYk
aP1GNfi4DQuJ8ppg5o5jmHEhhVXdT9T7Fz5PQ98Bz3GtDJb9X9LSyLdoLZVjJ+8J
aTOIeHuvMaVvzMnUtcZNQo2Z7C7XjhyhdKZK6x0XTzUzI0qX5qiMLDO/Mlg3M48D
GGBfjly/HLoI1przPFbbldg6jlYUeeSkbg/BapOLkLrqxMj8rCI+AuXc1JKsYrpg
ruy9fBnTMHQHFZFheNxioHTNoKc0QOeLF0u0yEMxlHbxF+/Mw7GAdHPq1+tr6TLy
kLnkTg0EuOsO11V2JxR38aX2HAopRk4RfpEFjFEckmQi+FHaOlk=
=uNlO
-----END PGP SIGNATURE-----

--CB6hgwPA0bNxCk82--