Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qDeHZ-0004he-0c for pgsql-bugs@arkaria.postgresql.org; Mon, 26 Jun 2023 04:56:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1qDeHX-0003mA-0G for pgsql-bugs@arkaria.postgresql.org; Mon, 26 Jun 2023 04:56:55 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qDeHW-0003iZ-NB for pgsql-bugs@lists.postgresql.org; Mon, 26 Jun 2023 04:56:54 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qDeHT-000W30-NU for pgsql-bugs@lists.postgresql.org; Mon, 26 Jun 2023 04:56:54 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id EC0B85C0088; Mon, 26 Jun 2023 00:56:47 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 26 Jun 2023 00:56:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1687755407; x=1687841807; bh=Ih T4Rd6j9Hb72kZWj3uv51DyVV3A3rt6wctmJBZczOw=; b=om6A4lkDO3+tmAvDtj nxLLZ2NjJal0VijD36ywacEJYtGEor8Lr5/BX8l0xernOL82NinDDbYxcwFJto8+ ctnGtsXcBnefy6vS0fweGSGy+wG/Gr0qZSqt4mDJWrgCFMnZKHnviPV8VHHQFky7 VAQ+N2C/+nLhSq4js/Dn3cihaIRHUDBi8OhmAoD3hfmcQpdtdlxsKCDRCdhr+kg8 RA+G9o7Uj6qllbxEnXaKMEFe/9L8t++Ai69Su5NW+YDdp8YYfyEUkOKyLUiBDuUy wbcAfBT8riyQw60NGH1wTsfyUL4hmosgHXS2KqxppwCOdFOsr6nASue5ziQ7l8A3 CWdQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1687755407; x=1687841807; bh=IhT4Rd6j9Hb72 kZWj3uv51DyVV3A3rt6wctmJBZczOw=; b=L5oZdgjjRXBGjThdAhJyQClzN8hLJ SkoCJVIhUdVum5hm3XD/ldTYH1NoqytLyyCDab1TYNejFlKJlCdbiu359G/MwI4k 9XcIcBOcC5XpQIHX2awxpu1C8CDvqIqpwIgBI+Q7XtEeQ1UpXBjFgqieywHoZmsE cKnDp/S8zmuKFg/wNWTVUQInboUglOdlkk1vqu30tSiVkZ4SAL0mehR5ZSEmf1yL 86VW8Cxrm9UduCQ3D66mRS80uLaaFYAzzgKr5zVxIxEbtVNk1o2RUcEse0YfG11w j+x9bb6Aejo3/659JGqQOSMHSiYEuHDSQa0KPk0ahQsPwyLtO/4jZiwRw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeehvddggeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucgfrhhlucfvnfffucdljedtmdenucfjughrpeffhf fvvefukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfrrghq uhhivghruceomhhitghhrggvlhesphgrqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvg hrnhepteelieefudffhffhtdetleeggeegfffhkeeuveetiefgudduvedutefggeeivdej necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhhitg hhrggvlhesphgrqhhuihgvrhdrgiihii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 26 Jun 2023 00:56:45 -0400 (EDT) Date: Mon, 26 Jun 2023 13:56:42 +0900 From: Michael Paquier To: Tom Lane Cc: Alexander Lakhin , zuming.jiang@inf.ethz.ch, pgsql-bugs@lists.postgresql.org Subject: Re: BUG #17995: Segmentation fault caused by UPDATE statement Message-ID: References: <17995-9f20ff3e6389db4c@postgresql.org> <285547.1687636319@sss.pgh.pa.us> <68148dac-a574-f421-2905-51ebde2fe000@gmail.com> <636983.1687753628@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="8VOnHYK4j0WOQ4EI" Content-Disposition: inline In-Reply-To: <636983.1687753628@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --8VOnHYK4j0WOQ4EI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 26, 2023 at 12:27:08AM -0400, Tom Lane wrote: > Michael Paquier writes: >> Thanks for the pointer, I'll double-check that. Some of the locations >> of stack depth checks proposed involve performance-sensitive code >> paths, though, like mcxt.c :/ >=20 > I hadn't looked at the patch yet, but ... mcxt.c? How is that recursive? > Even if there is some path that recurses through that, wouldn't the > check be better placed in a less-hot part of the loop? Yeah, that's my impression. I'll switch to the other thread after looking more in details. -- Michael --8VOnHYK4j0WOQ4EI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmSZGooACgkQnvQgOdby QH0fpRAAgvH8bpmlniR46IsuXMYTYMD/Dlw5XzRnGbEXlKZN1+743/W6dF3x5Hw2 TPqQM5bD7Mgy7WLjid+RgmKQPyAkkwswtauaG0em5loGyCdGJ98hSDXKXUDTjdiU Cv5cNlt23QQguPoVP2jwk8okQKJDpoBx0b6ApWxVPDxyxLTIjtsrJrjZ8A8I3kWu I/dlfL3rtGuwNG5vtCRoPcO0uqx0WLijccsDoSmIIzX8XitGeXtO9/xaTMooBbPN 65NiRfNWkdFrL0CzLMEXEn9aDYS7Z6WN1qmAUnbVp5qUiF1u4bRZkn30b/LPuCpf x0a9/1cLL7FMH9gFJ0KmaALCN6dWYYwE/Tisq1dDPrphtdH9Nkj84lt9bbHl016C QoXVQYN1qbIURzhbC2b0mikw2HtctAeK9FrciMqNcNOkIeLOkrwLpUeSw2N4ayu8 8zuM6fqiZNfY/BxdvItipocOf+Buv35HCEN8fKan5wWIRl1gv+vZUK9TRTbHiZNr BMzREEYsAHHoNdExjIOr5R1N2TNDmbRjINXGFYK2gz3kq7/ibhCyUo40U3e6tOxl +Dqi2D4mj8B/q6EQo1q21O1ifExkDzlye/j6I/9yAYg4TvlOSsOWM9Y3dmsCt2Am q1SaCBGlIwb+yVRGdKhnOJ3k0Nnmyc8C/e1KoaUdow+b6PWmvPE= =A47j -----END PGP SIGNATURE----- --8VOnHYK4j0WOQ4EI--