Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qEHy8-00025N-Si for pgsql-bugs@arkaria.postgresql.org; Tue, 27 Jun 2023 23:19:32 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1qEHy7-0006Ek-7m for pgsql-bugs@arkaria.postgresql.org; Tue, 27 Jun 2023 23:19:31 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qEHy6-0006Dt-VA for pgsql-bugs@lists.postgresql.org; Tue, 27 Jun 2023 23:19:30 +0000 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qEHy0-000rc4-6p for pgsql-bugs@lists.postgresql.org; Tue, 27 Jun 2023 23:19:30 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 6EA3C32002FB; Tue, 27 Jun 2023 19:19:22 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 27 Jun 2023 19:19:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1687907962; x=1687994362; bh=tx 7e+iDJexdygBm2Ti8Fbp35lJSp8Dc86VyooxB0tQ4=; b=TluuOWvj/8q7acbVPy sYEWt1ykDjg7pe/JidStCGlDRQP+SQdu0VYx0vYWuBhK0z4PUB1yUxi6S7uqKAkp V+/pqLFKJkW29tj3GmBeHlJMiHrzbsqmiPecdzwh4mB5yCk2+zzEQKvnTPU+PK73 t8vxyaJeJjY9dXfC2D7XdlMJBu0Qjb3Ydw/jaVG1sBNZ7EZ+5eyX9gXGTGX/Ce1m bcsAt/h4I5STZ0CzgTuIVvsH83us+wAOWaWpkIE4S5+3hvHwK8Sk2w5BEF5fsfv7 koQynfQPKYyRiu9Q9EU3/DAql1CeM3RAmVCWT+om8FxhE5hNR3mQXPOLcgOZUgzq aabA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1687907962; x=1687994362; bh=tx7e+iDJexdyg Bm2Ti8Fbp35lJSp8Dc86VyooxB0tQ4=; b=HWWcJn8vsbsqxXa7dLlyNWdBt0aW2 SzyPiAYoCr64P1G5Fm3XujuRutcIHJnlZauVwcwNhOU6z5hxOQ0L0cL3m3cgKhgn y92fzY7LlLHFWfD2CKMc2tYtF4EqjxeCgAlzdAMBRWytsE9m8Hg0If0UC8VO1Vc8 OeLH11io4XvRRKwdZ6w9ejejzaQH4FXfJZ0l+g08p0gBJb5n/iS2t/bSgxLUWKtU jmHkwCH5sfx/VFp91oTHDznv0jNjQYvtHvp6lzBtTYao9grV7r0HjKlrQuyGYP/a 8UujHdCRi+HEPhTU2nG8FpaZ2hoH6DJmqsBNvkKqxPpNxzR53/vXtSMBg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrtddugddvudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepfffhvfevuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpeetleeifedufffhhfdtteelgeeg geffhfekueevteeigfduudevudetgfegiedvjeenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 27 Jun 2023 19:19:19 -0400 (EDT) Date: Wed, 28 Jun 2023 08:19:15 +0900 From: Michael Paquier To: Nathan Bossart Cc: exclusion@gmail.com, pgsql-bugs@lists.postgresql.org Subject: Re: BUG #18000: Access method used by matview can be dropped leaving broken matview Message-ID: References: <18000-9145c25b1af475ca@postgresql.org> <20230627170348.GA1461334@nathanxps13> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rXgyhxxLX7MKskMj" Content-Disposition: inline In-Reply-To: <20230627170348.GA1461334@nathanxps13> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --rXgyhxxLX7MKskMj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 27, 2023 at 10:03:48AM -0700, Nathan Bossart wrote: > I haven't looked at the patch, but assuming it's not calling > finish_heap_swap(), it might be okay. But it does seem prudent to check > that the dependency records are handled correctly. Double-checking, the patch is able to handle that with an extra changeDependencyFor() in a code path for relkinds that have no storage. What the patch does not do it look at pg_depend to see if the dependency records are stored correctly, and that's something it had better do. -- Michael --rXgyhxxLX7MKskMj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmSbbnMACgkQnvQgOdby QH19tg/+I/wPYLZYKgtsiydWjvBQelsABKVasHumaMgrHQUMTuvYcgkH3OmtIffP WnOjiTztIg/cEcbKWg/UwE6HXKkseQzKYSL0XtB8fvyr9Acmi7w1PKeHyW4oi94H bWGt46mXoDI/TYG7v2V05+ajSRaMYv85cRaC1p07QKbWv3XHYz61UwNAiC7O1HBa gqC1/gckcmt9Jlte2xgmoePymVTEIxjSRHBprYHz9/PI1rB1OA0wUnfY8mBh4Op0 RdhOrDxSF1PAld53VNgGMTEZcywxppDnzIevcdXgwANyQ4NLfpHbmfyNh9s/WkWS +bkcWMI97dbIOsV/h+pML+qmVFOxOuQxbFiCOhYn07baMn1MbXYKEwbMtLeP++vw oRsTpHPKkeVLIXAZheFwulnD77eiOQRguWYuUrbmPz1Rei7RLPkgWuP2mtZxKKyA s8uTqshMGP3ttG0uj2j2jtDt2MYQsjns0NVxkFDAuHThYg5UarCtSOOGGaDMc5Mm pQq039pevXytdNw8WmSjourxm0ChR85cUmIQOHTHGR6Yqy79WvZjP2Ybt4KkLoWD IVWxhyaiBNbyK88dO67gGSZKPTWJfoFsBZb08ci4hfpyJnMqCoBPgdERa5VAyYfY CjwEAe27A8MN9b9FdrxHVr4Z6Nsgfv6nfcxUHTVqsRrAOZX+310= =v4GZ -----END PGP SIGNATURE----- --rXgyhxxLX7MKskMj--