Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 26 Jul 2023 12:32:38 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, exclusion@gmail.com,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18014: Releasing catcache entries makes
 schema_to_xmlschema() fail when parallel workers are used
Message-ID: <ZMCT1rszfKIiNLpk@paquier.xyz>
References: <00e24aa6-5d03-99b6-ab41-495a35fc93f6@gmail.com>
 <982076.1689967306@sss.pgh.pa.us>
 <5bd4cbfe-fc71-c576-851d-3bb21ef5c080@gmail.com>
 <20230726.112923.27361680552823861.horikyota.ntt@gmail.com>
 <1821881.1690339317@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="/fwWK64QdYvkXqPN"
Content-Disposition: inline
In-Reply-To: <1821881.1690339317@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/ZMCT1rszfKIiNLpk%40paquier.xyz>
Precedence: bulk


--/fwWK64QdYvkXqPN
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Jul 25, 2023 at 10:41:57PM -0400, Tom Lane wrote:
> As I said earlier, I think that's a purely coincidental "fix" for
> this specific manifestation.  Either SearchSysCacheExists followed
> by a syscache lookup of the same tuple should be considered safe,
> or it shouldn't.  If it should be considered safe, we need to fix the
> cache-clobber test scaffolding to not give a false positive.  While if
> it shouldn't, we need to get rid of that coding pattern, not apply
> high-level band-aids that remove just one particular path to reaching
> the problem.  I'm not dead set on either answer at this point, but
> I think those are the plausible alternatives.

FWIW, I'm having a hard time thinking about a reason that we should
not support SearchSysCacheExists()+lookup to be a valid pattern, even
if the cache is clobbered.  I am pretty sure that there are other code
paths in the tree, not mentioned on this thread, that do exactly that
(haven't checked, but indexcmds.c is one coming in mind).
--
Michael

--/fwWK64QdYvkXqPN
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmTAk9YACgkQnvQgOdby
QH3IVA//VdDRlOQsy8UUdTS662ED2na8eTroXf3NYF8INDRU0bQnGtgJ+qqZ3id9
zj4i3Zrry3q6UbI2qqK78pGhsTw9oSFQz5Jh2guh4uVgXU0mwnuf1+pF9nM+tac2
6juf7XlyJkO7cTiRN/vm1xCIU+5D/vBD6y0obxUCpqi4gR0N7CBWEhpGit/8LKVe
0mGq6ewMWo5vmds4Ss18+PQUdlYHpbphrsrFODDCamoh0PXjM8GK+a0jbP7cziVu
TX5UuYc1Wpu7wgbilcZIUewMlo4pOx641pTFl16uUQdeljLjAYHIbGybVTNOMpsd
VoLtzNWA/Ze6U7YCbhMZXCBRBIjb1F26uQhwHfx78PdWuKaJKojnHpyKjNzLXkn+
v/Ui0MDAjfg4zdLzeWdReHw1Q5emnhlImaowsD+KWmU1UojB4tKo5UTEN7t14ztQ
8/WEeaFVHYUTY43XvsXhIux8/bgplF4rTLf90ptyhbZ1XqOwqGn1rKDPHdVLJFS2
e2Mc2aNJBMfQLxowcqvcnZXGPRq9h+51QHVUs2ATGiJICSOt6IMpJgOoMEMFPees
YnD1gD3SfPEn/R6+i/mQqDM7GDA/38KRO/2D8bn09WXbvbGCvSqw0Z99miFJK7RN
ueAcxxQn8q0usBSYfoz5NxbJz14gaDaU5DZmB80yK6BskxrDaM0=
=PVt6
-----END PGP SIGNATURE-----

--/fwWK64QdYvkXqPN--