Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qc1jb-00Dd9b-Nt for pgsql-bugs@arkaria.postgresql.org; Fri, 01 Sep 2023 10:50:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qc1ja-00DpQv-ES for pgsql-bugs@arkaria.postgresql.org; Fri, 01 Sep 2023 10:50:38 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qc1ja-00DpQk-53 for pgsql-bugs@lists.postgresql.org; Fri, 01 Sep 2023 10:50:37 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qc1jX-002KFy-2o for pgsql-bugs@lists.postgresql.org; Fri, 01 Sep 2023 10:50:37 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 018E85C018E; Fri, 1 Sep 2023 06:50:33 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 01 Sep 2023 06:50:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1693565431; x=1693651831; bh=g7 ot8fVFTbVDqUcXBZxYmSOT3nXBuyyxUQZZH83rLEg=; b=mUGvF8/ZIKewg1r9v/ vf1djLgjIpyh0Sy6ap5EgrMnBXRZ+NkoWr0T0cvIIi4Y3+I/SssNujea8K75WfXW M7xwImYb/S2aNNC9+1PqeTE7d1kZ6pR771Pj4St8wNN4ngsDzFswEBO08badxVkg fgXlamMRKwy2uE/GgQ4vSqUUxNG7X7KwecLZ2oiSu2ss3HejG667R0Lhv9ACnQwq sqDesEzBewL57f9FlXGjNoH4f8O3xpOzP4WDTM52JGrs58hkOB3hjcfcGbI6Xb3Q ylQMuc9fqMN7s/2TU+j2AIFp9KhTSkHMLGQoibJS1aMr6YzN50ZIF5PzChq2nFzJ +Fgg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1693565431; x=1693651831; bh=g7ot8fVFTbVDq UcXBZxYmSOT3nXBuyyxUQZZH83rLEg=; b=cAQZrFPjxUx06wG/YcQ96svsOPruE Q8HhqOWi5Onq5fCqj7W4KcFylx10NvH5Ahc6j/S3jIhy6doDnzFvvhtaIqPgXs++ 0Lbnr7R9ctjs0gSxIU9eW+KJwBcteP2961UXAtBfjKqex9TVcSBZUOAmyJPlsng8 B9TnGL5NO0Smt8EyFKDg8s3Rk2au/D+8VHD9zYbeJVUlNeViwwEnzw45joDBxQ8o O/XWkE3J+1FpKlSHWRVlcRo1jq2zeqZTnkfWFpXGfDmplZvD+mDcrv2My4gzvfRK Y+nb6/5kR6hUhxmh5U9RXdAJL6mtzkvqFWsbsfZbX9JVRBlsv2u6TtmaQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudegvddgfedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddunecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepgfehhefgudefudfgfeelgeei ffegfefhkeefffdvheefuddtheetgeelteevkeetnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 1 Sep 2023 06:50:30 -0400 (EDT) Date: Fri, 1 Sep 2023 19:50:27 +0900 From: Michael Paquier To: Romain =?iso-8859-1?Q?MAZI=C8RE?= Cc: pgsql-bugs@lists.postgresql.org Subject: Re: Error on help in /src/bin/pg_basebackup/pg_basebackup.c Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="WsyTvmPiqHlW5lyt" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --WsyTvmPiqHlW5lyt Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 01, 2023 at 12:34:26PM +0200, Romain MAZI=C8RE wrote: > It seams to be an indentation error in src/bin/pg_basebackup/pg_basebacku= p.c > in the usage function concerning : >=20 > *--waldir* and from *--manifest-checksums* to *--no-verify-checksums*. I am not sure to understand what you mean here. Are you referring to a point of the code in a specific commit and/or version? If possible, could you post a patch to show you idea? The indentation of the output generated seems OK from here. -- Michael --WsyTvmPiqHlW5lyt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmTxwfMACgkQnvQgOdby QH1J3g/9F1qcEw73VtW/O0Q/O9UYvM2KcAW1n1SZ+idc8Wu2vblPOq0rngPlc49o Nc4xovsFSehgcuC00VVuUWXAr+2Y2c1BUtcCK20ieLLdEDz/567cSm4Rdz2Eue9q 0Niqv8MbrVdlhk+r2XcbCMcnaavPBC3wHZPagVkFWPwGlabnkt/ItwNDhuE81Jlr aMjtVhQ6h6UG7K950AA9SO7Wx3hBHnEl9Boy3HUNdELHtjyz3DcrCiZZXLRVbiAY ebvAt2QYwPXk4GoSuVbMuuDX/fO+b3XfSXwFTKgYG8uX0JlkzevS1e0THM3OEa9w rLUmS0XfGDRPGY/upFt8e3BaBCevoBIyuO8Q05KDy2MMqF/HC/g7AxBl0ayzcwqr RYavuEIsybokeKflGTOwINShopmFv5K19ZtTEEte+/Ixp8NSGqk7sKCfhRHPSUxK O268T8jXfaztHgd498kAqkop7w/w/48PuJy4Mzs1CwzF9UM2zFFnTqTP+3SPhYVK 9x4zxfho+YhDB3MLUA6Oel/zJdKiGCJKBGcyOs18Ioek0LJXUlMzS9IdRqNMcK9M IcHk70obFHxbpb6UkzJ81BPUjbmoVV0OpFEmh8yXECqdwyLAUjg+x65vIPO+8+vu AlsIBCSVhXzNM64ZfsFX7wmtcwNQPTxTgAsToiEkU3Ubbp40FSo= =g2/Z -----END PGP SIGNATURE----- --WsyTvmPiqHlW5lyt--