Feedback-ID: i0fe9450f:Fastmail
Date: Sun, 3 Sep 2023 08:42:55 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Sergei Kornilov <sk@zsrv.org>
Cc: Noah Misch <noah@leadboat.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>, exclusion@gmail.com,
	pgsql-bugs@lists.postgresql.org,
	Thomas Munro <thomas.munro@gmail.com>
Subject: Re: BUG #17928: Standby fails to decode WAL on termination of primary
Message-ID: <ZPPIf3Uzp9iFrE6M@paquier.xyz>
References: <ZNrqTmKGnZwz9gPI@paquier.xyz>
 <ZNsXBFsFsKcCbP0q@paquier.xyz>
 <CA+hUKGLhFdd-G1DCk9Ze3KnQ_2jUkxyXvGwV_Ha=DWMrDnGHng@mail.gmail.com>
 <ZNxqFgo243DOar4L@paquier.xyz>
 <ZN65RHuB+qNS/G9Q@paquier.xyz>
 <CA+hUKGL0P6CiKuTuxp_bV3peyE61huwPmLEFqVdCt5waqy3QOA@mail.gmail.com>
 <ZN75xA4v14ImLvhy@paquier.xyz>
 <ZOKil9ifJmmAb6di@paquier.xyz>
 <ZPKQA+HHqLVRFBSs@paquier.xyz>
 <1641161693655508@ske52ucy55r5y36k.iva.yp-c.yandex.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="IU82yZwQlwjrgEEE"
Content-Disposition: inline
In-Reply-To: <1641161693655508@ske52ucy55r5y36k.iva.yp-c.yandex.net>
Archived-At: 
 <https://www.postgresql.org/message-id/ZPPIf3Uzp9iFrE6M%40paquier.xyz>
Precedence: bulk


--IU82yZwQlwjrgEEE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Sep 02, 2023 at 02:51:48PM +0300, Sergei Kornilov wrote:
> Corresponding tmp_check/log/regress_log_038_end_of_wal show error:
>=20
> No such file or directory at /home/melkij/tmp/srcs/postgresql/src/test/re=
covery/../../../src/test/perl/PostgreSQL/Test/Utils.pm line 725.
>=20
> pg_config from scan_header function returns
> /home/melkij/tmp/srcs/postgresql/tmp_install/home/melkij/tmp/pgdev/inst/i=
nclude
> , then the function tries to concatenate
> server/access/xlog_internal.h, while the required file is in
> postgresql/server/access/xlog_internal.h from this directory.
>=20
> If I change the test like this for both scan_header, then it succeeds.
>=20
> - my @scan_result =3D scan_header('server/access/xlog_internal.h',
> + my @scan_result =3D scan_header('postgresql/server/access/xlog_internal=
=2Eh',
>=20
> Is there something wrong with my setup?

I think that's just a mistake I did, as there should not even be a
need for having to specify "server/" for the header path.  If you
switch scan_header() in Utils.pm to use --includedir-server rather
than --includedir, does it work correctly for you?=20
--
Michael

--IU82yZwQlwjrgEEE
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmTzyH8ACgkQnvQgOdby
QH15ARAAp1eG52hCwUD3TbFjlt0wDo1wVQJcfoIXEUM3o8rAxo3y/tmBOtSGgQGl
0An2hihLAU7GJBPfkhFYIYafVE6KiaDu3ndwB89+Dl9TlWcvDxbuox/Q08OCuxuz
CCt+o5UdUvhO9Th2rZ/XvGpwXRjVgfK+t522A4z1pVwJDo3D9AOfFbtHXGzEdIhF
xiWL2c5SV/l6APzClfoCM9uEwGiyrVUko7k/7AH5U9TTMmyeoTY341fyjOfq9JLm
oM6IKjT8G+GD59ss3ps0FtO2P5YzfVZueA7UkrPD/BRkCYVlmoYQZ4QICB+i7+rP
6Xs8acvwKdxqJW515CNHa7vDkxbIJ+tpZ42tq+2xjmQdWfA28fj7ox6945jWfUv4
tvIgZ+x3KuVaaUXHEG55IjEd0XXOGLQ1AnyHbCo7tlnE57BySh+bP6q/vdOryrhk
srjJHZhzXoKyqJM3B/7kSRuawlWw/hmQzyPl57F65KeXEhMMIjodW+tTnXxhCgEg
pn6G3xVaNkPcJ6RVyx933npLR8pgzUY5eiQkYXJ5ZDy9BUi8jp+rHqmGdjOuZh+u
mEw3vyrkg9lkZLwsoHMFN0fuLX/jLVFmAZUi+KQDVsiqFQLfuIiOzWdFsgbiUEXi
zsG3S9Ro1dfO9DYPG8aqxmRvPeWldAwZQsNFL0EQXkzw2oxeYVo=
=Z+0d
-----END PGP SIGNATURE-----

--IU82yZwQlwjrgEEE--