Date: Thu, 21 Sep 2023 15:30:37 -0400
From: Stephen Frost <sfrost@snowman.net>
To: =?utf-8?B?QWxlxaEgWmVsZW7DvQ==?= <zeleny.ales@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: Invalid dump file after drop of role that previously created
 extension containing a table.
Message-ID: <ZQyZ3QOOs0BlWGyf@tamriel.snowman.net>
References: 
 <CAODqTUZSHn=7HWUGjqnQa5f58jKoh=ee9h=1_LrdLiQ5XT3Hvg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Y87q3EWew0AfSKOy"
Content-Disposition: inline
In-Reply-To: 
 <CAODqTUZSHn=7HWUGjqnQa5f58jKoh=ee9h=1_LrdLiQ5XT3Hvg@mail.gmail.com>
User-Agent: Mutt/2.1.4 (2021-12-11)
Archived-At: 
 <https://www.postgresql.org/message-id/ZQyZ3QOOs0BlWGyf%40tamriel.snowman.net>
Precedence: bulk


--Y87q3EWew0AfSKOy
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Greetings,

* Ale=C5=A1 Zelen=C3=BD (zeleny.ales@gmail.com) wrote:
> Testcase description:
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> 1) An extension (I've used pg_cron as an example because it contains a
> table) is created by a database user (login role), and the initial
> privileges at extension creation are stored for the extension object
> (table in my test case) in the pg_catalog.pg_init_privs table.
> 2) Change the database user objects ownership from step 1 to another
> database user -> this step keeps the pg_catalog.pg_init_privs table
> content for the extension table from step 1 untouched.
> 3) Drop the database user used in step 1 and as its entry is deleted
> from the catalog, all that remains is the OID of the deleted database
> user in the pg_catalog.pg_init_privs table, later used by pg_dump.

Hrmpf.  Yeah, seems like if we're going to allow extensions and
extension objects to be impacted by REASSIGN OWNED and such then we need
to be sure to update pg_init_privs accordingly.  At least that's my
first thought seeing this.  Would welcome thoughts from others on this
though.

Thanks,

Stephen

--Y87q3EWew0AfSKOy
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEwf6gbxKhD863zrx/7WyKOINHZFUFAmUMmdsACgkQ7WyKOINH
ZFV7RQ//anS//rMg+LkoUKB9PbplbG0x+g34khO9/v3jpUFKjbYX6zAgBokYkhuu
ADSzk0vQp2M1aHXB7QDmq9+TrBiflXvhDJxZkpOYIgoLxoJX/Su6O6YHL+6yHLwd
7pXMv8z1FW+z4YA15mDakWUh2bywysjXb2LIrgIHiuEWcv94z0MoVxcFG9md5aWO
2NMUDzVov/N25aPE7s9u9ZkuNoS51z/HdGOeTHXQv/LMzZygQ92SmlFfb+/Pc5Sr
49NEqPfsAsKhp+t+NtWvsyG0VITV8k59VsNQ7SA0G2pmRqWLkSvJzeBiG7rzoiRD
I8zmTN7EPDqO7fQUNDbQuHap5141z/y7J75rXdhSRCVsY6ZrMFEt+w/otXGAnJAI
8D5MhR3Ak6oyV1a5QC37ZLQe2ItcykSTmTO/OewoYXJv2RHGkylEOrRm9GmCakcq
ufm4VWcyQN9GewZneaO36EIgmCi9pHZiGArJ6vkRDr5SCC61r4335IpCzSsJ0RWF
NmCFBepZWTf1nnPFRETXBc6S03oJ/HJD1HmUrQAspGSK5UvK6uoXvpofvAula7rd
7+kn5gpPguZKSkd5aG9ZuDAniK0XuauwukbhlrC7UiTG+e0lMxqxQbX5geFRKSJo
K+8BfXodbuxhMVJgLtAmS6qXdr4/x7ljZ8VCevxHjyUnNbPEiko=
=PRWc
-----END PGP SIGNATURE-----

--Y87q3EWew0AfSKOy--