Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qku8U-00HRIZ-72 for pgsql-bugs@arkaria.postgresql.org; Mon, 25 Sep 2023 22:33:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qku8S-005UPT-Oe for pgsql-bugs@arkaria.postgresql.org; Mon, 25 Sep 2023 22:33:00 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qku8S-005UPG-Fp for pgsql-bugs@lists.postgresql.org; Mon, 25 Sep 2023 22:33:00 +0000 Received: from momjian.us ([72.94.173.45]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qku8L-007Z3h-7K for pgsql-bugs@lists.postgresql.org; Mon, 25 Sep 2023 22:32:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=momjian.us; s=2023062407; h=In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-ID:Content-Description; bh=X0aO0TOEV9oMMoLjrSSQ3IOBPRaYJxVJsWi0+g4LD/Y=; b=TeDAJMaGOpfmEaQQou3pSiw+E5 +f4cXM/l5nN8LQ/QACNpBwcKaCIefjfrGK7m+AcDYdlr3mKdeDGmBWVBN6QsyROaxa27T8Oe4Ixpc ATG+uRlyuChk9wS3sRgmdZSkYfTodtIJ3PQSy80TMhuZZcPdzqX2JKRan70pE+WmiIfnMHT/tbdHe iEzUr3lkEnza59Y+aG0MGhcG1vqju1bP7GuFhMvhb6Sh9mfDH64WJe4KUYr9iz8MRuhI8I9U+/ERo z0wEN1ZgMQIko6Q7W1gt0mXjXPq+pABUUF352jE2ZRlSLZf4TslKU0EOwgoERG/nsAwJnNW1f0ibq sI+WVq9A==; Received: from bruce by momjian.us with local (Exim 4.96) (envelope-from ) id 1qku8G-00CXP9-17; Mon, 25 Sep 2023 18:32:48 -0400 Date: Mon, 25 Sep 2023 18:32:48 -0400 From: Bruce Momjian To: Andres Freund Cc: Tom Lane , Peter Geoghegan , harukat@sraoss.co.jp, pgsql-bugs@lists.postgresql.org Subject: Re: BUG #18124: PG16 release note document bug in "Add build option to allow testing of small WAL segment sizes" Message-ID: References: <18124-d363fa4873e176d6@postgresql.org> <837536.1695348498@sss.pgh.pa.us> <20230925174504.tldeeux5atf5zawf@alap3.anarazel.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230925174504.tldeeux5atf5zawf@alap3.anarazel.de> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Mon, Sep 25, 2023 at 10:45:04AM -0700, Andres Freund wrote: > Hi, > > On 2023-09-21 22:08:18 -0400, Tom Lane wrote: > > Peter Geoghegan writes: > > > On Thu, Sep 21, 2023 at 6:47 PM Bruce Momjian wrote: > > >> Uh, it is true that we don't have any segment sizes other than WAL, but > > >> I am not sure people would easily know that, so I added WAL so people > > >> knew. > > > > > But the commit in question added a new option that can be used to > > > control the relation segment size -- not the WAL segment size. > > > Obviously, that's what TAKATSUKA-san meant. > > > > Yeah. The release note entry is simply wrong to say it's WAL segment size. > > Agreed. Bruce are you committing that bit? Yes, I will try to do it tomorrow. > > I would also argue that d3b111e32's installation.sgml changes > > were poorly worded, because they only say "segment size" which can > > easily be misunderstood, just as happened here. Better would be > > "relation segment size" or "table segment size". > > Hm. Yea. I copied the language from --with-segsize, but there there's > subsequent sentences that do clarify what the option relates to. I prefer > "relation" over "table" as it affects indexes as well. > > Pushed that adjustment. Thanks. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.