pg.ddx.io pgsql-bugs@postgresql.org mailing list archive
help / color / mirror / Atom feedBUG #18137: PG16 release note doc bug in "Allow GRANT group_name TO user_name ..."
4+ messages / 3 participants
[nested] [flat]
Commits from this thread:
2023-09-29 527c3c1bec doc: fix link to ALTER GROUP
2023-09-29 2882d1f31a doc: PG 16 relnotes: change GRANT GROUP item to ALTER GROUP
* BUG #18137: PG16 release note doc bug in "Allow GRANT group_name TO user_name ..."
@ 2023-09-28 07:24 PG Bug reporting form <noreply@postgresql.org>
0 siblings, 1 reply; 4+ messages in thread
From: PG Bug reporting form @ 2023-09-28 07:24 UTC (permalink / raw)
To: pgsql-bugs@lists.postgresql.org; +Cc: harukat@sraoss.co.jp
The following bug has been logged on the website:
Bug reference: 18137
Logged by: TAKATSUKA Haruka
Email address: harukat@sraoss.co.jp
PostgreSQL version: 16.0
Operating system: any
Description:
In the following release note item, it seems that "GRANT group_name TO
user_name"
should be "ALTER GROUP group_name ADD USER user_name".
As far as I have tested and confirmed, ALTER GROUP is the one that
has been allowed since version 16.
test steps:
db1=# CREATE ROLE usr1 LOGIN;
db1=# CREATE ROLE usr2 LOGIN;
db1=# CREATE ROLE usr3 LOGIN;
db1=# CREATE ROLE grp1;
db1=# GRANT grp1 TO usr1 WITH ADMIN OPTION;
db1=# \c db1 usr1
db1=> ALTER GROUP grp1 ADD USER usr2;
15.x: ERROR: permission denied
16.0: GRANT successfully
db1=> GRANT grp1 TO usr3;
15.x: GRANT successfully
16.0: GRANT successfully
release note item (release-16.sgml 963) :
<!--
Author: Robert Haas <rhaas@postgresql.org>
2022-08-22 [ce6b672e4] Make role grant system more consistent with other
privil
-->
<listitem>
<para>
Allow <link linkend="sql-grant"><literal>GRANT group_name TO
user_name</literal></link> to be performed with <literal>ADMIN
OPTION</literal> (Robert Haas)
</para>
<para>
Previously <literal>CREATEROLE</literal> permission was required.
</para>
</listitem>
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: BUG #18137: PG16 release note doc bug in "Allow GRANT group_name TO user_name ..."
@ 2023-09-29 18:15 Bruce Momjian <bruce@momjian.us>
parent: PG Bug reporting form <noreply@postgresql.org>
0 siblings, 1 reply; 4+ messages in thread
From: Bruce Momjian @ 2023-09-29 18:15 UTC (permalink / raw)
To: harukat@sraoss.co.jp; pgsql-bugs@lists.postgresql.org
On Thu, Sep 28, 2023 at 07:24:35AM +0000, PG Bug reporting form wrote:
> The following bug has been logged on the website:
>
> Bug reference: 18137
> Logged by: TAKATSUKA Haruka
> Email address: harukat@sraoss.co.jp
> PostgreSQL version: 16.0
> Operating system: any
> Description:
>
> In the following release note item, it seems that "GRANT group_name TO
> user_name"
> should be "ALTER GROUP group_name ADD USER user_name".
> As far as I have tested and confirmed, ALTER GROUP is the one that
> has been allowed since version 16.
Yes, you are correct. Attached patch applied.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
Attachments:
REL_16_STABLE.diff (text/x-diff, 630B) download
diff --git a/doc/src/sgml/release-16.sgml b/doc/src/sgml/release-16.sgml
index 47b9960f5d..ff51851897 100644
--- a/doc/src/sgml/release-16.sgml
+++ b/doc/src/sgml/release-16.sgml
@@ -967,8 +967,8 @@ Author: Robert Haas <rhaas@postgresql.org>
<listitem>
<para>
- Allow <link linkend="sql-grant"><literal>GRANT group_name TO
- user_name</literal></link> to be performed with <literal>ADMIN
+ Allow <link linkend="sql-grant"><literal>ALTER GROUP group_name
+ ADD USER user_name</literal></link> to be performed with <literal>ADMIN
OPTION</literal> (Robert Haas)
</para>
* Re: BUG #18137: PG16 release note doc bug in "Allow GRANT group_name TO user_name ..."
@ 2023-09-29 18:17 Tom Lane <tgl@sss.pgh.pa.us>
parent: Bruce Momjian <bruce@momjian.us>
0 siblings, 1 reply; 4+ messages in thread
From: Tom Lane @ 2023-09-29 18:17 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; +Cc: harukat@sraoss.co.jp; pgsql-bugs@lists.postgresql.org
Bruce Momjian <bruce@momjian.us> writes:
> On Thu, Sep 28, 2023 at 07:24:35AM +0000, PG Bug reporting form wrote:
>> In the following release note item, it seems that "GRANT group_name TO
>> user_name"
>> should be "ALTER GROUP group_name ADD USER user_name".
>> As far as I have tested and confirmed, ALTER GROUP is the one that
>> has been allowed since version 16.
> Yes, you are correct. Attached patch applied.
Should probably change the <link> target too?
regards, tom lane
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: BUG #18137: PG16 release note doc bug in "Allow GRANT group_name TO user_name ..."
@ 2023-09-29 18:32 Bruce Momjian <bruce@momjian.us>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 4+ messages in thread
From: Bruce Momjian @ 2023-09-29 18:32 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: harukat@sraoss.co.jp; pgsql-bugs@lists.postgresql.org
On Fri, Sep 29, 2023 at 02:17:20PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > On Thu, Sep 28, 2023 at 07:24:35AM +0000, PG Bug reporting form wrote:
> >> In the following release note item, it seems that "GRANT group_name TO
> >> user_name"
> >> should be "ALTER GROUP group_name ADD USER user_name".
> >> As far as I have tested and confirmed, ALTER GROUP is the one that
> >> has been allowed since version 16.
>
> > Yes, you are correct. Attached patch applied.
>
> Should probably change the <link> target too?
Ah, good point, done.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2023-09-29 18:32 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-09-28 07:24 BUG #18137: PG16 release note doc bug in "Allow GRANT group_name TO user_name ..." PG Bug reporting form <noreply@postgresql.org>
2023-09-29 18:15 ` Bruce Momjian <bruce@momjian.us>
2023-09-29 18:17 ` Tom Lane <tgl@sss.pgh.pa.us>
2023-09-29 18:32 ` Bruce Momjian <bruce@momjian.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox