Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qqIyl-009Aib-34 for pgsql-bugs@arkaria.postgresql.org; Tue, 10 Oct 2023 20:05:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qqIyi-00A38k-Ee for pgsql-bugs@arkaria.postgresql.org; Tue, 10 Oct 2023 20:05:17 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qqIyh-00A38c-W9 for pgsql-bugs@lists.postgresql.org; Tue, 10 Oct 2023 20:05:16 +0000 Received: from momjian.us ([72.94.173.45]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qqIyf-0010LX-V1 for pgsql-bugs@lists.postgresql.org; Tue, 10 Oct 2023 20:05:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=momjian.us; s=2023062407; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description; bh=z8Z+h0iQsMZDFAOdO/yiukPukJ+Ob5z9ieQJgS9FJJU=; b=rukxx vfYQXG0T0nlbV3MIdg+tvwEX7U435KOj3oQfvd+fhWzjd7cmsKe07YXTlI9yz9DGAJvz4H3Z3CSfB p7Tn7ziqVNoZ0uFqU/ojnKLEMERf4mFFUdcaZrAfNXXGLg4MLXM4t3+mBtqtn2olA0mTs1g4t3vuc K12+ztjY3Bu1yqTHc572aPOJ/DdzklSJmaqa4AgdgYlGNbE9VC++pV+vJyLli0xfV8+J75ECFaLr2 7nLnGbCQ4uSssqmO3p78CUh6tSIZTng76bw5cxH4V0rkA3kv1mlizZpuaixciO4gF+L9fjh5XOAkc KXCYuHafLxOnnFkW7LRMQh2Dv6PrQ==; Received: from bruce by momjian.us with local (Exim 4.96) (envelope-from ) id 1qqIyd-0023k1-1H; Tue, 10 Oct 2023 16:05:11 -0400 Date: Tue, 10 Oct 2023 16:05:11 -0400 From: Bruce Momjian To: Tom Lane Cc: Pete Storer , "pgsql-bugs@lists.postgresql.org" Subject: Re: FW: Query execution failure Message-ID: References: <2957101.1674746628@sss.pgh.pa.us> <2961799.1674749201@sss.pgh.pa.us> <802119.1695863173@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu, Sep 28, 2023 at 09:48:02AM -0400, Bruce Momjian wrote: > On Wed, Sep 27, 2023 at 10:27:34PM -0400, Bruce Momjian wrote: > > On Wed, Sep 27, 2023 at 09:06:13PM -0400, Tom Lane wrote: > > > Bruce Momjian writes: > > > > The attached patch documents this remote sort order requirement. > > > > > > That seems like quite a random place to insert the documentation. > > > I doubt that the requirement applies only to upper paths -- FDWs > > > are allowed to return sorted paths for base relations too, > > > comparable to indexscan paths. > > > > That is the only section of the docs that mentions sort pushdown. > > I don't see another reasonable location. > > I now think the fdw docs are the wrong place for this since it is a user > requirement, not a developer one. I put it in CREATE SERVER, patch > attached. Patch applied back to PG 11. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.