Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 24 Nov 2023 11:49:21 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Ivan Trofimov <i.trofimow@yandex.ru>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: libpq: pipeline mode might desynchronize client and server
Message-ID: <ZWAPMRqhifJ8YVNW@paquier.xyz>
References: <1efe6f16-30f1-8dd2-7d5a-a6acc4203cc1@yandex.ru>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="eIp4LAPTWslV2Jap"
Content-Disposition: inline
In-Reply-To: <1efe6f16-30f1-8dd2-7d5a-a6acc4203cc1@yandex.ru>
Archived-At: 
 <https://www.postgresql.org/message-id/ZWAPMRqhifJ8YVNW%40paquier.xyz>
Precedence: bulk


--eIp4LAPTWslV2Jap
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Nov 22, 2023 at 03:13:46AM +0300, Ivan Trofimov wrote:
> This is a follow up on
> https://www.postgresql.org/message-id/17948-fcace7557e449957@postgresql.o=
rg.

Is this the same bug as discussed on this other thread?  Why is there
a need for a second thread?

> Libpq in pipeline mode considers '< 2TDCEZ' a sufficient response to
> '> BDESS', when according to specification one more 'Z' is expected.
> This leads to client <-> server desynchronization, when libpq parses the
> very next message server sends (which is Z, as expected).
>=20
> A bit more context and a MRE:
> https://github.com/itrofimow/libpq_protocol_desync
>=20
> I'm pretty sure that this branch https://github.com/postgres/postgres/blo=
b/3af101ce8be8eeb0e8adc61e293b5d12989f68be/src/interfaces/libpq/fe-exec.c#L=
2124
> should be adjusted to handle the case and do not match error response
> against sync query.

Could you attach the test case to the original thread please (assuming
that this is the same problem)?  If this data is deleted by github,
then any data making a problem reproducible would be lost.
--
Michael

--eIp4LAPTWslV2Jap
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmVgDzEACgkQnvQgOdby
QH0XlQ/8CgHmtfqH3V0hFN5eZuIlXI7bVrMPn0FT06VHxU7HjS4b1Q91Ij7AF4vs
trbp/8TM4KudhbKSzWWAdpu+Rnnwyw8+O2TTIlG4vyKsyq+o0Uqm05DxQMxg+PBA
sioC5hfkl0t8Wokithl+qn2py+0tlzlSwN4fMRDM4aMv+0dmOjkVOH52DEHLkwWk
jCYDsqENRefbG85tdO+0JJx4Ow054tEc1ShXHZ58kgjJcL/FyDRwmj/vziqK+L6j
z0vDpUoTsc6jeMmxk7YaGUcvT0TVCtBDd+BIjasu3wAytls6Fay4ChyB0J5rXGcN
PCRafVdY5MMO8aODFdX3L1w/bvHTITwYico1U+IyFNAI1lZnQAIYaTiHcYWze4yi
EWVQqmFvmtLHmOMe+kHg0qtbrlvbdZWWnmmTKnwOdmjfnx6FrUsv/YvTAOenN2XE
fJivCmEZIaU7b5exBU6t/Spnu5kHBMtupE+IwiGhmNLLsCJo+4OaMfXnF9vMDHT2
o/2mG+jxLe8ugkC7IUwy86y//85GQx007z1X1wnWZspGxQPJD3Kat8wuy1oCxMoO
phT1eYHddXWnrhribkdVw2+WCeL6GaZ4IZHKZb99ba3SyOu6F78+wyQBC3jZIps3
Z2xfrR9VdE7lK1TZ7UphYBVskCtON4FxWmcGIkzajKATdFFHdkI=
=yiz+
-----END PGP SIGNATURE-----

--eIp4LAPTWslV2Jap--