Date: Sun, 26 Nov 2023 02:36:57 -0500
From: Stephen Frost <sfrost@snowman.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: lars@greiz-reinsdorf.de, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18210: libpq: PQputCopyData sometimes fails in non-blocking
 mode over GSSAPI encrypted connection
Message-ID: <ZWL1maezJ6DPIdD3@tamriel.snowman.net>
References: <18210-4c6d0b14627f2eb8@postgresql.org>
 <1675678.1700665886@sss.pgh.pa.us>
 <2199742.1700680746@sss.pgh.pa.us>
 <2524668.1700692174@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="NmelZd4C1SNAbMXe"
Content-Disposition: inline
In-Reply-To: <2524668.1700692174@sss.pgh.pa.us>
User-Agent: Mutt/2.1.4 (2021-12-11)
Archived-At: 
 <https://www.postgresql.org/message-id/ZWL1maezJ6DPIdD3%40tamriel.snowman.net>
Precedence: bulk


--NmelZd4C1SNAbMXe
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Greetings,

* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> I wrote:
> > I wonder if we should drop the idea of returning a positive bytecount
> > after a partial write, and just return the pqsecure_raw_write result,
> > and not reset PqGSSSendConsumed until we write everything presented.
> > In edge cases maybe that would result in some buffer bloat, but it
> > doesn't seem worse than what happens when the very first
> > pqsecure_raw_write returns EINTR.
>=20
> Here's a patch that fixes it along those lines.  I like this better,
> I think, not least because it removes the assumption that "interesting"
> pqsecure_raw_write failures will recur on the next try.

Thanks for looking into this.  I agree with this approach and took a
look through the patch and it all makes sense to me.

> Still need to look at syncing the backend with this.

I see you made similar changes to the backend and those also look good.

Thanks again,

Stephen

--NmelZd4C1SNAbMXe
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEwf6gbxKhD863zrx/7WyKOINHZFUFAmVi9ZYACgkQ7WyKOINH
ZFVqWA//TCuWdI22xUmJP9dgzWAhCFrIMZ9vCe+efIZB1gcx+XYm/GA0F2N1UWeX
mLnAiz2l+PjbwJDIMGvZ5H+Ag+tir5FhyA8x2NROwDOatBTAdmy9TVMmgMNtVeUl
e/0Ld8V1Ib7GgLWN7oBn4WxUyCZtXRqz/vUVbxY8v4NX4kQj2Bb6j7Y0A6DMVZ/h
gD0vlW0Jy+j13xmxmND7IpCuWQxKAOwqcrautS6m2yThfN5st+0FXwk3OaxDIK4j
OSkcGTnbXwgDswXfjjJ2ObEwbuNeyP9IUDYgJbm1i/5D3N9DsrkIzJUio+OysgDw
xNdlCX7d1aiSrYdiz58pFOdEL1CwKa3elhvGJ3fjObh1FDS/XNwd+yd3yAiG1gHI
qh56BpRXZULk4u0eW7TR4NBtFuqbj+UXo/cSKlm7Ygz6KwLxPDIgZkpXlJuOQKYm
2M/KfyLhqhM4rmei+FMTQyF73pMcJB9Po+7YP3eRTMZQPh7Urt0MYU2gN39ComfL
o5Xqa9oaNcOQfYTwkCqoL3Z/jKTp3BSSFi6qroyirusJ9KpCS8qhHBxbfb+LCHRq
oasVel+cgPKe8XsXwKFcNYsMIx3kXpmB/mLeVcwOJZfh+DO81Nr/TzNhP8/mu7S4
vkGgW1z+Qrl9kYy3p5hmbBwxw6Aw7vd2zAhB2esoAy1MlU/sZ98=
=Aj49
-----END PGP SIGNATURE-----

--NmelZd4C1SNAbMXe--