Feedback-ID: i0fe9450f:Fastmail
Date: Sat, 16 Dec 2023 10:19:22 +0100
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: David Rowley <dgrowleyml@gmail.com>, exclusion@gmail.com,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18240: Undefined behaviour in cash_mul_flt8() and friends
Message-ID: <ZX1rmhppwgaczYQ7@paquier.xyz>
References: <18240-c5da758d7dc1ecf0@postgresql.org>
 <ZXbi3xo7QhQIe1YN@paquier.xyz>
 <2171714.1702307153@sss.pgh.pa.us>
 <ZXgh74Ykj3iWvXKr@paquier.xyz>
 <CAApHDvrBLa=gQ0tCg8727RaZXWDg1sDvFJ2+-DVy5SC=NSSKkg@mail.gmail.com>
 <2433182.1702391878@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="PH2QHmmebQAT8PIU"
Content-Disposition: inline
In-Reply-To: <2433182.1702391878@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/ZX1rmhppwgaczYQ7%40paquier.xyz>
Precedence: bulk


--PH2QHmmebQAT8PIU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Dec 12, 2023 at 09:37:58AM -0500, Tom Lane wrote:
> ... I doubt that a contrib module would solve the problem for people
> who can't afford a rewrite.  pg_upgrade requires that datatype OIDs
> stay the same, which is something I don't believe a contrib module
> could manage.  We've run into that before if memory serves.  Is it
> time to do something about that?  Perhaps we could allow extension
> modules to use binary_upgrade_set_next_pg_type_oid, and then somehow
> reserve the money and _money OIDs forever?

You mean with an integration in binary dumps?  I don't see why it
would not work and this facility may prove to be useful for
out-of-core extension, assuming that this can be made transparent
based on some new .control properties on the upgrade cluster, I
guess..

Now, I am not sure that we're making users a favor in keeping around a
data type that's kind of obsolete these days, particularly when all of
them basically require handling of fractional cents when doing serious
calculations.  That's a trap in disguise, even if tying data to a
locale for the unit sounds appealing for some applications.
--
Michael

--PH2QHmmebQAT8PIU
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmV9a5oACgkQnvQgOdby
QH230g/8CVUu2m63FLXvwzJ19gfk9JTR+ebZjp3RPy0et6KVswEOMXx3vAl6xWzM
/kTQEAGiwiye0XNINPJTQ2Bls2ttmVm4gCEeJ6YZmnFpURT4LMlgt151ZCKYi0Fn
6Q0ggmldaF9N7eVG5a4puK1MZSCPOKuLEhP+huB8TMki3vCLlB/9sHV7XQQy74pa
MmXOPA9d/coFc8yR7TYvtHck50cZQlP9wXetsKH2fL9AoRAzRfrdlMeX0EJJGqlJ
37e7OB698/v3DcPiZUXjjpyzftwGxpL84yaxfmh8YpymDuQWqKo26+l4zn6gYpHN
+XkEnswjGGuof4EGWnxVwiPmiNr2MeQRPfa28GYJ67Ha8PnIwqZ8ViN0/euvPULQ
jrClfmnQKzHDLnktrqjCfb5BO9Biukb68lWYopQzbh56sT8rkXZeUxeQsziYFxWx
9lQexZ8Z01nnagEB5untVY0QvgXJAhpdp1QlZWIyJp4qq/DbunMZ6tiojdY5JNR2
gHWZxlzE7zucALsrRngaoo4WTN8AGYLmOoFi4WUrzFpTtmrw7Egj3+7tzREpDMJf
RxXDHTJRlPtlcnai+lG+prlVktBjIP9VBfK4s71EZk1Wspz5I+3ob4+Z1tqZfsHz
K7mqM+RpAm4oKjYl9udaMFBCPVPM8BWjS0zCl2/VNfOvAvK448I=
=JdpX
-----END PGP SIGNATURE-----

--PH2QHmmebQAT8PIU--