Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 7 Dec 2023 11:32:33 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Richard Guo <guofenglinux@gmail.com>
Cc: RekGRpth <rekgrpth@gmail.com>, Laurenz Albe <laurenz.albe@cybertec.at>,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18230: Redundant comparison of a local variable 'tzp'
 address with a NULL value at dt_common.c
Message-ID: <ZXEuwRR0Sq012eiu@paquier.xyz>
References: <18230-c68eb05e05cb9177@postgresql.org>
 <da26cdf3558c605244838ca899c96c8874bbe92d.camel@cybertec.at>
 <CAPgh2mJJ7XrHTWSnYEb92R4PoknrqopOKDe6+795=v3q1aD6Eg@mail.gmail.com>
 <51a453dfe23d1b7f33c2d9b495a4c6eb972da61e.camel@cybertec.at>
 <CAPgh2mKi8t8T7Tsqx-EwSMYG_xYQQSY30qp18sH8dVySP4Fmdg@mail.gmail.com>
 <CAMbWs48z_7Vc8_Q93QEuUaB6n3-rJPO0f8KF=gbogzTmK4hvpA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="0CCZsdKjKFoETjui"
Content-Disposition: inline
In-Reply-To: 
 <CAMbWs48z_7Vc8_Q93QEuUaB6n3-rJPO0f8KF=gbogzTmK4hvpA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ZXEuwRR0Sq012eiu%40paquier.xyz>
Precedence: bulk


--0CCZsdKjKFoETjui
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Dec 07, 2023 at 09:51:57AM +0800, Richard Guo wrote:
> There are several places in DecodeDateTime() where the value of '*tzp'
> is changed.  It seems to me that these assignments are unnecessary since
> the value of '*tzp' is not utilized anywhere in the code.  Can we also
> remove these assignments?

*tzp could be given to DecodeTimezone() and manipulated inside it, but
you are right that we don't use it at all in the DecodeDateTime()
path.  Other callers of DecodeTimezone() may depend on the changes
done inside it, though.  Perhaps DecodeTimezone() should be extended
so as it can accept a NULL value and use that in DecodeDateTime(),
eliminating the need for *tzp entirely?
--
Michael

--0CCZsdKjKFoETjui
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmVxLsEACgkQnvQgOdby
QH13cxAAjL2p3uJz8O8SNXgpgk/NbG8WsWHae94ChnDbOAD9MZBMOErP04W8XDZq
dXTuZdXvLUybB40OSDu6wv+yh+/RGtlaWLHzo4v5JKclhRw0yO8R6ZqQs+vb0ajf
tcdvIKfJrL46DjYhNI5xXy7kMidQ47PAYS4a1bOsLttR015EA5LdoJXjJQsuEZHH
aZsrwBHVno/OmyjoNDyoCrHr2C4Xi1pwjo4Tob9VcCDxJAofya4N9YF4ru8+xp7Q
zH20GrKhinTDHKsIo9OhwaGZjpPuffCZcivSTX7bxI8yuRGOiCLkG5vQjtkyJqfS
MfEr3QAdIxhf3/CbYbuaH/jOdkqALxT0DtFBj93QHCcuEOocA9axXLVqz8FP9Jei
aLZTjzai7J/Yv6hjHf2pclM8LClgAK9CHH/h4fo7k9KAYZOvoWlCskvdLkkYXkpI
vf1Yk4NkHI65LxXAbrxzy8Lpc6pCRCh1Ve6vTXVxAKy6trm4BnPheNSrbyqo+C+s
VlazRSVTMsgiNNwUi4eSQ3HMGZFCWOsmyleVmb9P0nL/vrTB6LHhxVNouHKz3nTc
+yFplEsMC5PujgTruny6cEDW45B9xDgJZV20G7z+Lwek+h+1iI2XWerO1HyJDE3p
6IGa8+m6J5dTPn192+d/4Po2PgL45Tl55wgsLM6qGs750S0+JOM=
=kxiF
-----END PGP SIGNATURE-----

--0CCZsdKjKFoETjui--